fix: editor flicker after creating xblock (#1529)

This commit is contained in:
Rômulo Penido
2024-11-26 19:41:14 -03:00
committed by GitHub
parent d08ef83659
commit 1c82a67364
2 changed files with 11 additions and 3 deletions

View File

@@ -50,11 +50,19 @@ describe('hooks', () => {
describe('initializeApp', () => {
test('calls provided function with provided data as args when useEffect is called', () => {
const dispatch = jest.fn();
const fakeData = { some: 'data' };
const fakeData = {
blockId: 'blockId',
studioEndpointUrl: 'studioEndpointUrl',
learningContextId: 'learningContextId',
};
hooks.initializeApp({ dispatch, data: fakeData });
expect(dispatch).not.toHaveBeenCalledWith(fakeData);
const [cb, prereqs] = useEffect.mock.calls[0];
expect(prereqs).toStrictEqual([fakeData]);
expect(prereqs).toStrictEqual([
fakeData.blockId,
fakeData.studioEndpointUrl,
fakeData.learningContextId,
]);
cb();
expect(dispatch).toHaveBeenCalledWith(thunkActions.app.initialize(fakeData));
});

View File

@@ -9,7 +9,7 @@ import { RequestKeys } from './data/constants/requests';
// eslint-disable-next-line react-hooks/rules-of-hooks
export const initializeApp = ({ dispatch, data }) => useEffect(
() => dispatch(thunkActions.app.initialize(data)),
[data],
[data?.blockId, data?.studioEndpointUrl, data?.learningContextId],
);
export const navigateTo = (destination: string | URL) => {