chore: Enable legacy libraries migration by default (#2561)

.env

@@ -36,7 +36,6 @@ ENABLE_ASSETS_PAGE=false
 ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN=false
 ENABLE_TAGGING_TAXONOMY_PAGES=true
 ENABLE_CERTIFICATE_PAGE=true
-ENABLE_LEGACY_LIBRARY_MIGRATOR=false
 BBB_LEARN_MORE_URL=''
 HOTJAR_APP_ID=''
 HOTJAR_VERSION=6

.env.development

@@ -39,7 +39,6 @@ ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN=true
 ENABLE_CERTIFICATE_PAGE=true
 ENABLE_NEW_VIDEO_UPLOAD_PAGE=true
 ENABLE_TAGGING_TAXONOMY_PAGES=true
-ENABLE_LEGACY_LIBRARY_MIGRATOR=true
 BBB_LEARN_MORE_URL=''
 HOTJAR_APP_ID=''
 HOTJAR_VERSION=6

.env.test

@@ -34,7 +34,6 @@ ENABLE_ASSETS_PAGE=false
 ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN=true
 ENABLE_CERTIFICATE_PAGE=true
 ENABLE_TAGGING_TAXONOMY_PAGES=true
-ENABLE_LEGACY_LIBRARY_MIGRATOR=true
 BBB_LEARN_MORE_URL=''
 INVITE_STUDENTS_EMAIL_TO="someone@domain.com"
 ENABLE_CHECKLIST_QUALITY=true

src/index.jsx

@@ -175,7 +175,6 @@ initialize({
         ENABLE_CERTIFICATE_PAGE: process.env.ENABLE_CERTIFICATE_PAGE || 'false',
         ENABLE_TAGGING_TAXONOMY_PAGES: process.env.ENABLE_TAGGING_TAXONOMY_PAGES || 'false',
         ENABLE_CHECKLIST_QUALITY: process.env.ENABLE_CHECKLIST_QUALITY || 'true',
-        ENABLE_LEGACY_LIBRARY_MIGRATOR: process.env.ENABLE_LEGACY_LIBRARY_MIGRATOR || 'false',
         ENABLE_GRADING_METHOD_IN_PROBLEMS: process.env.ENABLE_GRADING_METHOD_IN_PROBLEMS === 'true',
         LIBRARY_UNSUPPORTED_BLOCKS: (process.env.LIBRARY_UNSUPPORTED_BLOCKS || 'conditional,step-builder,problem-builder').split(','),
         COURSE_TEAM_SUPPORT_EMAIL: process.env.COURSE_TEAM_SUPPORT_EMAIL || null,

src/studio-home/tabs-section/TabsSection.test.tsx

@@ -393,10 +393,6 @@ describe('<TabsSection />', () => {
     });
 
     it('should open migration library page from v1 libraries tab', async () => {
-      setConfig({
-        ...getConfig(),
-        ENABLE_LEGACY_LIBRARY_MIGRATOR: 'true',
-      });
       await axiosMock.onGet(getStudioHomeApiUrl()).reply(200, generateGetStudioHomeDataApiResponse());
       await axiosMock.onGet(libraryApiLink).reply(200, generateGetStudioHomeLibrariesApiResponse());
       render({ librariesV2Enabled: false });
@@ -422,10 +418,6 @@ describe('<TabsSection />', () => {
     });
 
     it('should open migration library page from v2 libraries tab', async () => {
-      setConfig({
-        ...getConfig(),
-        ENABLE_LEGACY_LIBRARY_MIGRATOR: 'true',
-      });
       const libraries = generateGetStudioHomeLibrariesApiResponse().libraries.map(
         library => ({
           ...library,
@@ -542,10 +534,6 @@ describe('<TabsSection />', () => {
 
     [true, false].forEach((isMigrated) => {
       it(`should render v2 libraries migration alert when the libraries have isMigrated=${isMigrated}`, async () => {
-        setConfig({
-          ...getConfig(),
-          ENABLE_LEGACY_LIBRARY_MIGRATOR: 'true',
-        });
         const libraries = generateGetStudioHomeLibrariesApiResponse().libraries.map(
           library => ({
             ...library,

src/studio-home/tabs-section/libraries-tab/index.tsx

@@ -4,7 +4,6 @@ import {
   ActionRow, Form, Icon, Menu, MenuItem, Pagination, Row, SearchField,
 } from '@openedx/paragon';
 import { Error, FilterList } from '@openedx/paragon/icons';
-import { getConfig } from '@edx/frontend-platform';
 
 import { LoadingSpinner } from '@src/generic/Loading';
 import AlertMessage from '@src/generic/alert-message';
@@ -227,7 +226,7 @@ export const LibrariesList = ({
 
   return (
     <>
-      {!hideMigationAlert && getConfig().ENABLE_LEGACY_LIBRARY_MIGRATOR === 'true' && (<MigrateLegacyLibrariesAlert />)}
+      {!hideMigationAlert && (<MigrateLegacyLibrariesAlert />)}
       <div className="courses-tab">
         <ActionRow className="my-3">
           {inSelectMode && (