Commit Graph

1357 Commits

Author SHA1 Message Date
Adolfo R. Brandes
86b4ea79de perf: add enabled flag to TPA query hook to skip unnecessary fetches
In ProgressiveProfiling, the TPA query fired even when
registrationEmbedded was false and the result was ignored. Added an
enabled option to useThirdPartyAuthHook and set it to
registrationEmbedded in ProgressiveProfiling.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
8dcf55254e fix: call setThirdPartyAuthContextBegin only on mount in LoginPage
It was being called on every data sync effect run, causing a flash of
PENDING state even when TPA data was already available.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
e52d3d89fd fix: include payload in TPA query key to prevent stale cache
The query key only included pageId, so if the payload (tpa_hint, query
params, etc.) changed while pageId stayed the same, React Query would
serve stale cached data.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
bb3ab6cba4 perf: add staleTime to third-party auth context query
The TPA context is effectively static per session. Adding a 5-minute
staleTime prevents unnecessary background refetches when navigating
between login/register tabs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
fc40952da3 fix: correct LoginContext setter types and remove dead PASSWORD_RESET_ERROR code
LoginContext setFormFields/setErrors are useState setters that accept
updater functions, so their types should be Dispatch<SetStateAction<...>>
rather than plain function signatures.

PASSWORD_RESET_ERROR was checked in ResetPasswordPage but no code path
ever set status to that value, making the conditions dead code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
1733f6ec01 fix: remove duplicate RedirectLogistration in ProgressiveProfiling
When shouldRedirect was true and welcomePageContext.nextUrl was truthy,
both RedirectLogistration components rendered simultaneously, causing a
double redirect attempt. The first block was a subset of the second, so
removing it is sufficient.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
5d8743fb29 fix: use functional state updater in validateInput to prevent stale closure
validateInput was directly mutating the formErrors state object and
then spreading it. When handleSubmit called validateInput twice in
succession, the second call operated on stale closure values because
React batches state updates. Also fixed handleOnFocus for the same
issue.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
70ffc552b5 fix: move navigate() calls from render to useEffect in ResetPasswordPage
Calling navigate() during the render phase triggers state updates in
the router, causing React warnings and potential infinite render loops
in strict mode.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
3dbd6a76df fix: pass correct arguments to setEmailSuggestionContext in handleSuggestionClick
The function expects two string arguments (suggestion, type) but was
being called with a single object, corrupting the email suggestion state.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
cb3ad5c53a feat: migrate from Redux to React Query and React Context
Replace Redux + Redux-Saga with React Query (useMutation/useQuery) for
server state and React Context for UI/form state across all modules:
login, registration, forgot-password, reset-password, progressive-
profiling, and common-components.

Port of master commits 0d709d15 and 93bd0f24, adapted for
@openedx/frontend-base:
- getSiteConfig() instead of getConfig()
- useAppConfig() for per-app configuration
- @tanstack/react-query as peerDependency (shell provides QueryClient)
- CurrentAppProvider instead of AppProvider

Also fixes EnvironmentTypes circular dependency in site.config.test.tsx
by using string literal instead of enum import.

Co-Authored-By: Jesus Balderrama <jesus.balderrama.wgu@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Max Sokolski
65462e7d80 fix: adding value length check for full name field
Co-authored-by: Artur Filippovskii <118079918+filippovskii09@users.noreply.github.com>
Co-Authored-By: Adolfo R. Brandes <adolfo@axim.org>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
bydawen
7bfb5d16d0 fix: add missing space symbol to the 'additional.help.text' field
Co-Authored-By: Adolfo R. Brandes <adolfo@axim.org>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
kshitij.sobti
c31c397c61 feat: add Slot for login page
This change adds a Slot for the login page allowing it to be customised.

Since this touched the Login Page, LoginPage and Logistration have also
been refactored to move away from redux connect.

Adapted for frontend-base: uses Slot from @openedx/frontend-base instead
of PluginSlot from @openedx/frontend-plugin-framework, slot files live
under src/slots/, and the slot ID follows the frontend-base naming
convention (org.openedx.frontend.slot.authn.loginComponent.v1).

Co-Authored-By: Adolfo R. Brandes <adolfo@axim.org>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Ihor Romaniuk
4fc41b0fe7 fix: username suggestions alignment
Port of master commit ffb8a2d4.

Co-Authored-By: Kyrylo Hudym-Levkovych <kyr.hudym@kyrs-MacBook-Pro.local>
Co-Authored-By: Adolfo R. Brandes <adolfo@axim.org>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Hassan Raza
df9454bbe6 chore: handle forbidden username exceptions on registration
Port of master commit 58ec90ac.

Co-Authored-By: Adolfo R. Brandes <adolfo@axim.org>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Diana Villalvazo
5e41382f24 refactor: replace injectIntl with useIntl
Port of master commits db3d007c, 43a584eb, 5bd6926f, and 76e400f0.

Co-Authored-By: Adolfo R. Brandes <adolfo@axim.org>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-13 16:36:34 -03:00
Adolfo R. Brandes
fe44896856 chore: bump frontend-base to 1.0.0-alpha.14 2026-03-13 16:36:34 -03:00
javier ontiveros
ed58e02eae chore: update route base path 2026-03-12 07:18:17 -03:00
Adolfo R. Brandes
2337a7105f 1.0.0-alpha.6 v1.0.0-alpha.6 2026-03-04 10:58:29 -03:00
Adolfo R. Brandes
b9f2c5da43 feat!: compile to JS before publishing
Configure the package to compile TypeScript and copy SCSS files to dist/
before publishing, rather than publishing raw source files. This allows
us to use tsc-alias for @src imports.

Also use a more modern export map to decouple the internal file
structure from the package's API, and add a build step to CI.

BREAKING CHANGE: Consuming projects may need to update their imports or
SASS @use lines.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-13 16:02:42 -03:00
Javier Ontiveros
1a0a6e3179 feat: added code spliting on main module (#1627) 2026-02-12 16:15:08 -03:00
Adolfo R. Brandes
92208a0a7c 1.0.0-alpha.5 v1.0.0-alpha.5 2026-02-09 20:21:28 -03:00
Adolfo R. Brandes
45535ee055 build: Add minimum node version warning
An issue was found when using Node version 24.9 with the latest
package-lock (see #123), one not reproducible with versions 24.12 and
above.  Add a warning that will be shown when running `npm ci`.
2026-01-15 09:49:57 -03:00
Adolfo R. Brandes
e53c4997bb fix: missing styles
The shell's SCSS must be explicitly loaded by site.config.dev.tsx.
2026-01-15 09:49:57 -03:00
Adolfo R. Brandes
f311539e12 fix: CI
App repos are no longer built.
2026-01-15 09:49:57 -03:00
Adolfo R. Brandes
c1070930bf fix: bump frontend-base
Bump frontend-base so we stop failing linting due to the nullish
coalescing rule we can't follow.
2026-01-15 09:49:57 -03:00
Adolfo R. Brandes
dad2887eed fix: linting errors 2026-01-15 09:49:57 -03:00
Adolfo R. Brandes
4f79099eca build: Upgrade to Node 24 2026-01-15 09:49:57 -03:00
Adolfo R. Brandes
49f42a8857 feat!: add design tokens support
BREAKING CHANGE: Pre-design-tokens theming is no longer supported.
2026-01-15 09:49:57 -03:00
Adolfo R. Brandes
2d6b401312 1.0.0-alpha.4 v1.0.0-alpha.4 2025-08-20 13:12:29 -03:00
Adolfo R. Brandes
c602136798 chore: bump frontend-base and regenerate package-lock 2025-08-20 13:12:08 -03:00
Adolfo R. Brandes
9a48fe323b fix: work around inotify handle starvation
Bump frontend-base to avoid the inotify handle resource starvation.
2025-07-24 11:59:18 -03:00
Adolfo R. Brandes
967c52bde9 1.0.0-alpha.3 v1.0.0-alpha.3 2025-06-29 13:20:08 +02:00
Adolfo R. Brandes
3252b593fd fix: bump frontend-base
Bump frontend-base to alpha.4 to fix a bug with the route role
redirection mechanism.
2025-06-29 13:19:33 +02:00
Adolfo R. Brandes
c98b9a1408 1.0.0-alpha.2 v1.0.0-alpha.2 2025-06-29 13:11:02 +02:00
Adolfo R. Brandes
b6c659ccb8 feat: redirect to route role on successful login
Now we have a way to discover app URLs dynamically; do so for the
(default) redirect on login.
2025-06-29 13:09:17 +02:00
Adolfo R. Brandes
7efa279a29 1.0.0-alpha.1 v1.0.0-alpha.1 2025-06-28 22:16:19 +02:00
Adolfo R. Brandes
f83f24af89 chore: bump frontend-base 2025-06-28 22:16:07 +02:00
Adolfo R. Brandes
b8116485b0 v1.0.0-alpha.0 v1.0.0-alpha.0 2025-06-28 19:31:31 +02:00
Adolfo R. Brandes
762ff75fc4 Merge pull request #1515 from arbrandes/frontend-base-fixes
feat: Prepare for publication to NPM
2025-06-28 14:28:54 -03:00
Adolfo R. Brandes
095b156b95 chore: bump frontend-base 2025-06-28 19:27:26 +02:00
Adolfo R. Brandes
033e0fd7c5 feat: handle authentication roles 2025-06-28 19:18:34 +02:00
Adolfo R. Brandes
1ecdb0b6af chore: gitignore npm pack artifacts 2025-06-26 23:05:50 -03:00
Adolfo R. Brandes
18951cc4d0 chore: clean up npmignore 2025-06-26 23:05:50 -03:00
Adolfo R. Brandes
4dd5ddcc8b refactor: use appId from constants 2025-06-26 23:05:50 -03:00
Adolfo R. Brandes
6acbf64a71 chore: prepare for publication
Update package.json for publication as a "buildless" library.

(Also upgrade openedx-atlas.)
2025-06-26 19:52:56 -03:00
Adolfo R. Brandes
aea12a6a37 fix: remove catch-all route
Apps should avoid having a catch-all route, instead relying on the shell
to provide it.
2025-06-26 19:46:12 -03:00
Adolfo R. Brandes
3d778807f1 fix: update index.html
The only purpose of the included index.html is to serve the dev
environment, so modify it to make that clear.
2025-06-26 19:28:02 -03:00
Adolfo R. Brandes
014a990c22 docs: remove reference to devstack 2025-06-26 19:27:40 -03:00
Adolfo R. Brandes
7c8051a440 test: fix a couple of tests 2025-06-26 19:27:23 -03:00