Andal.LND/frontend-app-authn
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: change experiment name (#338)

Browse Source 
Changed experiment name to verify conversion rate anomaly noticed during
third test run.
This commit is contained in:
Waheed Ahmed
2021-06-14 15:37:39 +05:00
committed by GitHub
parent 942b91d9ce
commit d6ff06e85c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/register/RegistrationPage.jsx
View File

@@ -454,7 +454,7 @@ class RegistrationPage extends React.Component {
eventName: 'van_504_total_registrations',
});
if (this.state.optimizelyExperimentName !== 'progressive_profiling_phase1') {
if (this.state.optimizelyExperimentName !== 'progressiveProfilingConcept1') {
window.optimizely.push({
type: 'event',
eventName: 'van_504_conversion_rate',
@@ -481,7 +481,7 @@ class RegistrationPage extends React.Component {
success={this.props.registrationResult.success}
redirectUrl={this.props.registrationResult.redirectUrl}
finishAuthUrl={finishAuthUrl}
redirectToWelcomePage={this.state.optimizelyExperimentName === 'progressive_profiling_phase1'}
redirectToWelcomePage={this.state.optimizelyExperimentName === 'progressiveProfilingConcept1'}
/>
<div className="d-flex justify-content-center m-4">
<div className="d-flex flex-column">
@@ -610,7 +610,7 @@ class RegistrationPage extends React.Component {
}}
/>
</div>
{getConfig().REGISTRATION_OPTIONAL_FIELDS && this.state.optimizelyExperimentName !== 'progressive_profiling_phase1' ? (
{getConfig().REGISTRATION_OPTIONAL_FIELDS && this.state.optimizelyExperimentName !== 'progressiveProfilingConcept1' ? (
<AuthnValidationFormGroup
label={intl.formatMessage(messages['support.education.research'])}
for="optional"

4
src/register/tests/RegistrationPage.test.jsx
View File

@@ -127,10 +127,10 @@ describe('RegistrationPageTests', () => {
});
it('should not show optional field check when optimizely experiment is set', () => {
window.optimizelyExperimentName = 'progressive_profiling_phase1';
window.optimizelyExperimentName = 'progressiveProfilingConcept1';
const registrationPage = mount(reduxWrapper(<IntlRegistrationPage {...props} />));
expect(registrationPage.find('RegistrationPage').state('optimizelyExperimentName')).toEqual('progressive_profiling_phase1');
expect(registrationPage.find('RegistrationPage').state('optimizelyExperimentName')).toEqual('progressiveProfilingConcept1');
expect(registrationPage.find('#optional').length).toEqual(0);
delete window.optimizelyExperimentName;