This centralizes the logic for group membership, and means that we don't need to make queries to find out whether the legacy groups names exist.
682 lines
32 KiB
Python
682 lines
32 KiB
Python
"""
|
|
This module contains celery task functions for handling the sending of bulk email
|
|
to a course.
|
|
"""
|
|
import re
|
|
import random
|
|
import json
|
|
from time import sleep
|
|
|
|
from dogapi import dog_stats_api
|
|
from smtplib import SMTPServerDisconnected, SMTPDataError, SMTPConnectError, SMTPException
|
|
from boto.ses.exceptions import (
|
|
SESAddressNotVerifiedError,
|
|
SESIdentityNotVerifiedError,
|
|
SESDomainNotConfirmedError,
|
|
SESAddressBlacklistedError,
|
|
SESDailyQuotaExceededError,
|
|
SESMaxSendingRateExceededError,
|
|
SESDomainEndsWithDotError,
|
|
SESLocalAddressCharacterError,
|
|
SESIllegalAddressError,
|
|
)
|
|
from boto.exception import AWSConnectionError
|
|
|
|
from celery import task, current_task
|
|
from celery.utils.log import get_task_logger
|
|
from celery.states import SUCCESS, FAILURE, RETRY
|
|
from celery.exceptions import RetryTaskError
|
|
|
|
from django.conf import settings
|
|
from django.contrib.auth.models import User
|
|
from django.core.mail import EmailMultiAlternatives, get_connection
|
|
from django.core.urlresolvers import reverse
|
|
|
|
from bulk_email.models import (
|
|
CourseEmail, Optout, CourseEmailTemplate,
|
|
SEND_TO_MYSELF, SEND_TO_ALL, TO_OPTIONS,
|
|
)
|
|
from courseware.courses import get_course, course_image_url
|
|
from courseware.roles import CourseStaffRole, CourseInstructorRole
|
|
from instructor_task.models import InstructorTask
|
|
from instructor_task.subtasks import (
|
|
SubtaskStatus,
|
|
queue_subtasks_for_query,
|
|
check_subtask_is_valid,
|
|
update_subtask_status,
|
|
)
|
|
|
|
log = get_task_logger(__name__)
|
|
|
|
|
|
# Errors that an individual email is failing to be sent, and should just
|
|
# be treated as a fail.
|
|
SINGLE_EMAIL_FAILURE_ERRORS = (
|
|
SESAddressBlacklistedError, # Recipient's email address has been temporarily blacklisted.
|
|
SESDomainEndsWithDotError, # Recipient's email address' domain ends with a period/dot.
|
|
SESIllegalAddressError, # Raised when an illegal address is encountered.
|
|
SESLocalAddressCharacterError, # An address contained a control or whitespace character.
|
|
)
|
|
|
|
# Exceptions that, if caught, should cause the task to be re-tried.
|
|
# These errors will be caught a limited number of times before the task fails.
|
|
LIMITED_RETRY_ERRORS = (
|
|
SMTPConnectError,
|
|
SMTPServerDisconnected,
|
|
AWSConnectionError,
|
|
)
|
|
|
|
# Errors that indicate that a mailing task should be retried without limit.
|
|
# An example is if email is being sent too quickly, but may succeed if sent
|
|
# more slowly. When caught by a task, it triggers an exponential backoff and retry.
|
|
# Retries happen continuously until the email is sent.
|
|
# Note that the SMTPDataErrors here are only those within the 4xx range.
|
|
# Those not in this range (i.e. in the 5xx range) are treated as hard failures
|
|
# and thus like SINGLE_EMAIL_FAILURE_ERRORS.
|
|
INFINITE_RETRY_ERRORS = (
|
|
SESMaxSendingRateExceededError, # Your account's requests/second limit has been exceeded.
|
|
SMTPDataError,
|
|
)
|
|
|
|
# Errors that are known to indicate an inability to send any more emails,
|
|
# and should therefore not be retried. For example, exceeding a quota for emails.
|
|
# Also, any SMTP errors that are not explicitly enumerated above.
|
|
BULK_EMAIL_FAILURE_ERRORS = (
|
|
SESAddressNotVerifiedError, # Raised when a "Reply-To" address has not been validated in SES yet.
|
|
SESIdentityNotVerifiedError, # Raised when an identity has not been verified in SES yet.
|
|
SESDomainNotConfirmedError, # Raised when domain ownership is not confirmed for DKIM.
|
|
SESDailyQuotaExceededError, # 24-hour allotment of outbound email has been exceeded.
|
|
SMTPException,
|
|
)
|
|
|
|
|
|
def _get_recipient_queryset(user_id, to_option, course_id, course_location):
|
|
"""
|
|
Returns a query set of email recipients corresponding to the requested to_option category.
|
|
|
|
`to_option` is either SEND_TO_MYSELF, SEND_TO_STAFF, or SEND_TO_ALL.
|
|
|
|
Recipients who are in more than one category (e.g. enrolled in the course and are staff or self)
|
|
will be properly deduped.
|
|
"""
|
|
if to_option not in TO_OPTIONS:
|
|
log.error("Unexpected bulk email TO_OPTION found: %s", to_option)
|
|
raise Exception("Unexpected bulk email TO_OPTION found: {0}".format(to_option))
|
|
|
|
if to_option == SEND_TO_MYSELF:
|
|
recipient_qset = User.objects.filter(id=user_id)
|
|
else:
|
|
staff_qset = CourseStaffRole(course_location).users_with_role()
|
|
instructor_qset = CourseInstructorRole(course_location).users_with_role()
|
|
recipient_qset = staff_qset | instructor_qset
|
|
if to_option == SEND_TO_ALL:
|
|
# We also require students to have activated their accounts to
|
|
# provide verification that the provided email address is valid.
|
|
enrollment_qset = User.objects.filter(
|
|
is_active=True,
|
|
courseenrollment__course_id=course_id,
|
|
courseenrollment__is_active=True
|
|
)
|
|
recipient_qset = recipient_qset | enrollment_qset
|
|
recipient_qset = recipient_qset.distinct()
|
|
|
|
recipient_qset = recipient_qset.order_by('pk')
|
|
return recipient_qset
|
|
|
|
|
|
def _get_course_email_context(course):
|
|
"""
|
|
Returns context arguments to apply to all emails, independent of recipient.
|
|
"""
|
|
course_id = course.id
|
|
course_title = course.display_name
|
|
course_url = 'https://{}{}'.format(
|
|
settings.SITE_NAME,
|
|
reverse('course_root', kwargs={'course_id': course_id})
|
|
)
|
|
image_url = 'https://{}{}'.format(settings.SITE_NAME, course_image_url(course))
|
|
email_context = {
|
|
'course_title': course_title,
|
|
'course_url': course_url,
|
|
'course_image_url': image_url,
|
|
'account_settings_url': 'https://{}{}'.format(settings.SITE_NAME, reverse('dashboard')),
|
|
'platform_name': settings.PLATFORM_NAME,
|
|
}
|
|
return email_context
|
|
|
|
|
|
def perform_delegate_email_batches(entry_id, course_id, task_input, action_name):
|
|
"""
|
|
Delegates emails by querying for the list of recipients who should
|
|
get the mail, chopping up into batches of no more than settings.BULK_EMAIL_EMAILS_PER_TASK
|
|
in size, and queueing up worker jobs.
|
|
"""
|
|
entry = InstructorTask.objects.get(pk=entry_id)
|
|
# Get inputs to use in this task from the entry.
|
|
user_id = entry.requester.id
|
|
task_id = entry.task_id
|
|
|
|
# Perfunctory check, since expansion is made for convenience of other task
|
|
# code that doesn't need the entry_id.
|
|
if course_id != entry.course_id:
|
|
format_msg = "Course id conflict: explicit value {} does not match task value {}"
|
|
raise ValueError(format_msg.format(course_id, entry.course_id))
|
|
|
|
# Fetch the CourseEmail.
|
|
email_id = task_input['email_id']
|
|
try:
|
|
email_obj = CourseEmail.objects.get(id=email_id)
|
|
except CourseEmail.DoesNotExist:
|
|
# The CourseEmail object should be committed in the view function before the task
|
|
# is submitted and reaches this point.
|
|
log.warning("Task %s: Failed to get CourseEmail with id %s", task_id, email_id)
|
|
raise
|
|
|
|
# Check to see if email batches have already been defined. This seems to
|
|
# happen sometimes when there is a loss of connection while a task is being
|
|
# queued. When this happens, the same task gets called again, and a whole
|
|
# new raft of subtasks gets queued up. We will assume that if subtasks
|
|
# have already been defined, there is no need to redefine them below.
|
|
# So we just return right away. We don't raise an exception, because we want
|
|
# the current task to be marked with whatever it had been marked with before.
|
|
if len(entry.subtasks) > 0 and len(entry.task_output) > 0:
|
|
log.warning("Task %s has already been processed for email %s! InstructorTask = %s", task_id, email_id, entry)
|
|
progress = json.loads(entry.task_output)
|
|
return progress
|
|
|
|
# Sanity check that course for email_obj matches that of the task referencing it.
|
|
if course_id != email_obj.course_id:
|
|
format_msg = "Course id conflict: explicit value {} does not match email value {}"
|
|
raise ValueError(format_msg.format(course_id, email_obj.course_id))
|
|
|
|
# Fetch the course object.
|
|
try:
|
|
course = get_course(course_id)
|
|
except ValueError:
|
|
log.exception("Task %s: course not found: %s", task_id, course_id)
|
|
raise
|
|
|
|
# Get arguments that will be passed to every subtask.
|
|
to_option = email_obj.to_option
|
|
global_email_context = _get_course_email_context(course)
|
|
|
|
def _create_send_email_subtask(to_list, initial_subtask_status):
|
|
"""Creates a subtask to send email to a given recipient list."""
|
|
subtask_id = initial_subtask_status.task_id
|
|
new_subtask = send_course_email.subtask(
|
|
(
|
|
entry_id,
|
|
email_id,
|
|
to_list,
|
|
global_email_context,
|
|
initial_subtask_status.to_dict(),
|
|
),
|
|
task_id=subtask_id,
|
|
routing_key=settings.BULK_EMAIL_ROUTING_KEY,
|
|
)
|
|
return new_subtask
|
|
|
|
recipient_qset = _get_recipient_queryset(user_id, to_option, course_id, course.location)
|
|
recipient_fields = ['profile__name', 'email']
|
|
|
|
log.info("Task %s: Preparing to queue subtasks for sending emails for course %s, email %s, to_option %s",
|
|
task_id, course_id, email_id, to_option)
|
|
|
|
progress = queue_subtasks_for_query(
|
|
entry,
|
|
action_name,
|
|
_create_send_email_subtask,
|
|
recipient_qset,
|
|
recipient_fields,
|
|
settings.BULK_EMAIL_EMAILS_PER_QUERY,
|
|
settings.BULK_EMAIL_EMAILS_PER_TASK
|
|
)
|
|
|
|
# We want to return progress here, as this is what will be stored in the
|
|
# AsyncResult for the parent task as its return value.
|
|
# The AsyncResult will then be marked as SUCCEEDED, and have this return value as its "result".
|
|
# That's okay, for the InstructorTask will have the "real" status, and monitoring code
|
|
# should be using that instead.
|
|
return progress
|
|
|
|
|
|
@task(default_retry_delay=settings.BULK_EMAIL_DEFAULT_RETRY_DELAY, max_retries=settings.BULK_EMAIL_MAX_RETRIES) # pylint: disable=E1102
|
|
def send_course_email(entry_id, email_id, to_list, global_email_context, subtask_status_dict):
|
|
"""
|
|
Sends an email to a list of recipients.
|
|
|
|
Inputs are:
|
|
* `entry_id`: id of the InstructorTask object to which progress should be recorded.
|
|
* `email_id`: id of the CourseEmail model that is to be emailed.
|
|
* `to_list`: list of recipients. Each is represented as a dict with the following keys:
|
|
- 'profile__name': full name of User.
|
|
- 'email': email address of User.
|
|
- 'pk': primary key of User model.
|
|
* `global_email_context`: dict containing values that are unique for this email but the same
|
|
for all recipients of this email. This dict is to be used to fill in slots in email
|
|
template. It does not include 'name' and 'email', which will be provided by the to_list.
|
|
* `subtask_status_dict` : dict containing values representing current status. Keys are:
|
|
|
|
'task_id' : id of subtask. This is used to pass task information across retries.
|
|
'attempted' : number of attempts -- should equal succeeded plus failed
|
|
'succeeded' : number that succeeded in processing
|
|
'skipped' : number that were not processed.
|
|
'failed' : number that failed during processing
|
|
'retried_nomax' : number of times the subtask has been retried for conditions that
|
|
should not have a maximum count applied
|
|
'retried_withmax' : number of times the subtask has been retried for conditions that
|
|
should have a maximum count applied
|
|
'state' : celery state of the subtask (e.g. QUEUING, PROGRESS, RETRY, FAILURE, SUCCESS)
|
|
|
|
Most values will be zero on initial call, but may be different when the task is
|
|
invoked as part of a retry.
|
|
|
|
Sends to all addresses contained in to_list that are not also in the Optout table.
|
|
Emails are sent multi-part, in both plain text and html. Updates InstructorTask object
|
|
with status information (sends, failures, skips) and updates number of subtasks completed.
|
|
"""
|
|
subtask_status = SubtaskStatus.from_dict(subtask_status_dict)
|
|
current_task_id = subtask_status.task_id
|
|
num_to_send = len(to_list)
|
|
log.info("Preparing to send email %s to %d recipients as subtask %s for instructor task %d: context = %s, status=%s",
|
|
email_id, num_to_send, current_task_id, entry_id, global_email_context, subtask_status)
|
|
|
|
# Check that the requested subtask is actually known to the current InstructorTask entry.
|
|
# If this fails, it throws an exception, which should fail this subtask immediately.
|
|
# This can happen when the parent task has been run twice, and results in duplicate
|
|
# subtasks being created for the same InstructorTask entry. This can happen when Celery
|
|
# loses its connection to its broker, and any current tasks get requeued.
|
|
# We hope to catch this condition in perform_delegate_email_batches() when it's the parent
|
|
# task that is resubmitted, but just in case we fail to do so there, we check here as well.
|
|
# There is also a possibility that this task will be run twice by Celery, for the same reason.
|
|
# To deal with that, we need to confirm that the task has not already been completed.
|
|
check_subtask_is_valid(entry_id, current_task_id, subtask_status)
|
|
|
|
send_exception = None
|
|
new_subtask_status = None
|
|
try:
|
|
course_title = global_email_context['course_title']
|
|
with dog_stats_api.timer('course_email.single_task.time.overall', tags=[_statsd_tag(course_title)]):
|
|
new_subtask_status, send_exception = _send_course_email(
|
|
entry_id,
|
|
email_id,
|
|
to_list,
|
|
global_email_context,
|
|
subtask_status,
|
|
)
|
|
except Exception:
|
|
# Unexpected exception. Try to write out the failure to the entry before failing.
|
|
log.exception("Send-email task %s for email %s: failed unexpectedly!", current_task_id, email_id)
|
|
# We got here for really unexpected reasons. Since we don't know how far
|
|
# the task got in emailing, we count all recipients as having failed.
|
|
# It at least keeps the counts consistent.
|
|
subtask_status.increment(failed=num_to_send, state=FAILURE)
|
|
update_subtask_status(entry_id, current_task_id, subtask_status)
|
|
raise
|
|
|
|
if send_exception is None:
|
|
# Update the InstructorTask object that is storing its progress.
|
|
log.info("Send-email task %s for email %s: succeeded", current_task_id, email_id)
|
|
update_subtask_status(entry_id, current_task_id, new_subtask_status)
|
|
elif isinstance(send_exception, RetryTaskError):
|
|
# If retrying, a RetryTaskError needs to be returned to Celery.
|
|
# We assume that the the progress made before the retry condition
|
|
# was encountered has already been updated before the retry call was made,
|
|
# so we only log here.
|
|
log.warning("Send-email task %s for email %s: being retried", current_task_id, email_id)
|
|
raise send_exception # pylint: disable=E0702
|
|
else:
|
|
log.error("Send-email task %s for email %s: failed: %s", current_task_id, email_id, send_exception)
|
|
update_subtask_status(entry_id, current_task_id, new_subtask_status)
|
|
raise send_exception # pylint: disable=E0702
|
|
|
|
# return status in a form that can be serialized by Celery into JSON:
|
|
log.info("Send-email task %s for email %s: returning status %s", current_task_id, email_id, new_subtask_status)
|
|
return new_subtask_status.to_dict()
|
|
|
|
|
|
def _filter_optouts_from_recipients(to_list, course_id):
|
|
"""
|
|
Filters a recipient list based on student opt-outs for a given course.
|
|
|
|
Returns the filtered recipient list, as well as the number of optouts
|
|
removed from the list.
|
|
"""
|
|
optouts = Optout.objects.filter(
|
|
course_id=course_id,
|
|
user__in=[i['pk'] for i in to_list]
|
|
).values_list('user__email', flat=True)
|
|
optouts = set(optouts)
|
|
# Only count the num_optout for the first time the optouts are calculated.
|
|
# We assume that the number will not change on retries, and so we don't need
|
|
# to calculate it each time.
|
|
num_optout = len(optouts)
|
|
to_list = [recipient for recipient in to_list if recipient['email'] not in optouts]
|
|
return to_list, num_optout
|
|
|
|
|
|
def _get_source_address(course_id, course_title):
|
|
"""
|
|
Calculates an email address to be used as the 'from-address' for sent emails.
|
|
|
|
Makes a unique from name and address for each course, e.g.
|
|
|
|
"COURSE_TITLE" Course Staff <coursenum-no-reply@courseupdates.edx.org>
|
|
|
|
"""
|
|
course_title_no_quotes = re.sub(r'"', '', course_title)
|
|
|
|
# The course_id is assumed to be in the form 'org/course_num/run',
|
|
# so pull out the course_num. Then make sure that it can be used
|
|
# in an email address, by substituting a '_' anywhere a non-(ascii, period, or dash)
|
|
# character appears.
|
|
course_num = course_id.split('/')[1]
|
|
invalid_chars = re.compile(r"[^\w.-]")
|
|
course_num = invalid_chars.sub('_', course_num)
|
|
|
|
from_addr = '"{0}" Course Staff <{1}-{2}>'.format(course_title_no_quotes, course_num, settings.BULK_EMAIL_DEFAULT_FROM_EMAIL)
|
|
return from_addr
|
|
|
|
|
|
def _send_course_email(entry_id, email_id, to_list, global_email_context, subtask_status):
|
|
"""
|
|
Performs the email sending task.
|
|
|
|
Sends an email to a list of recipients.
|
|
|
|
Inputs are:
|
|
* `entry_id`: id of the InstructorTask object to which progress should be recorded.
|
|
* `email_id`: id of the CourseEmail model that is to be emailed.
|
|
* `to_list`: list of recipients. Each is represented as a dict with the following keys:
|
|
- 'profile__name': full name of User.
|
|
- 'email': email address of User.
|
|
- 'pk': primary key of User model.
|
|
* `global_email_context`: dict containing values that are unique for this email but the same
|
|
for all recipients of this email. This dict is to be used to fill in slots in email
|
|
template. It does not include 'name' and 'email', which will be provided by the to_list.
|
|
* `subtask_status` : object of class SubtaskStatus representing current status.
|
|
|
|
Sends to all addresses contained in to_list that are not also in the Optout table.
|
|
Emails are sent multi-part, in both plain text and html.
|
|
|
|
Returns a tuple of two values:
|
|
* First value is a SubtaskStatus object which represents current progress at the end of this call.
|
|
|
|
* Second value is an exception returned by the innards of the method, indicating a fatal error.
|
|
In this case, the number of recipients that were not sent have already been added to the
|
|
'failed' count above.
|
|
"""
|
|
# Get information from current task's request:
|
|
task_id = subtask_status.task_id
|
|
|
|
try:
|
|
course_email = CourseEmail.objects.get(id=email_id)
|
|
except CourseEmail.DoesNotExist as exc:
|
|
log.exception("Task %s: could not find email id:%s to send.", task_id, email_id)
|
|
raise
|
|
|
|
# Exclude optouts (if not a retry):
|
|
# Note that we don't have to do the optout logic at all if this is a retry,
|
|
# because we have presumably already performed the optout logic on the first
|
|
# attempt. Anyone on the to_list on a retry has already passed the filter
|
|
# that existed at that time, and we don't need to keep checking for changes
|
|
# in the Optout list.
|
|
if subtask_status.get_retry_count() == 0:
|
|
to_list, num_optout = _filter_optouts_from_recipients(to_list, course_email.course_id)
|
|
subtask_status.increment(skipped=num_optout)
|
|
|
|
course_title = global_email_context['course_title']
|
|
subject = "[" + course_title + "] " + course_email.subject
|
|
from_addr = _get_source_address(course_email.course_id, course_title)
|
|
|
|
course_email_template = CourseEmailTemplate.get_template()
|
|
try:
|
|
connection = get_connection()
|
|
connection.open()
|
|
|
|
# Define context values to use in all course emails:
|
|
email_context = {'name': '', 'email': ''}
|
|
email_context.update(global_email_context)
|
|
|
|
while to_list:
|
|
# Update context with user-specific values from the user at the end of the list.
|
|
# At the end of processing this user, they will be popped off of the to_list.
|
|
# That way, the to_list will always contain the recipients remaining to be emailed.
|
|
# This is convenient for retries, which will need to send to those who haven't
|
|
# yet been emailed, but not send to those who have already been sent to.
|
|
current_recipient = to_list[-1]
|
|
email = current_recipient['email']
|
|
email_context['email'] = email
|
|
email_context['name'] = current_recipient['profile__name']
|
|
|
|
# Construct message content using templates and context:
|
|
plaintext_msg = course_email_template.render_plaintext(course_email.text_message, email_context)
|
|
html_msg = course_email_template.render_htmltext(course_email.html_message, email_context)
|
|
|
|
# Create email:
|
|
email_msg = EmailMultiAlternatives(
|
|
subject,
|
|
plaintext_msg,
|
|
from_addr,
|
|
[email],
|
|
connection=connection
|
|
)
|
|
email_msg.attach_alternative(html_msg, 'text/html')
|
|
|
|
# Throttle if we have gotten the rate limiter. This is not very high-tech,
|
|
# but if a task has been retried for rate-limiting reasons, then we sleep
|
|
# for a period of time between all emails within this task. Choice of
|
|
# the value depends on the number of workers that might be sending email in
|
|
# parallel, and what the SES throttle rate is.
|
|
if subtask_status.retried_nomax > 0:
|
|
sleep(settings.BULK_EMAIL_RETRY_DELAY_BETWEEN_SENDS)
|
|
|
|
try:
|
|
log.debug('Email with id %s to be sent to %s', email_id, email)
|
|
|
|
with dog_stats_api.timer('course_email.single_send.time.overall', tags=[_statsd_tag(course_title)]):
|
|
connection.send_messages([email_msg])
|
|
|
|
except SMTPDataError as exc:
|
|
# According to SMTP spec, we'll retry error codes in the 4xx range. 5xx range indicates hard failure.
|
|
if exc.smtp_code >= 400 and exc.smtp_code < 500:
|
|
# This will cause the outer handler to catch the exception and retry the entire task.
|
|
raise exc
|
|
else:
|
|
# This will fall through and not retry the message.
|
|
log.warning('Task %s: email with id %s not delivered to %s due to error %s', task_id, email_id, email, exc.smtp_error)
|
|
dog_stats_api.increment('course_email.error', tags=[_statsd_tag(course_title)])
|
|
subtask_status.increment(failed=1)
|
|
|
|
except SINGLE_EMAIL_FAILURE_ERRORS as exc:
|
|
# This will fall through and not retry the message.
|
|
log.warning('Task %s: email with id %s not delivered to %s due to error %s', task_id, email_id, email, exc)
|
|
dog_stats_api.increment('course_email.error', tags=[_statsd_tag(course_title)])
|
|
subtask_status.increment(failed=1)
|
|
|
|
else:
|
|
dog_stats_api.increment('course_email.sent', tags=[_statsd_tag(course_title)])
|
|
if settings.BULK_EMAIL_LOG_SENT_EMAILS:
|
|
log.info('Email with id %s sent to %s', email_id, email)
|
|
else:
|
|
log.debug('Email with id %s sent to %s', email_id, email)
|
|
subtask_status.increment(succeeded=1)
|
|
|
|
# Pop the user that was emailed off the end of the list only once they have
|
|
# successfully been processed. (That way, if there were a failure that
|
|
# needed to be retried, the user is still on the list.)
|
|
to_list.pop()
|
|
|
|
except INFINITE_RETRY_ERRORS as exc:
|
|
dog_stats_api.increment('course_email.infinite_retry', tags=[_statsd_tag(course_title)])
|
|
# Increment the "retried_nomax" counter, update other counters with progress to date,
|
|
# and set the state to RETRY:
|
|
subtask_status.increment(retried_nomax=1, state=RETRY)
|
|
return _submit_for_retry(
|
|
entry_id, email_id, to_list, global_email_context, exc, subtask_status, skip_retry_max=True
|
|
)
|
|
|
|
except LIMITED_RETRY_ERRORS as exc:
|
|
# Errors caught here cause the email to be retried. The entire task is actually retried
|
|
# without popping the current recipient off of the existing list.
|
|
# Errors caught are those that indicate a temporary condition that might succeed on retry.
|
|
dog_stats_api.increment('course_email.limited_retry', tags=[_statsd_tag(course_title)])
|
|
# Increment the "retried_withmax" counter, update other counters with progress to date,
|
|
# and set the state to RETRY:
|
|
subtask_status.increment(retried_withmax=1, state=RETRY)
|
|
return _submit_for_retry(
|
|
entry_id, email_id, to_list, global_email_context, exc, subtask_status, skip_retry_max=False
|
|
)
|
|
|
|
except BULK_EMAIL_FAILURE_ERRORS as exc:
|
|
dog_stats_api.increment('course_email.error', tags=[_statsd_tag(course_title)])
|
|
num_pending = len(to_list)
|
|
log.exception('Task %s: email with id %d caused send_course_email task to fail with "fatal" exception. %d emails unsent.',
|
|
task_id, email_id, num_pending)
|
|
# Update counters with progress to date, counting unsent emails as failures,
|
|
# and set the state to FAILURE:
|
|
subtask_status.increment(failed=num_pending, state=FAILURE)
|
|
return subtask_status, exc
|
|
|
|
except Exception as exc:
|
|
# Errors caught here cause the email to be retried. The entire task is actually retried
|
|
# without popping the current recipient off of the existing list.
|
|
# These are unexpected errors. Since they might be due to a temporary condition that might
|
|
# succeed on retry, we give them a retry.
|
|
dog_stats_api.increment('course_email.limited_retry', tags=[_statsd_tag(course_title)])
|
|
log.exception('Task %s: email with id %d caused send_course_email task to fail with unexpected exception. Generating retry.',
|
|
task_id, email_id)
|
|
# Increment the "retried_withmax" counter, update other counters with progress to date,
|
|
# and set the state to RETRY:
|
|
subtask_status.increment(retried_withmax=1, state=RETRY)
|
|
return _submit_for_retry(
|
|
entry_id, email_id, to_list, global_email_context, exc, subtask_status, skip_retry_max=False
|
|
)
|
|
|
|
else:
|
|
# All went well. Update counters with progress to date,
|
|
# and set the state to SUCCESS:
|
|
subtask_status.increment(state=SUCCESS)
|
|
# Successful completion is marked by an exception value of None.
|
|
return subtask_status, None
|
|
finally:
|
|
# Clean up at the end.
|
|
connection.close()
|
|
|
|
|
|
def _get_current_task():
|
|
"""
|
|
Stub to make it easier to test without actually running Celery.
|
|
|
|
This is a wrapper around celery.current_task, which provides access
|
|
to the top of the stack of Celery's tasks. When running tests, however,
|
|
it doesn't seem to work to mock current_task directly, so this wrapper
|
|
is used to provide a hook to mock in tests, while providing the real
|
|
`current_task` in production.
|
|
"""
|
|
return current_task
|
|
|
|
|
|
def _submit_for_retry(entry_id, email_id, to_list, global_email_context, current_exception, subtask_status, skip_retry_max=False):
|
|
"""
|
|
Helper function to requeue a task for retry, using the new version of arguments provided.
|
|
|
|
Inputs are the same as for running a task, plus two extra indicating the state at the time of retry.
|
|
These include the `current_exception` that the task encountered that is causing the retry attempt,
|
|
and the `subtask_status` that is to be returned. A third extra argument `skip_retry_max`
|
|
indicates whether the current retry should be subject to a maximum test.
|
|
|
|
Returns a tuple of two values:
|
|
* First value is a dict which represents current progress. Keys are:
|
|
|
|
'task_id' : id of subtask. This is used to pass task information across retries.
|
|
'attempted' : number of attempts -- should equal succeeded plus failed
|
|
'succeeded' : number that succeeded in processing
|
|
'skipped' : number that were not processed.
|
|
'failed' : number that failed during processing
|
|
'retried_nomax' : number of times the subtask has been retried for conditions that
|
|
should not have a maximum count applied
|
|
'retried_withmax' : number of times the subtask has been retried for conditions that
|
|
should have a maximum count applied
|
|
'state' : celery state of the subtask (e.g. QUEUING, PROGRESS, RETRY, FAILURE, SUCCESS)
|
|
|
|
* Second value is an exception returned by the innards of the method. If the retry was
|
|
successfully submitted, this value will be the RetryTaskError that retry() returns.
|
|
Otherwise, it (ought to be) the current_exception passed in.
|
|
"""
|
|
task_id = subtask_status.task_id
|
|
log.info("Task %s: Successfully sent to %s users; failed to send to %s users (and skipped %s users)",
|
|
task_id, subtask_status.succeeded, subtask_status.failed, subtask_status.skipped)
|
|
|
|
# Calculate time until we retry this task (in seconds):
|
|
# The value for max_retries is increased by the number of times an "infinite-retry" exception
|
|
# has been retried. We want the regular retries to trigger max-retry checking, but not these
|
|
# special retries. So we count them separately.
|
|
max_retries = _get_current_task().max_retries + subtask_status.retried_nomax
|
|
base_delay = _get_current_task().default_retry_delay
|
|
if skip_retry_max:
|
|
# once we reach five retries, don't increase the countdown further.
|
|
retry_index = min(subtask_status.retried_nomax, 5)
|
|
exception_type = 'sending-rate'
|
|
# if we have a cap, after all, apply it now:
|
|
if hasattr(settings, 'BULK_EMAIL_INFINITE_RETRY_CAP'):
|
|
retry_cap = settings.BULK_EMAIL_INFINITE_RETRY_CAP + subtask_status.retried_withmax
|
|
max_retries = min(max_retries, retry_cap)
|
|
else:
|
|
retry_index = subtask_status.retried_withmax
|
|
exception_type = 'transient'
|
|
|
|
# Skew the new countdown value by a random factor, so that not all
|
|
# retries are deferred by the same amount.
|
|
countdown = ((2 ** retry_index) * base_delay) * random.uniform(.75, 1.25)
|
|
|
|
log.warning('Task %s: email with id %d not delivered due to %s error %s, retrying send to %d recipients in %s seconds (with max_retry=%s)',
|
|
task_id, email_id, exception_type, current_exception, len(to_list), countdown, max_retries)
|
|
|
|
# we make sure that we update the InstructorTask with the current subtask status
|
|
# *before* actually calling retry(), to be sure that there is no race
|
|
# condition between this update and the update made by the retried task.
|
|
update_subtask_status(entry_id, task_id, subtask_status)
|
|
|
|
# Now attempt the retry. If it succeeds, it returns a RetryTaskError that
|
|
# needs to be returned back to Celery. If it fails, we return the existing
|
|
# exception.
|
|
try:
|
|
send_course_email.retry(
|
|
args=[
|
|
entry_id,
|
|
email_id,
|
|
to_list,
|
|
global_email_context,
|
|
subtask_status.to_dict(),
|
|
],
|
|
exc=current_exception,
|
|
countdown=countdown,
|
|
max_retries=max_retries,
|
|
throw=True,
|
|
)
|
|
except RetryTaskError as retry_error:
|
|
# If the retry call is successful, update with the current progress:
|
|
log.exception('Task %s: email with id %d caused send_course_email task to retry.',
|
|
task_id, email_id)
|
|
return subtask_status, retry_error
|
|
except Exception as retry_exc:
|
|
# If there are no more retries, because the maximum has been reached,
|
|
# we expect the original exception to be raised. We catch it here
|
|
# (and put it in retry_exc just in case it's different, but it shouldn't be),
|
|
# and update status as if it were any other failure. That means that
|
|
# the recipients still in the to_list are counted as failures.
|
|
log.exception('Task %s: email with id %d caused send_course_email task to fail to retry. To list: %s',
|
|
task_id, email_id, [i['email'] for i in to_list])
|
|
num_failed = len(to_list)
|
|
subtask_status.increment(subtask_status, failed=num_failed, state=FAILURE)
|
|
return subtask_status, retry_exc
|
|
|
|
|
|
def _statsd_tag(course_title):
|
|
"""
|
|
Calculate the tag we will use for DataDog.
|
|
"""
|
|
tag = "course_email:{0}".format(course_title)
|
|
return tag[:200]
|