Commit Graph

18624 Commits

Author SHA1 Message Date
Usama Sadiq
c304f6d0d0 Merge pull request #26317 from edx/usamasadiq/bom-2308-pylint-amnesty
Applied pylint-amnesty
2021-02-03 18:23:51 +05:00
Jawayria
ec24dfaec8 Merge pull request #26310 from edx/py-amnesty-student
Applied pylint-amnesty to student
2021-02-03 18:07:24 +05:00
Jawayria
2468698ea1 Merge pull request #26312 from edx/amnesty-track
Applied pylint-amnesty to track
2021-02-03 18:06:55 +05:00
Jawayria
dd99f8e02d Resolved quality errors 2021-02-03 17:05:12 +05:00
Jawayria
fbd60f1814 REsolved quality error 2021-02-03 17:01:52 +05:00
Jawayria
633b9f7060 resolved errors 2021-02-03 15:47:18 +05:00
Jawayria
c059acc8ae Merge pull request #26309 from edx/amnesty-thirdpartyauth
Applied pylint-amnesty to third_party_auth
2021-02-03 15:36:18 +05:00
Jawayria
45e5cbb599 Applied pylint-amnesty to student 2021-02-03 15:30:47 +05:00
Jawayria
0cdfdb7e9b Resolved issues 2021-02-03 15:29:53 +05:00
Jawayria
8086ca75f2 Applied pylint-amnesty to student 2021-02-03 15:29:53 +05:00
edX cache uploader bot
43ea6c5904 Updating Bokchoy testing database cache (#26334) 2021-02-03 13:55:42 +05:00
Jawayria
c958cf9920 Resolved quality failures 2021-02-03 13:43:56 +05:00
Jawayria
7be5a683aa Applied pylint-amnesty to third_party_auth 2021-02-03 13:37:05 +05:00
Jawayria
6be60b2fcc Resolved quality failures 2021-02-03 13:13:00 +05:00
Jawayria
62bc555817 Applied pylint-amnesty to track 2021-02-03 13:10:42 +05:00
Kyle McCormick
b626a43fa1 fix: Rename some tasks to match new import paths (#26236)
Several tasks are explicitly named as (or like)
their old, deprecated import path.

The issue here is that django-user-tasks listens for task
invocations, and attempts to import the task based on its name.
If the task name is completely wrong, user-tasks will catch
the ImportError and move on.
If the task is a valid *deprecated* import, though, then
user-tasks will choke on the raised `DeprecatedEdxPlatformImportError`.

Thus, we must rename three tasks to their new full path:
1. entitlements.expire_old_enrollments
2. third_party_auth.fetch_saml_metadata
3. student.send_activation_email

The first two are run daily, and so are safe to be
renamed in place.

The third task must be renamed using an expand-contract
pattern; otherwise, we would drop hundreds of tasks
during the App vs. Worker out-of-sync version window
that happens at deployments.
This commit is the expand phase.
2021-02-02 10:26:08 -05:00
Usama Sadiq
29d715d82d Merge pull request #26301 from edx/test
Applied pylint-amnesty to pipeline_mako
2021-02-02 20:19:11 +05:00
Jawayria
edfced071d Resolved quality errors 2021-02-02 19:19:33 +05:00
Jawayria
4dad2ab406 Applied pylint-amnesty to static_replace 2021-02-02 19:19:33 +05:00
Jawayria
3f1fd27534 Resolved quality error 2021-02-02 18:36:41 +05:00
Jawayria
6f06cc5e05 Applied pylint-amnesty to pipeline_mako 2021-02-02 18:32:11 +05:00
usamasadiq
de99865eb6 Fix pep8 errors 2021-02-02 17:59:20 +05:00
usamasadiq
515458b9dc Applied pylint-amnesty 2021-02-02 17:59:20 +05:00
Usama Sadiq
2eb4298c08 Merge pull request #26318 from edx/bom-2312
Applied pylint-amnesty to common/{lib, test, __init__.py}
2021-02-02 16:52:00 +05:00
Usama Sadiq
84deed7ad8 Merge pull request #26314 from edx/amnesty-xblockdjango
Applied pylint-amnesty to xblock_django
2021-02-02 16:51:12 +05:00
Usama Sadiq
390429f8fb Merge pull request #26306 from edx/amnesty-terrain
Applied pylint-amnesty to terrain
2021-02-02 16:51:01 +05:00
Usama Sadiq
8f919bdbe1 Merge pull request #26303 from edx/amnesty-status
Applied pylint-amnesty to status
2021-02-02 16:50:46 +05:00
Jawayria
9e677960bf Applied pylint-amnesty to common/{lib, test, __init__.py} 2021-02-02 15:42:02 +05:00
Jawayria
f3846144a5 Applied pylint-amnesty to xblock_django 2021-02-02 15:09:08 +05:00
Jawayria
fb6a62b753 Applied pylint-amnesty to terrain 2021-02-02 14:37:08 +05:00
Zaman Afzal
712a6bcc0c ENT-4034 Added more detail in exception (#26299) 2021-02-02 13:54:20 +05:00
Jawayria
3ce03896af Applied pylint-amnesty to status 2021-02-02 13:38:45 +05:00
Bianca Severino
42e1ac0888 Merge pull request #26182 from edx/bseverino/proctoring-requirements-email
[MST-515] Automated proctoring requirements email
2021-02-01 10:19:56 -05:00
Bianca Severino
902ab02357 Send proctoring requirements email when enrolled in relevant course mode 2021-02-01 09:44:30 -05:00
usamasadiq
dbfec8ee3c Remove nonrequired conditions 2021-02-01 16:30:47 +05:00
Zaman Afzal
b99a64c385 ENT-3798 Multiple_SSO_Accounts_Association_to_SAML_User (#26170) 2021-02-01 11:44:12 +05:00
Feanil Patel
50efb38ccc Add Anonymous ID related ADR.
For a given course/user tuple, anonymous ID will not change once it
has been generated and saved.
2021-01-29 14:12:19 -05:00
Robert Raposa
a34e209ba5 Merge pull request #26226 from eduNEXT/lmm/student.courseenrollment_admin
[TSD] annotations for student.courseenrollment_admin
2021-01-29 10:44:56 -05:00
Luis Moreno
a1664d2fd8 feat: Move student.courseenrollment_admin from LegacyWaffleSwitch t a WaffleSwitch and add annotations 2021-01-29 09:31:02 -04:00
Ali Akbar
0aa1b8f2bf Merge pull request #214 from edx/IM/security-fixes-5
Incident Management Security Fixes 5
2021-01-29 16:55:08 +05:00
edX cache uploader bot
2f994a9b21 Updating Bokchoy testing database cache (#26225) 2021-01-29 14:56:13 +05:00
adeelehsan
55d2a4f897 Logistration MFE renamed to authn
VAN-300
2021-01-29 11:37:54 +05:00
Matthew Piatetsky
ff839c364e Merge pull request #26143 from edx/AA-613
[AA-613] Add contains_content_type_gated_content attribute to display items in the Sequence Metadata API.
2021-01-28 12:28:05 -05:00
Matthew Piatetsky
84fb4679c9 Add contains_content_type_gated_content attribute to display items in the Sequence Metadata API. This attribute is used to display the content type gating paywall in frontend-app-learning.
Also, refactor existing timed exam code that checks for content_type_gated_content in a sequence to make it try with the new code
AA-613
2021-01-28 12:00:53 -05:00
Albert (AJ) St. Aubin
1927ea234a [MICROBA-952] Updating CourseEntitlements Admin to disallow changes to
order number
.
2021-01-28 08:55:53 -05:00
stvn
b55a3f9680 Merge PR #26200 fix/mfe-rollout/anonymous-access
* Commits:
  fix: Fix KeyError in vertical_block
2021-01-27 12:19:20 -08:00
stvn
e09a5c9d94 fix: Fix KeyError in vertical_block
This now mimics the way this is (safely) done in the sequence module [1].

References:
- [1] 5f94a082ce/common/lib/xmodule/xmodule/seq_module.py (L657-L658)
2021-01-27 11:40:13 -08:00
Tim McCormack
4359be96f3 Tweaks to anonymous user ID code path monitoring (#26194)
- Use different attribute names for new and old versions of function
- Use a shorter name overall (for ease of analysis)
- Add monitor for fetched-existing case
- Only record computed-stored if `get_or_create` succeeds, but also
  break it into created vs. fetched cases by checking return value
- Correct name of monitor in `except` clause -- that should only happen
  for a race inside `get_or_create` itself. There's a different race in
  the `anonymous_uid_for_user` between fetch and compute/save.
- Other name tweaks

ARCHBOM-1674
2021-01-27 16:12:55 +00:00
Tim McCormack
e0e03dec5f Use more appropriate hash when making tracking ID; document SECRET_KEY use (#26134)
- Make it easier to rotate `SECRET_KEY` by documenting this usage
  for both sensitivity and rotation process. (ARCHBOM-1676).
- Just use a hash of the secret rather than HMAC + MD5. We're not
  authenticating a message, so HMAC isn't really needed -- it just needs
  to be unique, deterministic, and irreversible. SHAKE allows generation
  of an arbitrary length hash without needing to truncate.

Also, rename tracking session ID generator for clarity -- there's no
encryption happening here.

Add additional test for existing claim of uniqueness.
2021-01-27 14:13:42 +00:00
Muhammad Soban Javed
d26a59eb67 import task decorator from celery APP instance in CMS (#25953)
* import task decorator from celery APP instance instead of celery package in CMS

* replaced task decorator with shared_task in cms and common

* Fixed import of shared_task

* Fixed import
2021-01-27 18:35:11 +05:00