Commit Graph

18333 Commits

Author SHA1 Message Date
Diana Huang
ba3cf691b9 Merge pull request #910 from edx/alex/add_lti_to_rc
Alex/add lti to rc
2013-09-10 05:42:43 -07:00
Valera Rozuvan
ee02c06250 Add Learning Tools Interoperability (LTI) blade.
LTI blade allows to include LTI components to courses.
Python integration, Jasmine and acceptance tests are included.
2013-09-10 12:30:42 +03:00
Alexander Kryklia
0958a2757a Merge pull request #898 from edx/alex/lti_module_squashed
LTI module with tests
2013-09-10 00:57:35 -07:00
Julian Arni
0acaaa8859 Fix element name conflict 2013-09-09 18:32:01 -04:00
Xavier Antoviaque
8d2297eb62 accessibility: Allow to close help modal with "escape" key (LMS-581)
Users should be able to close the modal with the "escape" key.
2013-09-09 18:14:59 -03:00
Xavier Antoviaque
aee5af5332 accessibility: Manage keyboard focus on help modal dialog (LMS-581)
Modal dialogs should manage keyboard focus, ensuring that users can't
tab out of the modal dialog and back into the page itself (effectively
moving “behind” the dimmed modal). On the last focusable element of the
dialog, return focus back to the first focusable element.

Also move the close button to the start of the dialog's section, making
it the first focusable URL, to ensure focus matches the visual
representation of the dialog.
2013-09-09 18:14:53 -03:00
Valera Rozuvan
d02ef8bc12 Add Learning Tools Interoperability (LTI) blade.
LTI blade allows to include LTI components to courses.
Python integration, Jasmine and acceptance tests are included.
2013-09-09 23:54:49 +03:00
Diana Huang
dc42e1f954 Merge pull request #894 from edx/diana/confirmation-email
Clean up text of Order Confirmation E-mail.
2013-09-09 13:52:06 -07:00
Alexander Kryklia
0734d835a1 Merge pull request #895 from edx/alex/revert_unsquashed_pr
Revert "Merge pull request #804 from edx/valera/lti_module"
2013-09-09 12:56:38 -07:00
Diana Huang
24efb4e8d6 Clean up text of Order Confirmation E-mail. 2013-09-09 15:56:01 -04:00
Alexander Kryklia
719ec8f9d8 Revert "Merge pull request #804 from edx/valera/lti_module"
This reverts commit 2894b21c32, reversing
changes made to 34d0fe1554.
2013-09-09 22:51:57 +03:00
Xavier Antoviaque
23eab5c5bd accessibility: Replace close modal button <div> by <a> link (LMS-582)
The close button for the modal dialog was marked up as a paragraph,
containing a graphical text character, inside two div elements, with an
associated click event. This made the button unusable for keyboard
users.

Replaced <divs> with a link element (<a role="button"), adapted the CSS
accordingly, and updated the existing <a> modal close buttons.
2013-09-09 16:43:44 -03:00
Alexander Kryklia
2894b21c32 Merge pull request #804 from edx/valera/lti_module
LTI module with tests
2013-09-09 12:38:01 -07:00
David Ormsbee
34d0fe1554 Merge pull request #890 from edx/ormsbee/verifyuser3
User verification / validated certificates feature
2013-09-09 11:30:09 -07:00
Xavier Antoviaque
4629ce73f6 accessibility: Add aria-hidden attribute to the help modal (LMS-584)
Added a 'aria-hidden="true"' attribute to the modal initially, then
toggle the value of that attribute to "false" when the modal is shown.
Also remove the attribute when the modal is closed, whether it's through
a click on the close button or on the overlay.
2013-09-09 15:26:39 -03:00
Diana Huang
d3454e58b5 Undo some of the hacks to make receipt rendering work. 2013-09-09 14:02:28 -04:00
David Ormsbee
ec3db3efde Make Certificate tests subclass ModuleStoreTestCase to fix missing course 2013-09-09 13:54:27 -04:00
Xavier Antoviaque
9147051e7a accessibility: Focus on error messages in Help modal (LMS-584)
> To make this change explicit to assistive technology, focus should be
> moved programmatically to this div after it has been made visible. To
> allow the div to be focused via scripting (without adding it to the
> regular focus order that keyboard users cycle through), a tabindex=”-1”
> should be added.

> In addition, the invalid fields should be given a an
> aria-invalid="true" attribute.
2013-09-09 14:10:29 -03:00
David Ormsbee
af8475ad31 Make sure CourseFactory creates desired courses before shopping cart tests run. 2013-09-09 13:09:17 -04:00
Xavier Antoviaque
f708806118 accessibility: Add aria-describedby to login/forgot password (LMS-602)
Also adding the email description to the login page and applying the
same aria attribute to the correspondin input on that page.

From LMS-602:

> There is additional explanatory text, marked up in a span element after
> the email input. The input elements should be explicitly associated with
> this additional text using the aria-describedby attribute. This will
> require an ID to be assigned to the span element.
2013-09-09 14:07:10 -03:00
Alexander Kryklia
ecc37227f2 Fix 2013-09-09 19:32:44 +03:00
Alexander Kryklia
8377f490f0 Revert "Add custom LTI exception."
This reverts commit ef4b7b9b1d.
2013-09-09 19:30:44 +03:00
Alexander Kryklia
cd72f05778 Fix test 2013-09-09 19:16:19 +03:00
Alexander Kryklia
03de84ecfe Fix 2013-09-09 19:16:18 +03:00
Alexander Kryklia
bd6fed83eb Fix. 2013-09-09 19:16:18 +03:00
Alexander Kryklia
ef4b7b9b1d Add custom LTI exception. 2013-09-09 19:16:18 +03:00
Valera Rozuvan
86dbb1fe3f Addressing comments on PR 804.
Rewriting expect() calls to use Jasmine jQuery event spies. Making individual
it() tests independent.
2013-09-09 19:16:18 +03:00
Alexander Kryklia
c63170aea5 Fix 2013-09-09 19:16:18 +03:00
Alexander Kryklia
5e8aebf00b Fix 2013-09-09 19:16:18 +03:00
Alexander Kryklia
a5016473b2 Fix 2013-09-09 19:16:18 +03:00
Alexander Kryklia
f45eddc1cb Fix 2013-09-09 19:16:17 +03:00
Alexander Kryklia
cf70a986d6 Fix 2013-09-09 19:16:17 +03:00
Alexander Kryklia
c4259ba9bf Fix 2013-09-09 19:16:17 +03:00
Alexander Kryklia
494fd52de0 Fix 2013-09-09 19:16:17 +03:00
Alexander Kryklia
45da4115d1 Fix 2013-09-09 19:16:17 +03:00
Alexander Kryklia
5e3c6736ab Fixes. 2013-09-09 19:16:16 +03:00
Alexander Kryklia
6220da32c9 Improve code. 2013-09-09 19:16:16 +03:00
Alexander Kryklia
dd4fe82b00 Improve code. 2013-09-09 19:16:16 +03:00
Valera Rozuvan
6fc280d611 Updated Jasmine tests.
Now the introductory text is of a more serious nature.
2013-09-09 19:16:16 +03:00
Alexander Kryklia
56f01ce056 Improve code. 2013-09-09 19:16:16 +03:00
Alexander Kryklia
32138d3539 Improve code. 2013-09-09 19:16:16 +03:00
Alexander Kryklia
a2224e6820 Improve code style. 2013-09-09 19:16:15 +03:00
Alexander Kryklia
663ff81bc1 Updates documentation. 2013-09-09 19:16:15 +03:00
Alexander Kryklia
787545c83e Renames LTIs to lti_passports. 2013-09-09 19:16:15 +03:00
Alexander Kryklia
7b637d49d6 Add comma in last item of list. 2013-09-09 19:16:15 +03:00
Valera Rozuvan
a187657810 Updated fixture for LTI Jasmine tests. 2013-09-09 19:16:15 +03:00
Alexander Kryklia
ab3cde8a4d Fix 2013-09-09 19:16:14 +03:00
Alexander Kryklia
faa03f0e25 Update docstrings. 2013-09-09 19:16:14 +03:00
Alexander Kryklia
d563929337 Add correct acceptance tests for LTI 2013-09-09 19:16:14 +03:00
Alexander Kryklia
462a42e99e Update acceptance test 2013-09-09 19:16:14 +03:00