Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Addressing comments on PR 804.

Browse Source 
Rewriting expect() calls to use Jasmine jQuery event spies. Making individual
it() tests independent.
This commit is contained in:
Valera Rozuvan
2013-09-09 17:28:46 +03:00
committed by Alexander Kryklia
parent c63170aea5
commit 86dbb1fe3f
1 changed files with 37 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
common/lib/xmodule/xmodule/js/spec/lti/constructor.js
View File

@@ -26,55 +26,57 @@
(function () {
describe('LTI', function () {
var element, errorMessage, frame,
editSettings = false;
// This function will be executed before each of the it() specs
// in this suite.
beforeEach(function () {
spyOn($.fn, 'submit').andCallThrough();
loadFixtures('lti.html');
element = $('#lti_id');
errorMessage = element.find('.error_message');
form = element.find('.ltiLaunchForm');
frame = element.find('.ltiLaunchFrame');
// First part of the tests will be running without the settings
// filled in. Once we reach the describe() spec
//
// "After the settings were filled in"
//
// the variable `editSettings` will be changed to `true`.
if (editSettings) {
form.attr('action', 'http://www.example.com/');
}
LTI(element);
});
describe('constructor', function () {
describe('before settings were filled in', function () {
var element, errorMessage, frame;
// This function will be executed before each of the it() specs
// in this suite.
beforeEach(function () {
loadFixtures('lti.html');
element = $('#lti_id');
errorMessage = element.find('.error_message');
form = element.find('.ltiLaunchForm');
frame = element.find('.ltiLaunchFrame');
spyOnEvent(form, 'submit');
LTI(element);
});
it(
'when URL setting is filled form is not submited',
function () {
expect($.fn.submit).not.toHaveBeenCalled();
expect('submit').not.toHaveBeenTriggeredOn(form);
});
});
describe('After the settings were filled in', function () {
it('editSettings is disabled', function () {
expect(editSettings).toBe(false);
var element, errorMessage, frame;
// Let us toggle edit settings switch. Next beforeEach()
// will populate element's attributes with settings.
editSettings = true;
// This function will be executed before each of the it() specs
// in this suite.
beforeEach(function () {
loadFixtures('lti.html');
element = $('#lti_id');
errorMessage = element.find('.error_message');
form = element.find('.ltiLaunchForm');
frame = element.find('.ltiLaunchFrame');
spyOnEvent(form, 'submit');
// The user "fills in" the necessary settings, and the
// form will get an action URL.
form.attr('action', 'http://www.example.com/');
LTI(element);
});
it('when URL setting is filled form is submited', function () {
expect($.fn.submit).toHaveBeenCalled();
expect('submit').toHaveBeenTriggeredOn(form);
});
});
});