Commit Graph

59583 Commits

Author SHA1 Message Date
Justin Hynes
e62df6fa0b refactor!: Remove unused is_certificate_valid function
[MICROBA-1354]

* Remove unused `is_certificate_valid` function
2021-08-06 15:54:03 -04:00
Chris Deery
8aedebcdb2 Merge pull request #28384 from edx/cdeery/AA-893/DontShowViewAsLearner
fix: [AA-939] Don't show View As Learner if partitions exist
2021-08-06 10:20:35 -04:00
Matthew Piatetsky
5db6cbb795 Merge pull request #28320 from edx/AA-902
feat: update course goals with new fields and a waffle flag to toggle the new behavior
2021-08-06 09:13:22 -04:00
Matthew Piatetsky
8183a5ae64 address comments 2021-08-05 21:45:58 -04:00
Manjinder Singh
f7c5a109d4 Revert "feat: add explicit courserun_key parameter to /event endpoint" (#28410) 2021-08-05 18:05:20 -04:00
Alexander Sheehan
24c87b5521 maint: bumping enterprise version to 3.27.19 2021-08-05 17:45:57 -04:00
Braden MacDonald
da09bcadc5 refactor: run modulestore tests in common/lib/... using Django
Does 3 things:
(1) Use django for modulestore tests
(2) Use normal LMS settings for modulestore tests instead of openedx/tests/settings.py
(3) Simplify some TestCase subclasses by converting them to use ModuleStoreTestCase


Details and rationale:

(1) Currently parts of the modulestore test suite are designed to run "without django", although there is still a lot of django functionality imported at times, and many of the tests do in fact use django. But for the upcoming PR #27565 (moving split's course indexes from MongoDB to MySQL), we will need to always have Django enabled. So this commit paves the way for that change.

(2) The previous tests that did use Django used a special settings file, openedx/tests/settings.py which made some debugging confusing because those tests had quite different django settings than other tests. This change deletes that file and runs the tests using the LMS test settings.

(3) The test suite also contains many different ways of initializing and testing a modulestore, with significant differences in their configuration, and also a lot of repetition. I find this makes understanding, debugging and writing tests more difficult. So this commit also reduces the number of different "test case using modulestore" base classes:

* Simplifies MixedWithOptionsTestCase and MixedSplitTestCase by making them simple subclasses of ModuleStoreTestCase.
* Removes PureModulestoreTestCase.
2021-08-05 12:20:19 -07:00
Alexander J Sheehan
daac2f7585 Merge pull request #28406 from edx/asheehan-edx/ENT-4733-3-27-16
maint: bumping enterprise version to 3.27.17
2021-08-05 14:35:33 -04:00
kenclary
e14ceaab3f Merge pull request #28333 from edx/TNL-7752
feat: add explicit courserun_key parameter to /event endpoint
2021-08-05 13:59:42 -04:00
cdeery
b4b461b698 fix: collapse unit tests by using ddt 2021-08-05 13:40:03 -04:00
Alexander Sheehan
86aea4d93e maint: bumping enterprise version to 3.27.17 2021-08-05 13:37:41 -04:00
Braden MacDonald
9ce7d57556 refactor: remove unused methods from split modulestore 2021-08-05 10:27:41 -07:00
Braden MacDonald
188e9fb15e fix: use integer user IDs consistently for modulestore APIs/tests
Some actions in split modulestore record the user ID who requested the action. Currently, split modulestore doesn't care what data type you use for those user IDs. Most of the codebase uses integers, but some tests used username or email address strings.

My upcoming PR #27565 will move split modulestore's "course index" data from MongoDB into MySQL. In doing so, it requires that user IDs are always numeric. So this PR paves the way for that one by using numeric IDs consistently in all test cases. I believe the actual non-test code was already consistently using integer IDs.
2021-08-05 10:26:43 -07:00
cdeery
eafea504ac fix: changes suggested in code review
Cleaned up the nits.
2021-08-05 12:35:54 -04:00
Justin Hynes
3a87aad963 Merge pull request #28391 from edx/jhynes/microba-1354
refactor: update name of `cert_generation_enabled` function name to reflect actual purpose
2021-08-05 12:27:42 -04:00
mohtamba
67da5bbb9c Merge pull request #28399 from edx/mohtamba/adjust-special-exam-dropdown-spacing
Fixed spacing on special exam dropdown headers
2021-08-05 10:00:53 -04:00
mohtamba
32ef868bad Adjusted structure of code to minimize changes 2021-08-05 08:31:12 -04:00
Mehak Nasir
c7bb91f589 Merge pull request #28402 from edx/test-fix
fix: description text fix for wiki
2021-08-05 15:56:13 +05:00
Mehak Nasir
a488f33542 fix: description text fix for wiki 2021-08-05 14:12:33 +05:00
Jawayria
29f29f9da1 Merge pull request #28380 from edx/jawayria/tox-modernizer
chore: Executed tox-modernizer codemod
2021-08-05 13:04:54 +05:00
edX cache uploader bot
cf53db8f29 Updating Bokchoy testing database cache (#28398) 2021-08-05 10:10:05 +05:00
Ken Clary
bbb14a2c6a feat: add explicit courserun_key parameter to /event endpoint
We add 'courserun_key' (aka "course_id" though that's technically a
misnomer) as an optional parameter to the /event endpoint url. If it
is not present, it will still be parsed out of the url, if the url is
of the right format.

Additionally, Logger.log() in js adds this parameter to its /event
call, pulling it from the $$course_id global.

This provides opportunity for MFEs to (separately) provide the key
without concern about url parsing.

TNL-7752
2021-08-04 22:47:43 -04:00
edX Transifex Bot
e25f4af13f geoip2: update maxmind geolite country database 2021-08-05 02:24:24 +05:00
mohtamba
30a70d06c2 Fixed spacing on dropdowns 2021-08-04 15:25:02 -04:00
Jawayria
5bba158419 Merge pull request #28355 from edx/jawayria/lms-codemod-1
chore: Executed codemods on lms
2021-08-04 21:14:45 +05:00
Andrew Shultz
7303e771a5 Merge pull request #28397 from edx/ashultz0/proctoring3230
chore: update edx-proctoring to 3.23.0
2021-08-04 11:58:04 -04:00
Olivia Ruiz-Knott
3d25549110 Merge pull request #28394 from edx/ork/MICROBA-1417_add-certificate-date-override-to-admin
feat: Add CertificateDateOverride model to admin
2021-08-04 09:36:54 -06:00
Alexander J Sheehan
ea3af16818 Merge pull request #28396 from edx/asheehan-edx/bumping-enterprise-3-27-16
maint: bumping enterprise version to 3.27.16
2021-08-04 11:31:06 -04:00
Jawayria
542da2ef6a Merge pull request #28356 from edx/jawayria/openedx-codemod
chore: Executed codemods on openedx module
2021-08-04 20:30:08 +05:00
Andy Shultz
1e1e302509 chore: update edx-proctoring to 3.23.0 2021-08-04 11:16:11 -04:00
Jansen Kantor
f4c5dc25b7 ora 3.6.17 (#28393) 2021-08-04 11:12:09 -04:00
Leangseu Kim
3e3c83629b chore: version bump for edx-bulk-grades 2021-08-04 10:58:57 -04:00
Alexander Sheehan
f924b5c7f9 maint: bumping enterprise version to 3.27.16 2021-08-04 10:57:03 -04:00
oliviaruizknott
f63173617c feat: Add CertificateDateOverride model to admin
Register the new CertificateDateOverride model with the Django admin.
Customize the `generated_certificate` field to accept the certificate id
(with search); and autosave the admin user making the change to the
`overridden_by` field, and make it read-only.

For MICROBA-1417, toward MICROBA-1239.
2021-08-04 08:10:08 -06:00
Zaman Afzal
3491cc516b maint: ENT4740 bumping enterprise version to 3.27.15 (#28390) 2021-08-04 18:21:14 +05:00
Justin Hynes
7f5cf2fabd refactor: update certificates app Python API functions
[MICROBA-1354]

* Update Python API function named `cert_generated_enabled` to `has_self_generated_certificates_enabled` to more accurately reflect the purpose of the function
2021-08-04 08:43:12 -04:00
Kshitij Sobti
6cbb9cbca3 feat: Supply documentation links for course apps from the backend (#28327)
Instead of hard-coding the "Learn More" and potentially other links for course
apps in the course authoring  MFEs this change loads those URLs from the
django settings as part of each individual course app.
2021-08-04 15:04:13 +05:00
Robert Raposa
8e4e9a1d39 fix: add code owner mapping for edx-name-affirmation (#28386)
* fix: add code owner mapping for edx-name-affirmation

Enables edx_name_affirmation views to have a code owner.
2021-08-03 18:41:46 -04:00
cdeery
35caeb4036 Clean up to pass pep-8 2021-08-03 17:16:02 -04:00
Michael Terry
5e2155b6ab Merge pull request #28388 from edx/mikix/library-import-fix
fix: allow importing courses into Studio with empty libraries
2021-08-03 16:49:15 -04:00
Michael Terry
8d1989cf93 fix: allow importing courses into Studio with empty libraries
If a content library xblock does not specify a library id, we
previously would error out when importing, due to some cleanup
code that wasn't accounting for this case.
2021-08-03 16:16:01 -04:00
Bianca Severino
b354021541 Merge pull request #28385 from edx/bseverino/name-affirmation-0.3.1
chore: upgrade edx-name-affirmation to 0.3.1
2021-08-03 16:01:59 -04:00
David Ormsbee
149b014053 fix: disallow "data:" links in discussion posts
Sanitizes Markdown that goes back and forth between the server and
client side, to strip out data: links, so that they cannot be abused.
There is no present vulnerability to this issue–modern browsers disallow
data links in the first place, and we already filter this out in both
client-side code as well as the HTML generated in the REST API (it's run
through bleach). But we're adding this anyway, to further reduce the
odds that some client-side mistake could cause a vulnerability. This is
part of TNL-8589.
2021-08-03 15:19:07 -04:00
cdeery
fc8b0a4d60 fix the logic of the validation in the unt tests so it was correct in all cases 2021-08-03 15:12:03 -04:00
Bianca Severino
1e66380f0e chore: upgrade edx-name-affirmation to 0.3.1 2021-08-03 14:43:04 -04:00
cdeery
b05af6b344 fix: [AA-893] Don't show View As Learner if partitions
Remove the option to masquerade as a generic learner
if there are enrollment tracks or partition groups
because the behavior is unpredictable and unhelpful.

Fixes: AA-893
2021-08-03 13:15:00 -04:00
Jansen Kantor
68e8a6a981 chore(bump ora to 3.6.15) (#28383) 2021-08-03 12:01:49 -04:00
Alexander J Sheehan
9ebf8a273f Merge pull request #28381 from edx/asheehan-edx/ENT-4783-bumping-enterprise-fix-command
maint: bumping enterprise version to 3.27.14
2021-08-03 11:38:37 -04:00
Christie Rice
cdeda7a313 fix: Update mode in course certificate when marking cert as invalidated, not verified or not passing (#28330)
MICROBA-1410
2021-08-03 11:24:11 -04:00
Kshitij Sobti
af290ce6a9 feat: Adds a new flag for discussions LTI configuration for admin only config
Some providers need special considerations when being set up so should only be
configured by people with global staff privileges. This adds an
admin_only_config flag to such providers (only YellowDig for now).
2021-08-03 20:10:32 +05:00