Commit Graph

162 Commits

Author SHA1 Message Date
Greg Price
0e59038c72 Add pagination to forum user profile page 2014-04-23 16:49:50 -04:00
Greg Price
643069c64c Remove cruft from user profile threads
This removes the vote button from threads on the user profile, which was
the only interaction available on the page other than the link to view
the thread in the main discussion view.
2014-04-23 16:07:36 -04:00
Greg Price
92151e3bd6 Render markup in inline threads on expand/collapse
This was a bug in 3af90ef.
2014-04-17 15:13:00 -04:00
Greg Price
862a16cac0 Show full body when expanding inline forum thread
This was a bug in 3af90ef.

JIRA: FOR-559
2014-04-17 12:36:03 -04:00
Andy Armstrong
1b2d1858fa Fix duplicate save and cancel buttons in Studio
STUD-1531

Also add support for refreshing the modal on custom save
2014-04-15 15:28:22 -04:00
Greg Price
ecf9923e96 Return 404 instead of 500 for missing forum thread
Also show a more specific error message in the front end. This change
only has an effect if using cs_comments_service commit 1d71330 or later.
2014-04-10 13:17:58 -04:00
Greg Price
8c8367b055 Merge pull request #3183 from edx/gprice/inline-response-pagination
Add repsonse pagination to inline discussions
2014-04-09 17:55:15 -04:00
Sarina Canelake
2d08b3a394 Fix i18n'd strings to be easier for translators to understand
Signup modal

Just translate discussion sr text

Markdown editor help

Help modal and reverify dash
2014-04-08 13:09:07 -04:00
Greg Price
3af90ef256 Add repsonse pagination to inline discussions 2014-04-02 14:32:58 -04:00
Greg Price
2a1ddab224 Improve inline discussion UI
1. Add space between threads
2. Change Show/Hide to Expand/Collapse and visually separate it
3. Limit a thread to 700px high and scroll if longer

Co-authored-by: marco <marcotuts@gmail.com>
2014-04-01 11:52:54 -04:00
Calen Pennington
d4db0ee7e4 Remove unused methods from comment_client 2014-03-28 11:37:43 -04:00
Giulio Gratta
1cd5a80d1e replace unicode 'X' with font-awesome 'remove' 2014-03-11 12:48:58 -07:00
Han Su Kim
bdfd81d2f3 Merge remote-tracking branch 'origin/master' into release, conflicts resolved
Conflicts:
	cms/envs/common.py
	common/lib/xmodule/xmodule/seq_module.py
	lms/envs/common.py
	requirements/edx/edx-private.txt
2014-03-06 16:56:16 -05:00
Greg Price
b4caf75cbb Make forum comment buttons activate by keyboard
Neither edit nor delete activated on pressing the space key.
2014-03-04 10:42:07 -05:00
Greg Price
db8ad0d20b Add bok choy tests for forum comment editing 2014-03-03 14:26:25 -05:00
Will Daly
fbd2e3a0bc Merge pull request #2724 from edx/will/studio-xblock-save
Native XBlock Studio Save UI
2014-02-27 10:50:51 -05:00
Will Daly
5f09953125 Hide save/cancel buttons for native XBlocks in Studio
Add Studio client-side runtime notifications for saving/cancelling XBlock edits.
2014-02-26 16:17:02 -05:00
Greg Price
29e77ed25f Improve UX of pinning feature
Students no longer see a tooltip nor any button affordance (i.e. cursor
and color change on hover/focus) on the pinning feature. For moderators,
the tooltip is now correct when a thread is pinned, the button is
accessible for keyboard-only users and screen readers, and an error
dialog now appears if an error occurs in attempting to pin/unpin.

JIRA: FOR-192
2014-02-26 13:59:54 -05:00
Greg Price
0f38892028 Merge pull request #2701 from edx/gprice/edit-forum-comment
Add UI for editing forum third-level content
2014-02-26 11:45:14 -05:00
Greg Price
c3dc40d729 Add UI for editing forum third-level content 2014-02-26 10:00:50 -05:00
Calen Pennington
a2137cec35 Merge pull request #2603 from cpennington/xblock-acid-resources-test
Add tests of local_resource_url
2014-02-25 16:46:10 -05:00
Calen Pennington
ae34c3fe9f Mark xblock initialization status using css class (in part to make testing easier) 2014-02-25 14:01:37 -05:00
Greg Price
3f48e22448 Fix strings to avoid dangling commas 2014-02-24 14:46:41 -05:00
Jim Abramson
e3a71b1625 Merge pull request #2646 from edx/jsa/forum-delete-comments
add ability to delete comments on responses in discussions.
2014-02-22 19:14:59 -05:00
Calen Pennington
dbc99ef8ad Implement children for pure XBlocks in edx-platform
This requires fixing the javascript api implementation, and adding
an implementation of get_block to the ModuleSystem api.

However, the implementation is incomplete, due to mismatches between
the expectations of XModule and XBlock.

Also adds tests using the Acid block to make sure that the javascript
and python apis for children are working correctly.
2014-02-21 15:01:20 -05:00
jsa
7d32a90ae2 add ability to delete comments on responses in discussions. 2014-02-20 13:14:11 -05:00
jsa
427468565f don't show the add response button if responses are not allowed.
JIRA: FOR-452
2014-02-05 12:49:52 -05:00
Calen Pennington
f6731342de Make Studio load XBlock fragment js and css on the client-side
[LMS-1421][LMS-1517]
2014-02-04 15:38:13 -05:00
Calen Pennington
49217ebe8b Allow multiple client-side runtimes on a single page
Make XBlock client-side runtimes proper classes, so that handlerUrl can
be defined in a per-runtime way, and we can have multiple runtimes on a
single page.

[LMS-1630][LMS-1421][LMS-1517]
2014-02-04 08:55:36 -05:00
Greg Price
4e1c595472 Merge pull request #2377 from edx/gprice/forum-thread-pagination
Add pagination of responses to forum threads
2014-02-03 08:55:20 -08:00
Greg Price
062025eeec Add pagination of repsonses to forum threads
Users will first be shown the first 25 responses of a viewed thread and
then have the option of loading 100 more at a time until all responses
have been loaded. This mitigates the performance impact of very large
threads by avoiding the need to render and transfer over the network
all content of a large thread at once. It will also allow students with
slower browsers to interact with large threads even if they cannot load
all of the responses.
2014-01-31 18:17:04 -05:00
Greg Price
285d3579bb Fix unread comment count tooltip rendering
JIRA: FOR-434
2014-01-31 13:30:39 -05:00
jsa
9b54abe308 add "Add A Response" button to thread views in discussion tab / inline
JIRA: FOR-373
2014-01-28 17:13:16 -05:00
Giulio Gratta
65c76cd6a7 Added help text to tooltips and sr flag spans 2014-01-27 13:27:24 -08:00
jsa
168445f7c8 i18n: extract strings from underscore templates
JIRA: FOR-400
2014-01-22 11:07:35 -05:00
Greg Price
e634586882 Merge pull request #2222 from edx/gprice/forum-new-post-buttons
Fix forum buttons
2014-01-22 08:04:35 -08:00
Greg Price
60fb3cfbb2 Make forum New Post buttons behave as buttons
JIRA: FOR-205
2014-01-17 16:38:51 -05:00
Greg Price
2014d34c8a Fix forum button keyboard activation
Previously, buttons were activated on pressing Enter, but the expected
behavior is to activate on pressing Space. Several JavaScript errors
that prevented various buttons from properly activating via the keyboard
are also fixed.
2014-01-17 16:38:51 -05:00
jsa
22d6c6806b expand forums' search text input whenever the field receives focus.
JIRA: FOR-203
2014-01-17 14:13:40 -05:00
Greg Price
f8732a8b3d Internationalize the forums post Markdown editor
This includes removing the "PREVIEW" label for the preview pane from CSS
and adding it to the generated DOM.
2014-01-16 14:10:51 -05:00
Greg Price
a8e3bca8c8 Internationalize forums CoffeeScript code 2014-01-14 13:04:51 -05:00
Greg Price
a1dc49cc9b Remove defunct forum post tagging code 2014-01-14 13:03:56 -05:00
Greg Price
5147a41b07 Merge pull request #2034 from carsongee/cg/notification_prefs_missing_slash
Added missing slash to avoid 302 when calling /notification_prefs/status
2014-01-09 13:01:29 -08:00
Greg Price
b7d7751dc2 Improve accessibility of forum vote buttons
This change involves substantial refactoring of the relevant code to
reduce duplication. It also makes the templates for the vote buttons
more consistent and cleaner.

JIRA: FOR-64
2014-01-06 17:08:53 -05:00
Carson Gee
2796af4abc Added missing slash to avoid 302 when calling /notification_prefs/status 2013-12-23 15:43:00 -05:00
Calen Pennington
c684a66ac3 Add information to xblocks about when they complete initialization that's visible in javascript 2013-12-17 13:18:22 -05:00
Calen Pennington
80fd12b9aa Merge pull request #1692 from cpennington/pure-xblock-handler-urls
Update handler_url support to match the latest in the xblock repo, for both js and python runtimes
2013-12-10 10:54:55 -08:00
Calen Pennington
d937da8d47 Update handler_url support to match the latest in the xblock repo, for both js and python runtimes
[LMS-1613]
2013-12-10 12:04:18 -05:00
Greg Price
cec58f885b Remove forum user profile moderator toggle button
This button has been broken for at least a year, so the code has
suffered from bit rot and should be reimplmemented if the feature is
necessary in the short term (which is unlikely since it has been broken
for so long).
2013-12-09 10:23:21 -05:00
Greg Price
81798dd8be Improve accessibility of inline discussions
The show/hide toggle now properly acts like a button, and focus is now
trapped on the loading element for both the show/hide action and loading
of a new page.
2013-11-26 14:12:34 -05:00