Make forum comment buttons activate by keyboard
Neither edit nor delete activated on pressing the space key.
This commit is contained in:
@@ -63,23 +63,30 @@ describe 'ResponseCommentShowView', ->
|
||||
@comment.unflagAbuse()
|
||||
expect(@comment.get 'abuse_flaggers').toEqual []
|
||||
|
||||
describe 'comment deletion', ->
|
||||
describe '_delete', ->
|
||||
|
||||
it 'triggers the delete event when the delete icon is clicked', ->
|
||||
it 'triggers on the correct events', ->
|
||||
DiscussionUtil.loadRoles []
|
||||
@comment.updateInfo {ability: {'can_delete': true}}
|
||||
@view.render()
|
||||
DiscussionViewSpecHelper.checkButtonEvents(@view, "_delete", ".action-delete")
|
||||
|
||||
it 'triggers the delete event', ->
|
||||
triggerTarget = jasmine.createSpy()
|
||||
@view.bind "comment:_delete", triggerTarget
|
||||
@view.render()
|
||||
@view.$el.find('.action-delete').click()
|
||||
@view._delete()
|
||||
expect(triggerTarget).toHaveBeenCalled()
|
||||
|
||||
describe 'comment edit', ->
|
||||
describe 'edit', ->
|
||||
|
||||
it 'triggers comment:edit when the edit button is clicked', ->
|
||||
it 'triggers on the correct events', ->
|
||||
DiscussionUtil.loadRoles []
|
||||
@comment.updateInfo {ability: {'can_edit': true}}
|
||||
@view.render()
|
||||
DiscussionViewSpecHelper.checkButtonEvents(@view, "edit", ".action-edit")
|
||||
|
||||
it 'triggers comment:edit when the edit button is clicked', ->
|
||||
triggerTarget = jasmine.createSpy()
|
||||
@view.bind "comment:edit", triggerTarget
|
||||
@view.render()
|
||||
@view.$el.find(".action-edit").click()
|
||||
@view.edit()
|
||||
expect(triggerTarget).toHaveBeenCalled()
|
||||
|
||||
@@ -2,8 +2,14 @@ if Backbone?
|
||||
class @ResponseCommentShowView extends DiscussionContentView
|
||||
|
||||
events:
|
||||
"click .action-delete": "_delete"
|
||||
"click .action-edit": "edit"
|
||||
"click .action-delete":
|
||||
(event) -> @_delete(event)
|
||||
"keydown .action-delete":
|
||||
(event) -> DiscussionUtil.activateOnSpace(event, @_delete)
|
||||
"click .action-edit":
|
||||
(event) -> @edit(event)
|
||||
"keydown .action-edit":
|
||||
(event) -> DiscussionUtil.activateOnSpace(event, @edit)
|
||||
|
||||
tagName: "li"
|
||||
|
||||
@@ -52,7 +58,7 @@ if Backbone?
|
||||
else if DiscussionUtil.isTA(@model.get("user_id"))
|
||||
@$el.find("a.profile-link").after('<span class="community-ta-label">' + gettext('Community TA') + '</span>')
|
||||
|
||||
_delete: (event) ->
|
||||
_delete: (event) =>
|
||||
@trigger "comment:_delete", event
|
||||
|
||||
renderFlagged: =>
|
||||
|
||||
Reference in New Issue
Block a user