Commit Graph

54867 Commits

Author SHA1 Message Date
Eric Herrera
c40aa67fd0 Order VideoBlock html metadata alphabeticallly to fix test. 2020-06-24 12:07:55 -04:00
Kyle McCormick
c3d7ab9943 Fix programs cache ADR formatting (#24320) 2020-06-24 11:55:43 -04:00
morenol
8c53fa4a47 async is a keyword in python>=3.7 (#24265)
the new keyword async is causing errors when we run this with python 3.8.
https://docs.python.org/3/whatsnew/3.7.html

I tried in the first place, to change the definition of that value in the place where the context is defined, but it seems that it is taken from https://github.com/jazzband/django-pipeline,

This solves many problems for lms and cms tests that were making the jenkins workers get timeout.

That template have not seen changed since 2012, so I had to do additional changes in the templates in order to pass the xsslint checks:

mako-missing-default
mako-invalid-html-filter

I am not sure about the remove of the safe filter.

But I didn't found information about the 'safe' filter. It is probably that the now default 'h' filter is enough.
2020-06-24 11:55:03 -04:00
Muhammad Ammar
0d0f8a1c6f Merge pull request #24319 from edx/jenkins/upgrade-python-requirements-39b109a
Python Requirements Update
2020-06-24 19:16:58 +05:00
edX requirements bot
6c441231fd Updating Python Requirements 2020-06-24 09:48:43 -04:00
M. Zulqarnain
39b109a9ad Fixed bad escape character (#24316)
As of Python 3.7, a backslash-character pair that is not a valid escape sequence now generates an error, earlier it was a deprecation warning.
2020-06-24 18:23:11 +05:00
Carla Duarte
45d277beb6 Merge pull request #24286 from edx/ciduarte/AA-186
AA-186: Updating Course Home Course Metadata API
2020-06-24 08:47:41 -04:00
Waheed Ahmed
ab72a9d87d Fix embargo message issues.
PROD-1753
2020-06-24 14:45:47 +05:00
Awais Qureshi
b7500cd2a0 Merge pull request #24268 from eduNEXT/lmm/safe_exec
[BD-6] Fix test for python3.8
2020-06-24 13:39:35 +05:00
Awais Qureshi
9445a7b2e0 Merge pull request #24306 from edx/awais786/BOM-1750
BOM-1750
2020-06-24 11:45:58 +05:00
Michael Roytman
6e7e1f2579 Merge pull request #24305 from edx/mroytman/PROD-1761-proctoring-provider-fix
Change validation code to use the value of the proctoring_provider mo…
2020-06-23 23:02:31 -04:00
Nimisha Asthagiri
a219381361 Update 0001-refactor-waffle-flag-default.rst (#24308) 2020-06-23 21:03:06 -04:00
Michael Roytman
e5f298e158 Change validation code to use the value of the proctoring_provider model when making a comparison instead of the entire model. Otherwise, the condition 'current_provider != requested_provider' always resolves to True. 2020-06-23 18:49:28 -04:00
Awais Qureshi
b4035bc71e BOM-1750
DeprecationWarning `callable is None` raised  since 3.5 throwing TypeError.
Fixed the assertion.
2020-06-24 01:43:09 +05:00
edX cache uploader bot
5bd0d317ac Updating Bokchoy testing database cache (#24304) 2020-06-23 20:15:57 +00:00
Robert Raposa
aa3ae13ad8 Merge pull request #24301 from edx/robrap/ARCHBOM-1304-add-waffle-migrations
ARCHBOM-1304: add migration for flags using flag_undefined_default=True
2020-06-23 15:34:14 -04:00
Robert Raposa
9b0024376a update flags using flag_undefined_default=True
In order to enable us to remove flag_undefined_default, this
updates flags according to alternatives documented in:
https://github.com/edx/edx-platform/blob/master/openedx/core/djangoapps/waffle_utils/docs/decisions/0001-refactor-waffle-flag-default.rst

These flags were updated with a migration:
- enable_checklists_quality
- REJECTED_EXAM_OVERRIDES_GRADE
- ENFORCE_FREEZE_GRADE_AFTER_COURSE_END
- WRITABLE_GRADEBOOK

ARCHBOM-1304
2020-06-23 14:37:50 -04:00
Waheed Ahmed
34263bbe1e Prevent multiple submissions on contact us form.
PROD-1565
2020-06-23 23:33:33 +05:00
Robert Raposa
7bf2ea72c6 ARCHBOM-1304: remove ENABLE_VIDEO_URL_REWRITE (#24300)
* remove ENABLE_VIDEO_URL_REWRITE

The temporary waffle flag ENABLE_VIDEO_URL_REWRITE is no
longer needed, becaues the rollout is complete.
See https://openedx.atlassian.net/browse/PROD-62

ARCHBOM-1304

* fix quality
2020-06-23 13:56:26 -04:00
Jansen Kantor
79a76887b2 rebind events on re-render (#24288) 2020-06-23 13:56:12 -04:00
Robert Raposa
f060872878 update waffle flag and docs (#24299)
- update ADR to provide more alternatives for updating
the default value of a flag.
- add a `flag_` prefix to the flag metrics
- add module-level note about flag metrics
- add NewRelic query example and warning
- fix typo in toggle annotation

ARCHBOM-1302
2020-06-23 13:55:06 -04:00
Nick
e8fc653c86 Merge pull request #24285 from edx/ndalfonso/AA-142-calendar-sync-ses
AA-142 calendar sync ses
2020-06-23 13:52:42 -04:00
Robert Raposa
6a5d95a517 fix quality 2020-06-23 13:26:31 -04:00
Nicholas D'Alfonso
5b1d181491 AA-142 calendar sync ses
- set up util function to use Amazon SES for sending calendar
  sync emails.
- remove old sailthru code which we originally implemented for
  this functionality
- include ADR on our decision to use SES instead of Sailthru.
2020-06-23 12:14:03 -04:00
Matthew Piatetsky
b3c2d37dcc Merge pull request #24214 from edx/REV-774
[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam
2020-06-23 11:48:31 -04:00
Robert Raposa
624012e11c remove ENABLE_VIDEO_URL_REWRITE
The temporary waffle flag ENABLE_VIDEO_URL_REWRITE is no
longer needed, becaues the rollout is complete.
See https://openedx.atlassian.net/browse/PROD-62

ARCHBOM-1304
2020-06-23 11:19:32 -04:00
Luis Moreno
1d557616b1 Fix test for python3.8 2020-06-23 10:16:37 -04:00
Feanil Patel
1643d07705 Merge pull request #24293 from edx/jenkins/upgrade-python-requirements-083f1bb
Python Requirements Update
2020-06-23 09:54:12 -04:00
Awais Qureshi
e34b052002 Merge pull request #23939 from eduNEXT/lmz/fixing_cgi_escape_warning
Fixing cgi.escape DeprecationWarning
2020-06-23 18:22:06 +05:00
edX requirements bot
6031802f9c Updating Python Requirements 2020-06-23 06:49:02 -04:00
daphneli-chen
083f1bb8b2 Merge pull request #24287 from edx/dlichen/AA122
AA-122 created framework for dates widget on course outline
2020-06-22 16:58:05 -04:00
Daphne Li-Chen
84b08f366d AA-122 created framework for dates widget on course outline 2020-06-22 16:24:39 -04:00
Matthew Piatetsky
78317ca115 Show content type gating upsell when a limited access learner tries to access a timed exam
Otherwise, these learners could start the timer and then be unable to take the exam once they have access to the content
REV-774
2020-06-22 16:18:58 -04:00
Carla Duarte
f1b15b677d AA-186: Updating Course Home Course Metadata API
Added `is_enrolled` field to check if user's enrollment is active.
2020-06-22 15:19:24 -04:00
leomartinez2019
943bd6f15b Fixing cgi.escape DeprecationWarning
- Change cgi.escape to html.escape

- Add quote=False to html.escape

- Use function HTML() to address python-wrap-html warning
2020-06-22 14:41:27 -04:00
Jansen Kantor
5c0fd63f13 emit an event when removing users from teams via csv (#24271) 2020-06-22 14:25:05 -04:00
Michael Roytman
af36b2941d Merge pull request #24273 from edx/mroytman/PROD-1761-advanced-settings-proctoring-fix
Add condition to check whether the user has requested a change to the…
2020-06-22 14:02:11 -04:00
Robert Raposa
a1ed944c72 add temp waffle flag default metric (#24284)
The argument flag_undefined_default is soon to be retired
once ARCHBOM-132 is closed. The following will be used to
help ensure the rollout is complete.

- Add a temporary metric if flag_undefined_default is used.
- Add deprecation warning for flag_undefined_default.
- Add minor fix for waffle flag metric when no request found.

ARCHBOM-132
2020-06-22 13:53:17 -04:00
Feanil Patel
950be9247f Merge pull request #24281 from edx/jenkins/upgrade-python-requirements-4f6aad4
Python Requirements Update
2020-06-22 11:46:15 -04:00
Michael Roytman
57d5736337 Add condition to check whether the user has requested a change to the proctoring_provider Advanced Setting. In the case that the setting is not available (i.e. the ENABLE_PROCTORING_PROVIDER_OVERRIDES waffle flag is not enabled for the course), the requested proctoring_provider will be None. We should consider, in this case, that the user has not requested a change to the proctoring_provider setting and therefore should not prevent the user from saving course settings if the other conditions for preventing changes to the proctoring_provider setting are met. 2020-06-22 11:22:23 -04:00
Awais Qureshi
576ad48dbd Merge pull request #24274 from eduNEXT/eric/py38_dict_insertion_order
[BD-6] Update dicts order to fix tests
2020-06-22 20:10:49 +05:00
Nathan Sprenkle
9fb056a6d2 Update ORA2 and Submissions (#24253)
edx-ora2==2.4.8
edx-submissions==3.1.11
2020-06-22 11:05:07 -04:00
Robert Raposa
5ea9d313ad add ADR for waffle flag default (#24272)
We are changing how we handle updates to a waffle flag
default, and the ADR explains why and how.

ARCHBOM-1303
2020-06-22 10:12:10 -04:00
Robert Raposa
343a5a8a74 update waffle flag custom metrics (#24270)
The previous version of this code used the Django Setting
ENABLE_WAFFLE_FLAG_METRIC to determine whether to add a single
metric with a dict of details about all flags. Due to
NewRelic's 256 character limit on the metric value, this was
getting truncated.

This new version instead uses the Django Setting
WAFFLE_FLAG_CUSTOM_METRICS, a list of waffle flag names to
instrument.

The name of each custom metric will match the name of the flag.
The value of the custom metric could be False, True, or Both.

The value Both would mean that the flag had both a True and False
value at different times during the transaction. This is most
likely due to having a check_before_waffle_callback, as is the
case with CourseWaffleFlag.

ARCHBOM-132
2020-06-22 10:11:40 -04:00
taliaedX
08f358c497 Merge pull request #24263 from edx/trhodes/update_edxplat_requirements
update requirements post edx-enterprise change
2020-06-22 09:35:39 -04:00
atesker
34171e6d6e Disallow the condition of trying to add a master's learner to a non-protected team. 2020-06-22 09:20:32 -04:00
edX cache uploader bot
98ebb2df44 Updating Bokchoy testing database cache (#24269) 2020-06-22 09:02:48 -04:00
Michael Terry
7fbe2ff6da Merge pull request #24234 from edx/mikix/instructor-dashboard-pls
AA-184: Fix extension dashboard for self-paced courses
2020-06-22 08:56:27 -04:00
Ahtisham Shahid
5707bbdc90 updated confirm_email field type (#24205)
* updated confirm_email field type and removed confirm email form v1
2020-06-22 17:10:41 +05:00
edX requirements bot
2e6d561e6b Updating Python Requirements 2020-06-22 06:45:53 -04:00