Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
57,539 Commits 1 Branch 0 Tags
bb3ed618222a5d0fb0bd95bec681a1af5376bc21
Commit Graph

12058 Commits

Author SHA1 Message Date
Carla Duarte
7f7edd93c7 Merge pull request #26440 from edx/ciduarte/AA-590 
AA-590: pass translated tab titles to MFE
 2021-02-09 08:57:10 -05:00
usamasadiq
1e2aa1dec5 Apply manesty to convention warnings 2021-02-09 17:09:19 +05:00
Carla Duarte
00a025f073 AA-590: pass translated tab titles to MFE 2021-02-08 17:00:33 -05:00
Tim McCormack
80a4437f33 fix: Always save generated anonymous user ID in DB; ignore save=False (#26399) 
This deprecates `save=False` for several functions and removes all known
usages of the parameter but does not actually remove the parameter.
Instead, it will emit a deprecation warning if the parameter is used.
We can remove the parameter as soon as we feel sure nothing is using it.

Now that we have refactored `anonymous_id_for_user` to always prefer
retrieving an existing ID from the database -- and observed that only a
small fraction of calls pass save=False -- we can stop respecting
save=False. This opens the door for future improvements, such as generating
random IDs or switching to the external user ID system.

Metrics: I observe that 1 in 16 requests for new, non-request-cached
anon user IDs are made with save=False. But 71% of all calls are served
from the request cache, and 99.7% of the misses are served from the DB.
save=False only appear to come from intermittent spikes as reports are
generated and are low in absolute number.

Also document usage/risk/rotation of secret in anonymous user ID
generation as indicated by `docs/decisions/0008-secret-key-usage.rst`
ADR on `SECRET_KEY` usage.

ref: ARCHBOM-1683
 2021-02-08 19:16:05 +00:00
Bianca Severino
54505b82c4 Merge pull request #26436 from edx/bseverino/proctoring-check-fix 
[MST-645] Account for no enrollment in courseware rules
 2021-02-08 13:39:40 -05:00
Carla Duarte
a3f0050c4d Merge pull request #26396 from edx/ciduarte/depr-keys 
AA-650: block deprecated keys from course home MFE
 2021-02-08 13:27:58 -05:00
Bianca Severino
4fb36709a5 Account for no enrollment in courseware rules 2021-02-08 13:12:52 -05:00
Carla Duarte
8d2d78dc61 AA-650: block deprecated keys from course home MFE 2021-02-08 13:00:36 -05:00
Feanil Patel
03d2d983ea Merge pull request #26392 from edx/feanil/rate_limit_anon_csv 
Feanil/rate limit anon csv
 2021-02-08 12:05:21 -05:00
Christie Rice
367d2a07c9 Fix lint-amnesty warnings (#26411) 2021-02-08 10:49:32 -05:00
Gábor Boros
dd55860da1 [TSD] [SE-3988] add annotations to instructor plugin settings (#26202) 
docs: add annotations to instructor plugin settings
 2021-02-08 10:45:26 -05:00
Christie Rice
6e5a9f5f6f MICROBA-918 Move methods to separate certificate generation from celery task to schedule certificate generation. Also standardizes imports. (#26410) 2021-02-08 10:01:04 -05:00
edx-pipeline-bot
930980d732 Merge pull request #26427 from edx/private_to_public_01b389b 
Mergeback PR from private to public.
 2021-02-08 09:36:23 -05:00
Usama Sadiq
90666a6231 Merge pull request #26311 from edx/usamasadiq/bom-2305-pylint-amnesty 
Applied pylint-amnesty
 2021-02-08 18:23:34 +05:00
Ali Akbar
06cfaa2d88 Merge pull request #220 from edx/IM/security-fixes-9 
Incident Management Security Fixes 9
 2021-02-08 17:46:06 +05:00
usamasadiq
7bbde8f0f5 Applied pylint-amnesty 2021-02-08 13:00:22 +05:00
Matthew Piatetsky
b91f720b7e Merge pull request #26293 from edx/AA-613 
[AA-613] Return content type gate for staff users when masquerading as the Learner in Audit or Learner in Limited Access Roles
 2021-02-05 09:18:34 -05:00
Matthew Piatetsky
ae7d0a1ed8 Return content type gate for staff users when masquerading as the Learner in Audit or Learner in Limited Access Roles 
This is necessary to display the content type gate in the UI
AA-613
 2021-02-04 17:34:16 -05:00
Christie Rice
1fe0eee969 MICROBA-918 Fix warnings (#26397) 2021-02-04 15:45:00 -05:00
Feanil Patel
0221d6a081 feat: Add ratelimitng to the get_anon_ids api endpoint. 
This endpoint can be computationally intensive and so we want to limit
the number of concurrent executions so that it doesn't overload the
server.
 2021-02-04 14:03:15 -05:00
Christie Rice
8845685fd8 MICROBA-918 Check for the allowlist on invalidation and failing grades (#26356) 2021-02-04 13:42:33 -05:00
Olivia Ruiz-Knott
016b1ce3f7 Merge pull request #26227 from edx/ork/MICROBA-905_add-history-to-certificate-invalidation 
MICROBA-905 Add django-simple-history  to CertificateInvalidation model
 2021-02-04 10:11:05 -05:00
Sid Verma
d81215c1e9 [SE-3685] Hide footer links if unconfigured in Certificates (#25872) 
* Don't show marketing links if not configured

* Remove failing test
 2021-02-04 10:09:49 -05:00
Jawayria
11174a8d9c Merge pull request #26285 from edx/py-amnesty-courseware 
Applied pylint-amnesty to courseware
 2021-02-04 14:44:36 +05:00
Jawayria
1bfbedcc8f Merge pull request #26280 from edx/py-amnesty-course-api 
Applied pylint-amnesty to course_api
 2021-02-04 14:44:24 +05:00
Jawayria
959aed9841 Resolved pep8 issues 2021-02-04 14:07:47 +05:00
Jawayria
e9b167e1fd Applied pylint-amnesty to course_api 2021-02-04 13:22:45 +05:00
Ali-D-Akbar
c7a467b04d PROD-1999 2021-02-04 10:20:25 +05:00
oliviaruizknott
d33d9a66c8 docs: clarify comment 2021-02-03 16:52:34 -05:00
Felipe Montoya
b3cbc404d9 Merge pull request #26046 from open-craft/danielf/BB-3502 
[BTR-53] [BB-3502] Misuse of urljoin in Gradebook URL from Instructor Panel
 2021-02-03 12:59:21 -05:00
Jawayria
03e6a874d0 Applied pylint-amnesty to courseware 2021-02-03 21:56:24 +05:00
Jawayria
eb85fe5276 Merge pull request #26286 from edx/py-amnesty-coursewarehistory 
Applied pylint-amnesty to coursewarehistoryextended
 2021-02-03 18:45:42 +05:00
M. Zulqarnain
6f2d54d53b BOM-2268 : Add Pylint amnesty for Bulk Email (#26208) 
* Add Amnest for Bulk Email
 2021-02-03 18:15:37 +05:00
M. Zulqarnain
c9c14ee6fc BOM-2279 : Pylint amnesty for edxnotes,email_marketing, and experiments (#26274) 
* lint amnesty for edxnotes,email_marketing, and experiments
 2021-02-03 18:15:26 +05:00
M. Zulqarnain
65cf0db337 BOM-2278 : Pylint amnesty in discussion, dashboard (#26275) 
* pylint amnesty in discussion, dashboard
 2021-02-03 18:15:14 +05:00
M. Zulqarnain
feaf5011c8 BOM-2287 : Pylint amnesty in teams,tests,survey and verify_student (#26305) 
* lint amnesty in teams,tests,survey and verify_student
 2021-02-03 18:15:03 +05:00
M. Zulqarnain
0213fde968 BOM-2281 : Pylint amnesty for grades,gating and instructor app (#26343) 
* pyint amnesty for grades,gating and instructor app
 2021-02-03 18:14:35 +05:00
Jawayria
462158b3da Resolved quality issue 2021-02-03 16:57:55 +05:00
Jawayria
2ce363abb0 Applied pylint-amnesty to coursewarehistoryextended 2021-02-03 16:54:49 +05:00
Jawayria
1255cc0ac1 Merge pull request #26281 from edx/py-amnesty-certificates 
Applied pylint-amnesty to certificates
 2021-02-03 15:36:03 +05:00
jawad khan
957f3ab8a5 LEARNER-8191 - Added first_component_block_id in dates api (#26319) 
* LEARNER-8191
Added first_componnet_block_id in dates api
 2021-02-03 13:53:21 +05:00
Jawayria
f5f037b62f Resolved errors 2021-02-02 20:30:46 +05:00
Jawayria
71e0ee6eaf Resolved errors 2021-02-02 19:52:11 +05:00
jawad khan
8529e433b8 Added completion from root to child blocks api and increased version 
* Added completion from root to child blocks api and increased version
Learner-8158
 2021-02-02 19:51:14 +05:00
Jawayria
1d1dc07310 Resolved quality failures 2021-02-02 19:24:08 +05:00
Jawayria
bb53cd9af0 Applied pylint-amnesty to certificates 2021-02-02 19:24:08 +05:00
Jawayria
92a13c55c3 Applied pylint-amnesty to certificates 2021-02-02 19:23:48 +05:00
Christie Rice
ad3ab3712e MICROBA-918 Remove unused variables, standardize imports, and use factories in tests (#26291) 2021-02-02 09:00:18 -05:00
Usama Sadiq
661dc522f7 Merge pull request #26283 from edx/BOM-2282 
BOM-2282
 2021-02-02 16:41:02 +05:00
Usama Sadiq
56ec289fd8 Merge pull request #26295 from edx/BOM-2283 
BOM-2283
 2021-02-02 16:40:42 +05:00