Commit Graph

62357 Commits

Author SHA1 Message Date
Tim McCormack
b8a34f0c57 build: Set Django version for tests more safely; drop support for non-GHA (#31387)
We have a need to lock the version of Django for production and tests, but
also to test on newer versions of Django so that we can get the repo ready
for long-term-support releases.

We've been doing that by extracting the `django==x.y.z` from the
pip-compiled files and moving it to a django.txt that is then co-installed
but can be overridden during tests. The problem is that this can result
in broken packages.

The approach here is to have `make test-requirements` continue to
ensure a consistent set of packages, and then install a different
Django on top of that in the CI script -- and call `pip check` to make
sure that combination isn't broken.

Adding Django 4.0 to the unit-tests.yml matrix will now correctly
result in this error and a failing job:
`django-splash 1.2.1 has requirement Django<4.0, but you have django 4.0.8.`

The other half of this is to change other CI runners to remove their
ability to control the Django version, since it's complicated to make
this work, and we probably only need it in unit-tests.yml. Convert them
to just use `make test-requirements`.

Also:

- Simplify handling of `pip --src` by setting `PIP_SRC` (rather than our
  own `PIP_SRC_DIR`, which pip ignores because `--src-dir` isn't an option
  that it knows). This is needed to allow `make test-requirements` to do
  the pip calls. An alternative would be to set a pip-options env var for
  the make target to use, but `PIP_SRC` already exists.
- Remove outdated modifications to common_constraints
- Add comment explaining why pylint tests need dev-requirements
2022-12-12 21:45:15 +00:00
connorhaugh
cec560b3ab feat: one problem type for new problem editor (#31423)
* feat: one problem type for new problem editor

* fix: add comment, fix lint

* fix: remove print statement

* fix: lint fix
2022-12-12 15:09:43 -05:00
Andrew Shultz
ceab37bd20 Merge pull request #31438 from openedx/ashultz0/devstack-worker-clear-cache
fix: update devstack with worker for cache and proper redis
2022-12-12 13:39:23 -05:00
Andy Shultz
569403f4ae fix: update devstack with worker for cache and proper redis
https://github.com/openedx/edx-platform/pull/31261 fixed celery
cache behavior when not running a worker and made sure production
would keep the old cache behavior, but missed these secret alternate
settings files, bring them up to date.

Also fixes the cms file to have the actual broker URL.
2022-12-12 11:17:54 -05:00
Zachary Hancock
35b3eacc96 feat: update lti-consumer lib (#31437)
Adds support for a platform setting to disable sharing of pii over the LTI names and roles provisioning service.
2022-12-12 09:54:33 -05:00
Jenkins
c1ad89b37e chore(i18n): update translations 2022-12-11 16:00:41 -05:00
Kira Miller
7a321e4fb3 Merge pull request #31428 from openedx/kiram15/bug-fix
chore: version bump
2022-12-09 14:41:03 -05:00
Kira
b717a76d64 chore: version bump 2022-12-09 12:04:03 -05:00
Pooja Kulkarni
fe6cbc5f6f Merge pull request #31408 from open-craft/agrendalath/fix_site_language
fix: use language specified in SiteConfiguration
2022-12-09 11:20:52 -05:00
Mehak Nasir
9efd04b178 fix: full post content is returned for preview (#31426) 2022-12-09 21:10:30 +05:00
Sameen Fatima
7819221ce5 chore: upgrade edx-enterpise to 3.58.17 (#31419) 2022-12-09 10:35:09 +05:00
Ali Raza Abbasi
3e35e3af8d feat: force enrollment after enrollment end date via API (#31309)
It includes support for course enrollment in case of enrollment_end date has passed or the upgrade_deadline has passed. The force_enrollment argument is used to support this functionality, and can_upgrade and include_expired will be True if force_enrollment is True. Only a user who has GlobalSupport access can perform this operation.
2022-12-08 15:58:54 -05:00
Nathan Sprenkle
4c827b5ed5 feat: get credit statuses for Learner Home (#31414)
* refactor: make _credit_status function public

This allows for reuse in the new learner home

* feat: add credit to learner home serializers

* feat: get credit statuses for learner home
2022-12-08 15:22:35 -05:00
Tim McCormack
89412cdfb2 feat: Add optional security policy link in the site footer (#31413)
For edx.org, this will be set to <https://www.edx.org/policy/security>.
The only theme that I'm aware of as supporting this is `edx.org-next` but
other deployments might use this `get_footer` call as well.
2022-12-08 18:43:43 +00:00
connorhaugh
9781aaa618 feat: hide library content block (#31420) 2022-12-08 10:58:41 -05:00
connorhaugh
7103280921 fix: hide library source content block. 2022-12-08 09:15:02 -05:00
Agrendalath
4141fbfda9 test: fix TestCourseStatusGET
This test stopped throwing the `TransactionManagementError` once we added the
`site_configuration.get_value()` call to the language preferences middleware.
2022-12-08 13:49:20 +01:00
Agrendalath
7d3e62e930 fix: use language specified in SiteConfiguration
This feature was implemented in b01544d690 to replace the session's language
in the request. 44ddbdf925 moved the process from the request to the response,
which made this feature unusable (because the request was already processed).
44ddbdf925 also made this feature set the language cookie. However, it is
overwritten by user preferences.
To fix this, we could overwrite the cookie of the response after it's set from
user preferences. However, it is not an ideal solution because when users
switch between Sites with different languages, the first response will use the
language of the previous page. Therefore, this ignores user preferences and
alters the cookie of a request instead.
2022-12-08 13:46:37 +01:00
Justin Hynes
b03efc93df Merge pull request #31044 from openedx/ziafazal/keyword-substitution-edx-ace
fix: added keyword substitution support in edx_ace based bulk course emails
2022-12-07 13:51:22 -05:00
Piotr Surowiec
5b5a0e4c06 Merge pull request #30072 from open-craft/agrendalath/bd-13-simplify_xmodule_serialization
reafactor: simplify XModule serialization/deserialization layer [BD-13]
2022-12-07 18:01:57 +01:00
Andrew Shultz
b87c6405ff Merge pull request #31410 from openedx/ashultz0/less-chatty-goals
fix: intial chatty goals is a bit too chatty
2022-12-07 10:33:45 -05:00
Andy Shultz
0de55deff5 fix: intial chatty goals is a bit too chatty
it takes 20-30s to run through 1000 goals so this logs too often to
read in splunk. Every 10000 will be every few minutes.
2022-12-07 09:40:39 -05:00
Muhammad Umar Khan
9c279444df build: add import linter check (#31062)
* build: add import linter check
2022-12-07 12:07:09 +05:00
Kira Miller
2df1b60469 Merge pull request #31406 from openedx/kiram15/version
chore: version bump
2022-12-06 12:04:45 -05:00
Andrew Shultz
f48accae3f Merge pull request #31397 from openedx/ashultz0/proctoring4133
fix: update proctoring library to 4.13.3
2022-12-06 11:52:38 -05:00
Andy Shultz
197bfa2b83 fix: update proctoring library to 4.13.3
4.13.3 merely brings the proctoring library celery version up to date
with the platform celery version, which is already the case when
proctoring is deployed since as a plugin it does not control celery
2022-12-06 11:28:31 -05:00
Andrew Shultz
10aabcc709 Merge pull request #31407 from openedx/ashultz0/chatty-goals
fix: course goals email command logs more progress info
2022-12-06 11:27:51 -05:00
Kira Miller
eb7bf06658 Merge branch 'master' into kiram15/version 2022-12-06 11:10:20 -05:00
Andy Shultz
08ead3ba01 fix: course goals email command logs more progress info 2022-12-06 10:56:25 -05:00
Maria Grimaldi
20b93b8b01 fix: upgrade problem templates according newer python versions (#31365) 2022-12-06 11:30:06 -04:00
Kira
db7f18a13b chore: version bump 2022-12-06 09:49:49 -05:00
alangsto
b1c9482371 fix: update docker build command now that image targets have changed (#31404) 2022-12-06 09:38:44 -05:00
Saad Ali
d0fad59306 chore: Overhaul Dockerfile for sandboxes (#31232)
* chore: Overhaul Dockerfile for sandboxes using Docker best practices
* Reduce image size by installing and removing prerequisite packages
in the same layer.
* Rearrange stages to use docker-production settings for non-dev
  targets. docker-production settings already inherit production
  settings and can be used to override configuration specific to
  containers e.g. logging.

* chore: write improved Dockerfile2 just for testing

* chore: update development stage to not run as app user

* fix: wrap settings configuration in if statement

* chore: update Dockerfile.
* Moved code COPY command down in the base stage.
* Added comments.

Co-authored-by: Alie Langston <alangsto@wellesley.edu>
2022-12-06 08:42:13 -05:00
Attiya Ishaque
bc94071c90 fix: add msgs errors for validation (#31402) 2022-12-06 17:09:12 +05:00
Zainab Amir
0e81487012 feat: add logs for password reset exceptions (#31400) 2022-12-06 12:23:22 +05:00
Andrew Shultz
476a5df7e0 Merge pull request #31396 from openedx/ashultz0/print-all-exceptions
fix: catch even base exceptions when exiting
2022-12-05 12:42:57 -05:00
Andy Shultz
85ca6ad5ec fix: catch even base exceptions when exiting
prior exception catch is not triggering in cases where the job blows up,
there is one more level of exception available to catch and print
2022-12-05 10:41:17 -05:00
Agrendalath
c214e697ff refactor: simplify url_name lookup
This removes a `slug` check, as we had already removed its translation in
702866b225.
2022-12-05 13:57:41 +01:00
Agrendalath
3380f88ab3 refactor: delete class XmlDescriptor
It also adds `@XBlock.needs("i18n")` to `XModuleMixin` because this service is
required there.
2022-12-05 13:57:41 +01:00
Agrendalath
8127d19115 refactor: replace XmlMixin with XmlParserMixin
Most of the methods in `XmlMixin` act as wrappers for the official API for
serialization and deserialization (parse_xml() and add_xml_to_node()).
`XmlParserMixin` contains the code which does the actual serialization and
deserialization.
2022-12-05 13:57:41 +01:00
Agrendalath
499f09e2fb refactor: convert from_xml to parse_xml for TranslateCustomTagBlock 2022-12-05 13:57:41 +01:00
Agrendalath
20f6650f53 refactor: convert from_xml to parse_xml for VideoBlock 2022-12-05 13:57:41 +01:00
Agrendalath
1bfd3842c7 refactor: convert from_xml to parse_xml in CourseBlock 2022-12-05 13:57:41 +01:00
Agrendalath
da2e89db83 refactor: move resources_dir from XmlMixin to XmlParserMixin 2022-12-05 13:57:41 +01:00
Hammad Ahmad Waqas
18df1f020e Merge pull request #31389 from openedx/hammad/ENT-6470
fix: updated management command to consider in-progress courses before suggestion.
2022-12-05 17:17:54 +05:00
SaadYousaf
d71b21156b feat: add forum response event for marking responses as answered or endorsed 2022-12-05 16:35:52 +05:00
Muhammad Adeel Tajamul
7a0010ad0e feat: added topics v3 api (#31330)
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
2022-12-05 15:07:21 +05:00
edx-pipeline-bot
883b816430 Merge pull request #31393 from openedx/private_to_public_c1e4cb3
Mergeback PR from private to public.
2022-12-05 02:58:36 -05:00
Ali Akbar
c1e4cb3a87 Merge pull request #253 from edx/moeez96/LEARNER-9001
fix: Fix retiring user auth models on disable event
2022-12-05 11:53:58 +05:00
Jenkins
6ed0a6bc4d chore(i18n): update translations 2022-12-04 15:58:36 -05:00