David Baumgold
eac14615cd
Load advanced_entry template on page, rather than via AJAX
2013-07-29 14:28:40 -04:00
Peter Fogg
5c0fd18910
Validate date/time settings when typed in directly.
...
The changeTime event isn't fired when the user types in the field, but
only when clicking on the time in the dropdown. I'd consider this a
timepicker bug, but for now we can just listen to the user typing in
the field and update the value (and thus validate) like we do with
other field types.
2013-07-15 11:00:43 -04:00
Peter Fogg
6e94960488
Fix many validation bugs and failing tests.
2013-07-11 16:09:59 -04:00
Peter Fogg
c2f0b7d4e9
Fix validation in many cases, and ensure that the notification bar pops up correctly.
2013-07-11 15:53:51 -04:00
Peter Fogg
ec13349ae3
Remove outdated deleteKeys from advanced settings.
2013-07-11 09:11:59 -04:00
Peter Fogg
3d4f9268da
Make sure that changing grading cutoffs triggers a save confirmation, and reliable reverting of changes.
2013-07-11 09:11:59 -04:00
Peter Fogg
9094f1890b
Change course settings to require explicit save.
...
Rather than asynchronously saving when a setting is updated, we now
prompt the user to confirm their changes and only persist the data if
they hit the save button. Lettuce tests are updated to expect this
behavior and some new ones are added.
2013-07-11 09:11:07 -04:00
Peter Fogg
164a469e9d
Factor showNotificationBar out into ValidatingView.
...
When all settings require an explicit save, this functionality will be
shared between each view (with slight changes, e.g. click handlers.)
2013-07-11 09:11:07 -04:00
Peter Fogg
fb573a1db6
Hide "success" alert as soon as we start editing another field.
2013-06-24 13:59:14 -04:00
Peter Fogg
3e376bd780
Prevent "saved" and "error" views from showing at the same time.
...
Previously the "saved" view was never hidden, even after more data was
edited. So if one field was saved successfully and then another was
not, we would find ourselves in the unfortunate situation of seeing
both views at once, leading to much confusion.
2013-06-24 11:06:53 -04:00
Peter Fogg
72e08456a8
Refactor Advanced Settings page to use Backbone notifications.
2013-06-24 09:48:37 -04:00
Frances Botsford
4e79d064a0
removed symbolset, replaced with fontawesome for alerts, notifications, and all references in js files
2013-05-22 15:55:55 -04:00
David Baumgold
c6c5e50d86
Hook up notification framework to default AJAX error callback
...
And delete `CMS.ServerError`
2013-05-22 15:55:49 -04:00
David Baumgold
e9a8f408bf
Add {reset: true} to all collection.fetch() calls
...
This is to fix a bug with the Backbone 1.0 upgrade; some views were listening to
reset events that were not longer getting fired
2013-05-14 16:43:41 -04:00
cahrens
f36494e5dd
Need to be able to access smoothScrollTop. This is a temporary change-- I'll come up with a proposal to namespace our helper functions in a nicer way.
2013-04-09 09:41:52 -04:00
Brian Talbot
3f22826e26
studio - alerts: adding some ARIA-centric accessibility information to example prompts/notifications and advanced settings save notification
2013-04-08 16:28:31 -04:00
Brian Talbot
bcf4775610
studio - alerts: removed banners as a design pattern (not using them) and corrected advanced setting links and smoothscrolling
2013-04-08 13:47:01 -04:00
cahrens
cea0f9252c
Make sure we don't mark the message bar as hiding if it is not shown.
2013-04-08 11:02:06 -04:00
cahrens
7f1c89b492
Merge branch 'master' into feature/btalbot/studio-alerts
2013-04-08 10:28:52 -04:00
Brian Talbot
1a68d516fb
resolving local merge with master
2013-04-05 15:27:08 -04:00
Brian Talbot
512e4fe3bd
resolving local merge with master and sprucing style and templates for merge with master
2013-04-05 15:13:21 -04:00
Brian Talbot
52a2fc7114
changing timeFormat for settings views
2013-04-04 17:45:40 -04:00
Mark L. Chang
7b5ec1bc41
instrumented advanced settings
2013-04-04 01:51:14 -04:00
Brian Talbot
d87c4e3866
resolving local merge with master
2013-04-03 15:01:55 -04:00
cahrens
fa63bcce94
Allow clearing of dates (except for course start date).
...
https://edx.lighthouseapp.com/projects/102637/tickets/231
2013-03-25 17:25:49 -04:00
Brian Talbot
cdcdfd49e0
studio - alerts: resolving local master merge conflcits
2013-03-18 10:58:16 -04:00
Brian Talbot
36746fb729
Merge branch 'master' into feature/btalbot/studio-alerts
2013-03-12 16:05:54 -04:00
cahrens
7e8fcb85ff
Updated Selenium test, deleted dead code related to Advanced Settings.
2013-03-11 16:56:24 -04:00
cahrens
f5dd5d35e9
Need to trigger invalid instead of error, after changes for new version of Backbone.
2013-03-08 14:51:29 -05:00
cahrens
98e410816e
New version of Backbone has separate invalid event.
2013-03-07 13:52:55 -05:00
cahrens
9ec33928ce
New version of Backbone has separate invalid event.
2013-03-07 13:37:10 -05:00
Brian Talbot
62514d85a3
studio - alerts: loosely wired advanced settings with new notification and alert messages
2013-03-06 15:36:38 -05:00
Brian Talbot
ec90d349e2
studio - alerts: revisited advanced editor notification UI to marry new styles/behavior - WIP
2013-03-04 12:47:07 -05:00
cahrens
d7c28bfa11
Don't usurp ValidatingView's error handling.
...
#219
2013-03-01 15:24:56 -05:00
Don Mitchell
c11d627c88
Chrome/Safari don't use keypress for backspace and delete.
2013-02-22 11:00:27 -05:00
Don Mitchell
e5efcf65d3
remove console.log
2013-02-21 13:34:11 -05:00
Don Mitchell
851a99cb13
remove commented out code
2013-02-21 13:32:29 -05:00
Don Mitchell
116c74c075
Highlighting of field labels and smarter decision as to when to show the
...
save cancel bar.
2013-02-21 13:27:36 -05:00
cahrens
cc63f9c2db
Unique IDs, other cleanup.
2013-02-20 17:11:34 -05:00
Brian Talbot
ad770a5ec8
studio - manual policy editor: converting to new page layout - WIP
2013-02-20 14:24:13 -05:00
cahrens
305f0b2a54
Add number of spaces for formatting of JSON.
2013-02-20 10:56:49 -05:00
cahrens
167d07037d
Merged, delete Ace.
2013-02-19 14:56:37 -05:00
cahrens
f91060d197
Merge branch 'master' into feature/cas/manual-policy
...
Conflicts:
cms/djangoapps/contentstore/features/common.py
cms/djangoapps/contentstore/features/section.py
cms/djangoapps/contentstore/tests/test_course_settings.py
cms/djangoapps/contentstore/views.py
cms/static/js/models/settings/course_grading_policy.js
cms/static/js/views/settings/main_settings_view.js
cms/static/sass/_settings.scss
cms/templates/settings.html
cms/urls.py
2013-02-19 13:27:35 -05:00
Brian Talbot
6c95460761
studio - resolving merge from master
2013-02-15 09:15:06 -05:00
cahrens
4ae691e88a
Convert JSON that doesn't parse to String (unless object, array, or single quote).
2013-02-13 17:41:52 -05:00
Don Mitchell
d569c559ca
Merge branch 'feature/btalbot/studio-softlanding' of github.com:MITx/mitx into feature/btalbot/studio-softlanding
...
Conflicts:
cms/djangoapps/contentstore/views.py
cms/static/js/views/settings/main_settings_view.js
cms/templates/index.html
cms/templates/settings.html
2013-02-12 16:57:00 -05:00
cahrens
f56729dbdb
Turn off line wrapping.
2013-02-12 15:27:38 -05:00
Don Mitchell
76d675ba16
fix npe for time (bug 185)
2013-02-12 15:20:02 -05:00
Don Mitchell
40668133f7
Fix bug which I know I fixed before (perhaps on another branch?) to
...
ensure old time had a value before comparing it to new time.
2013-02-12 15:11:35 -05:00
cahrens
75ceed7f69
Show "successful save" message when a new edit is made.
2013-02-12 10:29:47 -05:00
