Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Prevent "saved" and "error" views from showing at the same time.

Browse Source 
Previously the "saved" view was never hidden, even after more data was
edited. So if one field was saved successfully and then another was
not, we would find ourselves in the unfortunate situation of seeing
both views at once, leading to much confusion.
This commit is contained in:
Peter Fogg
2013-06-24 11:06:53 -04:00
parent 72e08456a8
commit 3e376bd780
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cms/static/js/views/settings/advanced_view.js
View File

@@ -21,6 +21,7 @@ CMS.Views.Settings.Advanced = CMS.Views.ValidatingView.extend({
}
);
this.listenTo(this.model, 'invalid', this.handleValidationError);
this.savedBar = undefined;
},
render: function() {
// catch potential outside call before template loaded
@@ -136,15 +137,22 @@ CMS.Views.Settings.Advanced = CMS.Views.ValidatingView.extend({
success : function() {
self.render();
var message = gettext("Please note that validation of your policy key and value pairs is not currently in place yet. If you are having difficulties, please review your policy pairs.");
var saving = new CMS.Views.Alert.Confirmation({
self.saved = new CMS.Views.Alert.Confirmation({
title: gettext("Your policy changes have been saved."),
message: message,
closeIcon: false
});
saving.show();
self.saved.show();
analytics.track('Saved Advanced Settings', {
'course': course_location_analytics
});
},
error: function() {
// If we've already saved some data this will be
// shown; hide it away again.
if(self.saved) {
self.saved.hide();
}
}
});
},