Commit Graph

58743 Commits

Author SHA1 Message Date
Dillon Dumesnil
89c463ff29 refactor: Switch to using course_overview start and end everywhere
In DE-1822, we believed we needed to switch to start_date and end_date.
It was determined this was not the case, so this updates the comment
to ensure future users use the correct fields (start and end) and
updates any pieces of code that may have used start_date or end_date.
2021-05-06 16:42:10 -04:00
Julia Eskew
599d21b7bb feat: Deny course staff visibility of legacy courseware. (#27469)
Currently, course staff can always view their courses
in the Legacy courseware experience.

With this change, course staff will *not* be able
to view their courses if the New (MFE) courseware
experience has been enabled for them.

This does not affect global staff, and it does not
affect courses that are still running in the Legacy
experience.

Adds a new parameter returned by the course metadata API
used by the courseware MFE to determine if the button to
show legacy experience should be displayed or not.

TNL-8203
2021-05-04 13:55:34 -04:00
Justin Hynes
6313c1ba67 Merge pull request #27501 from edx/jhynes/microba-1178_modulestore
refactor: reduce certificate django apps dependence on the modulestore (generation_handler)
2021-05-04 13:03:15 -04:00
Michael Terry
b807b7c3d1 Merge pull request #27515 from edx/mikix/undo-migration
fix: bring back email_marketing model momentarily and bump enterprise
2021-05-04 12:36:49 -04:00
dylan-grafmyre
8995f1bf32 fix: prevent a backbone fieldview race condition that can delete user input (#25950)
* prevent a backbone fieldview race condition that can delete user input

eslint for effected

* Fixing quality

* Allow _super in fields.js

* Fixing new issues

* Revert some changes

* Fixing errors, formatting

* Fix bug

* Fix eslint rule allowing _super

* Refactor code

Co-authored-by: Dylan Grafmyre <dylan@opencraft.com>
Co-authored-by: Paulo Viadanna <paulo@opencraft.com>
2021-05-04 12:17:15 -04:00
Michael Terry
08c84a3ae7 fix: bring back email_marketing model momentarily and bump enterprise
Enterprise was still using email_marketing code. This will bump
enterprise to a version that does not any more. And also temporarily
put the email_marketing model back for blue/green deploy sanity.
2021-05-04 11:47:12 -04:00
irfanuddinahmad
20713b5c56 Merge pull request #27511 from edx/iahmad/ENT-4392
ENT-4392: Updated edx-enterprise version
2021-05-04 19:25:09 +05:00
Michael Terry
b3e2052304 Merge pull request #27513 from edx/mikix/drop-marketing-config
feat: drop unused EmailMarketingConfiguration model
2021-05-04 10:18:49 -04:00
Kshitij Sobti
456432fddb docs: ADR for exposing existing studio views through new JWT-enabled endpoints [BD-03] [BB-3965] (#27129)
* docs: ADR for exposing existing studio views through new JWT-enabled endpoints

To allow MFEs to drive existing studio functionality, we need to expose that
functionality via REST APIs that can be used by MFEs. This ADR describes an
approach to do that.

* Update cms/djangoapps/contentstore/docs/decisions/0002-restful-studio-apis-for-MFE.rst

Co-authored-by: Farhaan Bukhsh <farhaan@opencraft.com>

* Update cms/djangoapps/contentstore/docs/decisions/0002-restful-studio-apis-for-MFE.rst

Co-authored-by: Kyle McCormick <kdmc@pm.me>

Co-authored-by: Farhaan Bukhsh <farhaan@opencraft.com>
Co-authored-by: Kyle McCormick <kdmc@pm.me>
2021-05-04 09:53:38 -04:00
Robert Raposa
f41551ac65 Merge pull request #27506 from edx/robrap/ARCHBOM-1551-code-owner-squad
feat: add code_owner_squad custom attribute
2021-05-04 09:41:44 -04:00
Aarif
b97d283fda feat: added the email notification for job failures (#27508) 2021-05-04 18:23:21 +05:00
irfanuddinahmad
3e1f56c287 Updated edx-enterprise version 2021-05-04 17:45:04 +05:00
Michael Terry
33445240d9 feat: drop unused EmailMarketingConfiguration model
This follows on the commit that gutted the email_marketing djangoapp
by actually dropping the model from code and database.

The djangoapp could now be removed after Maple releases.

AA-607
2021-05-04 08:42:21 -04:00
Michael Terry
033b9474ac Merge pull request #27502 from edx/mikix/drop-email-marketing
feat!: remove all email_marketing djangoapp code
2021-05-04 08:39:08 -04:00
Justin Hynes
5db4fd5bb2 refactor: reduce certificate django apps dependence on the modulestore (generation_handler)
[MICROBA-1178]
- remove modulestore usage in `generation_handler.py`
- add duplicate functions that utilize a CourseKey or CourseOverview to remove dependence on modulestore (this will be cleaned up (if possible) at a later part of this refactor)
- add python API function to `content`/`course_overview` app that will retrieve a single CourseOverview (rather than a serialized list of dicts of CourseOverview data)
2021-05-04 07:47:58 -04:00
edX requirements bot
597630b7b1 chore: Updating Python Requirements (#27507) 2021-05-04 12:37:19 +05:00
Robert Raposa
0d5bdd3df4 feat: add code_owner_squad custom attribute
Upgrade edx-django-utils to bring in the new
code_owner_squad custom attribute for
monitoring purposes. See the edx-django-utils
changelog for details.

ARCHBOM-1551
2021-05-03 17:09:22 -04:00
Michael Terry
35f78a3241 feat!: remove all email_marketing djangoapp code
This djangoapp was designed for talking to sailthru, in a fairly
edx.org-specific way. Nowadays, edx.org doesn't need this code and
if other installations do, it's better off as a more distinct
plugin anyway, rather than direct support in the platform.

I've moved the one signal that was still useful (calling
segment.identify() whenever user fields change) into user_authn.

And I've left the EmailMarketingConfiguration model alone for now,
but will remove that shortly. Nothing uses it as of this commit.

AA-607
DEPR-139
2021-05-03 16:39:01 -04:00
Simon Chen
ebbb240027 MST-698 Remove escaping for Proctoring Requirements email on course_name and proctoring backend name (#27500)
The course name can contain apostrophes and other special characters. The email template right now escapes every words. This is not desired because it can render apostrophes like #39;. Update the email templates so only second half of the email template is escaped
2021-05-03 15:39:07 -04:00
Zachary Hancock
fb2cf54132 update edx-proctoring to 3.8.8 (#27499) 2021-05-03 14:07:57 -04:00
Carla Duarte
6a2adde87c Merge pull request #27477 from edx/ciduarte/AA-723
fix: include VerifiedModeSerializerMixin in Progress Tab API [AA-723]
2021-05-03 13:57:28 -04:00
Christie Rice
82bf0411ca test: Use allowlist factory (#27490)
MICROBA-1021
2021-05-03 12:53:36 -04:00
Carla Duarte
b7081f4ecd fix: include VerifiedModeSerializerMixin in Progress Tab API [AA-723] 2021-05-03 12:50:31 -04:00
Michael Terry
12e9763446 Merge pull request #27487 from edx/mikix/fix-gated-content-check
fix: properly set contains_gated_content field on xblocks again
2021-05-03 11:50:40 -04:00
Christie Rice
912f2fa431 feat!: Enable the allowlist for all courses (#27468)
MICROBA-1013
2021-05-03 11:15:04 -04:00
Zachary Hancock
6c62dfc748 chore: remove temporary edx-proctoring constraint (#27498) 2021-05-03 11:01:44 -04:00
Michael Terry
6e52aafc8c fix: properly set contains_gated_content field on xblocks again
This has been broken for a couple months, preventing proper display
of verified-only assignments on the dates tab and elsewhere.

AA-780
2021-05-03 10:17:17 -04:00
Christie Rice
98636654dd feat!: Remove allow_certificate field from the user profile as the field is no longer used (#27424)
DEPR-140 MICROBA-985
2021-05-03 09:28:36 -04:00
Christie Rice
b43c1ab27c test: Update allowlist tests, and remove verification of certificates app functionality (#27486)
MICROBA-1013
2021-05-03 09:26:22 -04:00
Matt Tuchfarber
1842cc08c6 fix: Hide cert availability on self paced courses (#27489)
If a certificate available date was set on a self paced course, it would
show text to the learner saying that the grades would be available in
the future when that was inaccurate.
2021-05-03 08:52:32 -04:00
Usama Sadiq
a1f80a00c7 refactor: pyupgrade second iteration (#27443) 2021-05-03 17:14:25 +05:00
Usama Sadiq
60f49d4048 refactor: pyupgrade second iteration (#27442) 2021-05-03 17:13:15 +05:00
Usama Sadiq
11ec4a9aaa refactor: pyupgrade second iteration (#27441) 2021-05-03 17:11:32 +05:00
Usama Sadiq
4a0731ce61 BOM-2499: pin python-slugify<5.0.0 (#27494)
* fix: pin python-slugify<5.0.0
transifex-client requires python-slugify<5.0.0 for Python 2.0 support which conflicts with the latest python-slugify version.
2021-05-03 14:58:38 +05:00
Usama Sadiq
228c54d222 refactor: pyupgrade second iteration 2021-05-03 14:55:47 +05:00
Usama Sadiq
3ff951940d refactor: pyupgrade second iteration 2021-05-03 14:55:37 +05:00
Shafqat Farhan
7c391f4c7e Merge pull request #27484 from edx/shafqat/VAN-437
[VAN-437] - Unlocking the learners upon successful password reset
2021-05-03 12:06:06 +05:00
stvn
9f1debac14 Merge PR #27343 bd03/api/legacy
* Commits:
  docs: Remove completed TODO discussions item
  feat: Add support to Discussions API for legacy cohort settings
  refactor: Remove get_course_discussion_settings helper
  refactor: Remove set_course_discussion_settings helper
  refactor: Add better DRF support to legacy discussions settings
2021-04-30 12:33:13 -07:00
Matt Tuchfarber
39bca7bba4 Merge pull request #27433 from edx/tuchfarber/fix_facebook_share
fix: Add callback function to Facebook share
2021-04-30 15:15:30 -04:00
stvn
718458115a docs: Remove completed TODO discussions item 2021-04-30 11:47:34 -07:00
stvn
e62705a365 feat: Add support to Discussions API for legacy cohort settings 2021-04-30 11:47:34 -07:00
stvn
1b76999c2f refactor: Remove get_course_discussion_settings helper 2021-04-30 11:47:34 -07:00
stvn
146887df1b refactor: Remove set_course_discussion_settings helper 2021-04-30 10:54:59 -07:00
stvn
6156064492 refactor: Add better DRF support to legacy discussions settings
so that we can re-use the existing serializer as a portability-shim in
the new API.
2021-04-30 10:54:55 -07:00
Matt Tuchfarber
b3e76dc151 fix: Facebook share button on course certificates.
Facebook requires a callback when using the `.ui()` method now. I don't
know when this changed, but the share button is currently broken on
course certificates.

Facebook documentation of the `.ui()` method:
https://developers.facebook.com/docs/javascript/reference/FB.ui/
2021-04-30 13:34:58 -04:00
Syed Muhammad Dawoud Sheraz Ali
0eb209d049 Merge pull request #27483 from edx/dsheraz/PROD-2334
feat: add pacing info in course enrollment serializer
2021-04-30 21:53:15 +05:00
DawoudSheraz
573d34c593 feat: add pacing info in course enrollment serializer 2021-04-30 19:45:47 +05:00
Shafqat Farhan
30bf95b053 VAN-437 - Unlocking the learners upon successful password reset 2021-04-30 18:36:21 +05:00
Usama Sadiq
f74d7c9ea7 refactor: pyupgrade second iteration 2021-04-30 15:35:47 +05:00
edX requirements bot
fe37651d15 Updating Python Requirements (#27481) 2021-04-30 11:59:02 +05:00