Adam Palay
893f05976d
make template string unicode
2013-08-09 12:25:14 -04:00
chrisndodge
09a83dcd1e
Merge pull request #589 from edx/fix/cdodge/better-export-error-messaging
...
give some debug message regarding why export has failed
2013-08-09 07:21:20 -07:00
Brian Talbot
5b4c15a57d
Studio: revises export prompt control copy
2013-08-09 10:01:23 -04:00
Valera Rozuvan
0b58c22b97
Merge pull request #593 from edx/valera/captions_keyboard_access_2
...
Valera/captions keyboard access 2
2013-08-09 00:49:28 -07:00
Valera Rozuvan
1efea116f6
Removed unnecessary leading and trailing spaces from heading in template.
2013-08-09 10:26:18 +03:00
Valera Rozuvan
f301231051
Enabled tabbing to volume slider.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
5380b5cfc3
Making it possible to tab through individual speeds.
...
In speed control, when it is focused, a drop down becomes available which contains all
of the available speeds that the player can switch to. When using the Tab button to
tab through all of the controls, it should be possible to select individual speed with
the keyboard.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
8bbe1c39f6
Turned off all VideoAlpha Jasmine tests.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
4c7250a000
Improved strings in template.
...
Only relevant part of string will go through the Python internationalization function.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
8a3ef33985
Fixing tests related to fetching YouTube metadata.
...
Previously we were using dummy YouTube IDs such as "slowerSpeedYoutubeId", and "normalSpeedYoutubeId".
This was causing errors when the code tried to fetch metadata from YouTube with that ID. We can't
stub these fetch requests because the data that is fetched is necessary. For example it contains
the length of the video.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
417bf6dd85
Removed some more comments.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
f9f9123ce4
Removed unnecessary commented out code from Jasmine tests.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
4f207299db
Changed back handling of Video by original Video code.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
1f238b953b
Fixed test for height of player when CC is disabled.
...
It turned out that we were reading the heights of the contols and other elements
before we initialized the heights.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
326d958727
Replaced Video with VideoAlpha.
...
Now all Video tags and VideoAlpha tags will be handled by VideoAlpha.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
f08394ac2c
Volume and speeds dialogs are fully extended.
...
When the controls receive focus not via mouse click or mouse hover, their appropriate
slider and selection menu are fully extended and shown to the user.
2013-08-09 09:22:57 +03:00
Valera Rozuvan
740a343b76
Styling improvements.
2013-08-09 09:22:56 +03:00
Valera Rozuvan
6f431df910
Fixed bug dealing with empty subtitles Url string.
...
Now when subs parameter is empty or the YouTube IDs are not specified,
captions will not try to fetch non-existent file.
2013-08-09 09:22:56 +03:00
Valera Rozuvan
fb0efd1b16
Made it so that keyboard also prolongs auto hiding of controls.
2013-08-09 09:22:56 +03:00
Valera Rozuvan
594ed6e0c3
Fixed failing test for VideoAlpha caption heiht.
...
It turns out that there was wrong invocation of toBeCloseTo() function. Most likely a typo.
Updated the readme.
2013-08-09 09:22:56 +03:00
Valera Rozuvan
d46542cba8
Removing JavaScript qTip tooltips.
...
Because sometimes the tooltips generated by qTip get in the way, and the controls becomes
not responsive, it was decided to use standard title attributes for tips.
Also along the way, an error was discoevered in Jasmine tests. It was fixed, but that test is
failing so it was marked specifically to be skipped when all VideoAlpha tests run.
2013-08-09 09:22:56 +03:00
Valera Rozuvan
b24ee15568
Fixed styling for volume button.
...
For some reason the "muted" icon was not showing. Styles have been corrected.Now on focus background color is also simplified for div
.volume control.
2013-08-09 09:22:56 +03:00
Valera Rozuvan
bc503c88c6
Making it possible to tab to captions.
...
When a VideoAlpha is present on the page, if the user tries to tab through out the entire page, eventually he will land on the VideoAlpha controls. The tab index order has been set up so that all control receive focus eventually in the order from left to right. When a control receives focus, it is hilighted. The last tab focuses the captions dialog. When the captions dialog has focus, the Up and Down arrows can scroll it up and down.
2013-08-09 09:22:56 +03:00
chrisndodge
bc2a9fc21b
Merge pull request #609 from edx/fix/cdodge/clone-course-needs-to-save-only-own-metadata
...
[STUD-608] django-admin clone_course needs to properly copy metadata as well as draft content
2013-08-08 19:18:03 -07:00
Chris Dodge
481eac7fc8
address PR feedback
2013-08-08 21:25:42 -04:00
Chris Dodge
7b4388ba8c
add more testing. Assert that metadata is properly cloned and that draft content is cloned as well
2013-08-08 21:25:42 -04:00
Chris Dodge
0e09ee61d7
update some unit tests on clone_course
2013-08-08 21:25:42 -04:00
Chris Dodge
55bfe46e79
need to filter out non-own metadata. Also we need to clone draft content
2013-08-08 21:25:42 -04:00
Chris Dodge
32d92d97e6
get_item -> get_instance
2013-08-08 21:01:38 -04:00
Chris Dodge
487ae964e4
implement PR feedback
2013-08-08 21:01:38 -04:00
Chris Dodge
4054544126
handle exceptions inside the outer exception handling
2013-08-08 21:01:38 -04:00
Chris Dodge
69c34a65b1
switch the notification to be a prompt and allow for the user to go to the edit unit page which contains the module in error. Otherwise, present the raw exception message and allow user to go to the course outline page.
2013-08-08 21:01:38 -04:00
Chris Dodge
fcaf3e6329
give some debug message regarding why export might fail
2013-08-08 21:01:38 -04:00
jnater
edc62ff692
Merge pull request #615 from edx/jnater/update_authors
...
Fix my name in AUTHORS file
2013-08-08 14:24:06 -07:00
Jean Manuel Nater
f105cd4225
Fix my name in AUTHORS file
2013-08-08 17:09:22 -04:00
Jonah Stanley
02d8da1cb9
Merge pull request #594 from edx/jonahstanley/firefox-acceptance-tests
...
Jonahstanley/firefox acceptance tests
2013-08-08 13:49:02 -07:00
frances botsford
581a8a6217
Merge pull request #586 from edx/fix/frances/studio-pdf-text-clarification
...
adjustment to sidebar help text on PDF textbook page in studio
2013-08-08 13:41:20 -07:00
JonahStanley
3e68bdaaf1
Changed world.browser.find_by_css to world.css_find
2013-08-08 13:24:29 -04:00
JonahStanley
bb9d0df0d7
Changed problem-editor scenario to pass in both firefox and chrome
2013-08-08 13:24:29 -04:00
JonahStanley
287d219a8e
Fixed wording on comments as tests are no longer skipped
2013-08-08 13:24:29 -04:00
JonahStanley
76764b8be2
Fixed weight test so it won't behave differently on firefox
2013-08-08 13:24:28 -04:00
JonahStanley
bcdc4bcbd4
Better avoiding of stale element exception
2013-08-08 13:24:28 -04:00
JonahStanley
f2a31adf6f
Now using world.is_firefox()
2013-08-08 13:24:28 -04:00
JonahStanley
5a579921f2
Fixed stylistic things and no longer skipped tests in firefox
2013-08-08 13:24:28 -04:00
JonahStanley
514af944cd
Fixed video tests for firefox
2013-08-08 13:24:28 -04:00
JonahStanley
83854643a2
Upgraded selenium requirements to run with the latest firefox
2013-08-08 13:24:28 -04:00
JonahStanley
fb41e8f20c
Fixed subsection test for firefox
2013-08-08 13:24:28 -04:00
JonahStanley
4c74a05c58
Added comments to the two flakey features on firefox
2013-08-08 13:24:27 -04:00
JonahStanley
36d948f5d3
Unskipped an acceptance test
2013-08-08 13:24:27 -04:00
JonahStanley
38c2997fcf
Added a comment on the features that will not work on firefox
2013-08-08 13:24:27 -04:00
