* fix: share link should show even if video download is disabled
* fixup! fix: share link should show even if video download is disabled
* chore: update test
* chore: linting
---------
Co-authored-by: Leangseu Kim <lkim@edx.org>
build: run ShellCheck
Adds a ShellCheck check to edx-platform PRs and master,
using the shared workflow & template from the .github repo.
This will become a "required" check once it passes for 2 straight weeks on master.
Brings all existing shell scripts into compliance with ShellCheck.
This is part of https://github.com/edx/edx-arch-experiments/issues/212.
2U is switching to using a prefix to reflect edx-platform's position as a
community repo. Our deployment process will also no longer produce
per-deploy branches and tags. This one branch will remain in place rather
than being kept in a private repo since the named-release branch-cutting
process still uses this as an indicator of what code has been field-tested.
Current State of the feature
Initially, this feature used the Notifier Django app but was deprecated
and removed from the configuration in favor of edx-notifications.
More info about this deprecation can be found in the GitHub issue (
https://github.com/openedx/build-test-release-wg/issues/22).
The edx-notifications app was not supported though, so its repository
was archived and moved to openedx-unsupported/edx-notifications.
Check the deprecation ticket (https://github.com/openedx/edx-notifications/issues/253)
and corresponding discussion (https://discuss.openedx.org/t/deprecation-removal-edx-notifications-repository/6748)
for details.
What remains in the edx-platform
The forum initial page contains the how-to info with the notification
preferences toggle.
This section is responsible for toggling the "notification_pref" user
preference (aka NOTIFICATION_PREF_KEY). I didn't find any usage of this
preference across the platform, so I'm suggesting hiding it by default
by setting the ENABLE_FORUM_DAILY_DIGEST setting to `False`.
Nine different URL-specified Python dependencies had
accumulated in edx-platform, noticably increasing the amount
time it took to install edx-platform requirements.
After many developer hours of work, we are nearly finished
converting them to PyPI-hosted depencencies:
openedx/wg-developer-experience#153
We're making these updates in hopes that we don't end
up with so many URL-specified depencencies again.
We're also updating OEP-18:
https://github.com/openedx/open-edx-proposals/pull/450
The CODEOWNERS update would mean that Arbi-BOM is notified
on all future PRs that change github.in. At the moment, edx-platform
does not *require* CODEOWNER review, so this is not a *hard* gate to
github.in changes.
* fix: fix credit serialization
Was accidentally indexing based on course ID string instead of course ID
* docs: update a docstring
Programs are weird in that they index on string of course ID instead of
course ID. Highlighting this info through the docstring
* test: add more checks in serialization tests
