Commit Graph

23223 Commits

Author SHA1 Message Date
Usama Sadiq
eaf2e68d2a build: Use DeploymentMonitoringMiddleware in settings (#28850) 2021-09-28 15:31:26 +05:00
David Ormsbee
deaf80f346 revert: "[BD-13] Let ModuleSystem use UserService" (#28857)
This caused a regression where anonymous_id values were not as expected.
Reverting for now, with investigation to follow.
2021-09-27 15:42:35 -04:00
David Ormsbee
3827f4c90d Merge pull request #28440 from open-craft/jill/BD-13-user-service
[BD-13] Let ModuleSystem use UserService
2021-09-24 09:26:43 -04:00
David Ormsbee
03382ae400 revert: feat: Added support for enterprise id in course_grade_passed_first_time event" (#28831) 2021-09-23 17:56:07 -04:00
Usama Sadiq
023f4144ab fix: fix new pylint warnings (#28725) 2021-09-23 17:54:15 +05:00
Kshitij Sobti
32748788bf fix!: use bleach instead of custom code to sanitise forum posts (#28641)
The rest API for discussions was using custom HTML sanitisation code that
matched the behaviour of the client-side library. This replaces the custom
code with bleach for better security.
2021-09-23 11:37:05 +05:00
Jillian Vogel
927016a8df refactor: fixes tests
* UserStubService now takes user, user_is_staff, and anonymous_user_id
* get_test_system() creates a UserStubService with an anonymous_user_id of 'student'
* Removes references to deprecated ModuleSystem attributes from test code
* Fixes and simplifies the ConditionalBlock tests, using get_module provided by TestModuleSystem instead of trying to mock out all the pieces.
2021-09-23 12:04:03 +09:30
Jillian Vogel
753839276f refactor: removes calls to deprecated ModuleSystem attributes
Removes references to these deprecated attributes from the platform code:
* runtime.anonymous_student_id
* runtime.seed
* runtime.user_id
* runtime.user_is_staff

Related changes:

* Ensure that all platform XBlocks which use these attributes "need" the user service.
* ProblemBlock: Removes check for existence of runtime.seed attribute in preparation for removal of this attribute from ModuleSystem.
* edxnotes: Catches NoSuchServiceError just in case some XBlocks using notes don't have the user service.
* UserTagsService refactor: pass user and course_id on creation
2021-09-23 11:46:43 +09:30
Jillian Vogel
c41e7fb93a refactor: deprecate ModuleSystem user attributes in favor of user service
The following ModuleSystem attributes are deprecated by this change, and should be pulled directly from the user service instead:

* anonymous_student_id
* seed
* user_id
* user_is_staff

Related changes:

* Removes the `user` and `anonymous_student_id` parameters from the ModuleService constructor.
* Stores anonymous_user_id in XBlockDjangoUserService's opt_attr
* Pulls out constants used by DjangoXBlockUserService opt_attr so they can be used in the platform code.
* LmsModuleSystem uses the user service created in wrapper function for runtime.publish to avoid requiring the user
  service to be "needed" by all XBlocks.
* LmsModuleSystem no longer checks for instances of XModuleDescriptor when deciding what kind of anonymous_user_id to
  provide:  all XModules are XBlocks, so this check is unnecessary.
* XBlockRuntime returns a user service when requested
* Adds tests for deprecated ModuleSystem attributes and changes to XBlockDjangoUserService.
2021-09-23 11:41:43 +09:30
Felipe Montoya
dbb4658819 Merge pull request #28640 from eduNEXT/MJG/2nd_batch_openedx_events
[BD-32] feat: add 2nd batch of Open edX Events
2021-09-22 14:12:06 -05:00
Bianca Severino
24e7819a2c Merge pull request #28815 from edx/bseverino/remove-proctoring-mfe-flags
[MST-938] Remove special exam MFE flags
2021-09-22 09:59:58 -04:00
Bianca Severino
0484799f84 fix: remove special exam mfe flags 2021-09-22 09:07:33 -04:00
Awais Qureshi
38e16d56b6 Merge pull request #28750 from edx/dj-cookie-samesite
fix: Don't use django-cookies-samesite on Django >= 3.1
2021-09-22 16:41:16 +05:00
julianajlk
a7759582df fix: privacy banner close button issue in Track Selection (#28814) 2021-09-21 16:58:26 -04:00
julianajlk
94378cb06c feat: add JS for upgrade button redirect in Track Selection (#28805)
REV-2387
2021-09-21 13:34:10 -04:00
Matjaz Gregoric
5487ff5906 Fix RTL issue with capa problems (#28562)
* fix: resolve styling cap RTL styling issue

Margins were incorrect in the RTL version of the stylesheet.

* fix: move style overrides from lms-course to capa

These styles were only applied to the LTR version of the stylesheet, but
we want them in the RTL version as well.
2021-09-21 10:44:35 -04:00
Phillip Shiu
6d7dcef8d6 fix: correct typo, content is locked, not lost (#28802) 2021-09-21 09:49:55 -04:00
Sarina Canelake
c699923d03 Merge pull request #28628 from edx/sarina/i18n-tuneup
fix: abstract edX-specific strings
2021-09-21 08:57:58 -04:00
AsadAzam
208e1b177c feat: Implement program discussions iframe (#28770)
* feat: Implement program discussions iframe

* Fixed conflicts

* Fixed conflicts

* Fixed conflicts

* Refactored code
2021-09-21 16:24:52 +05:00
edX requirements bot
0f528f9125 Python Requirements Update (#28806)
* chore: Updating Python Requirements

* fix: disabled unused import warnings

Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
2021-09-21 14:21:00 +05:00
Michael Terry
1133854a59 Merge pull request #28783 from edx/mikix/goal-reminder-email-aa-908
Add goal reminder email management command
2021-09-20 15:18:18 -04:00
Michael Terry
ce39f52680 chore: add tests for new goal reminder email management command 2021-09-20 14:32:06 -04:00
Matthew Piatetsky
ba7518304c Merge pull request #28675 from edx/AA-905
Populate the course goals user activity table when a user visits course-specific pages
2021-09-20 13:52:27 -04:00
Matthew Piatetsky
3200851563 start addressing comments 2021-09-20 13:08:12 -04:00
Awais Qureshi
708dbb71ec fix: removing jango-cookies-samesite package for django32. 2021-09-20 19:01:54 +05:00
julianajlk
42d79c5ef5 fix: get correct root URL for Track Selection page (#28772)
REV-2387
2021-09-20 09:56:42 -04:00
Awais Qureshi
71567719f2 fix: Don't use django-cookies-samesite on Django > 3.1
BOM-2752
2021-09-20 18:54:52 +05:00
Ahtisham Shahid
f2c3b5939d feat: Moved Programs details data in respective tabs (#28700)
* feat: Moved Programs details data in respective tabs
2021-09-20 12:38:11 +05:00
sarina
0c74d347f7 fix: abstract edX-specific strings 2021-09-19 14:01:20 -04:00
Soban Javed
56d12bf230 feat!: upgrade pyjwt to version 2.1.0 2021-09-17 16:08:15 +05:00
Sarina Canelake
5ab43ca0c2 Merge pull request #28638 from edx/sarina/abstract-branded-url-strings
Remove or contextualize references to `edX.org` in translated strings
2021-09-16 12:58:06 -04:00
Matthew Piatetsky
bf6e135762 feat: Populate the course goals user activity table when a user visits course-specific pages 2021-09-16 12:30:36 -04:00
Syed Muhammad Dawoud Sheraz Ali
df20c2e0ea Merge pull request #28754 from edx/dsheraz/PROD-2477
feat: add support-only endpoint to get FBE details
2021-09-16 21:06:57 +05:00
Andrew Shultz
9b4656c96d Merge pull request #28753 from edx/ashultz0/rm-duplicate-verified-name-flag
fix: remove now unnecessary course flag for verified names
2021-09-16 10:28:21 -04:00
Awais Jibran
4196ac7730 refactor: remove duplicate decorator (#28763) 2021-09-16 16:06:29 +05:00
Dillon Dumesnil
659283d0fd feat: AA-908: Add goal reminder email management command 2021-09-15 17:44:28 -04:00
Phillip Shiu
86f902b002 Merge pull request #28655 from edx/pshiu/REV-2325_TrackSelectionUnhappyPath
feat: Add screen for partial feature based enrollment
2021-09-15 16:13:35 -04:00
Phillip Shiu
b6e79c6dc8 fix: review comments on names and link variables 2021-09-15 15:20:23 -04:00
Robert Raposa
8cfe58ab8e Revert "refactor: Misc. clean up from dashboard investigation" 2021-09-15 14:54:28 -04:00
Maria Grimaldi
1c447e6176 feat: add 2nd batch of Open edX Events
* Add COURSE_ENROLLMENT_CHANGED: sent after the enrollment update
* Add COURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollment
* Add CERTIFICATE_CREATED after the user's certificate generation has
been completed
* Add CERTIFICATE_CHANGED: after the certification update has been
completed
* Add CERTIFICATE_REVOKED: after the certificate revocation has been
completed
* Add COHORT_MEMBERSHIP_CHANGED: when a cohort membership update ends
2021-09-15 14:50:28 -04:00
edX Transifex Bot
879f0262fd chore(i18n): update translations 2021-09-15 23:39:09 +05:00
DawoudSheraz
80637ed891 feat: add support-only endpoint to get FBE details 2021-09-15 22:46:50 +05:00
Andy Shultz
4b05f23d30 fix: remove now unnecessary course flag for verified names
MST-1020
2021-09-15 13:33:48 -04:00
sarina
a6616fd292 fix: Remove or contextualize refs to edX.org in strings 2021-09-15 12:21:10 -04:00
Phillip Shiu
9185b3335b fix: correct relative paths in templates to track_selection.html 2021-09-15 12:08:21 -04:00
Phillip Shiu
9d259d7a99 refactor: remove folder track_selection_types 2021-09-15 12:08:21 -04:00
Phillip Shiu
2997e23f83 refactor: s/full_fbe/fbe, s/partial_fbe/unfbe + unfbe logic 2021-09-15 12:08:20 -04:00
Phillip Shiu
359f3cf3f6 fix: add partial_fbe.html 2021-09-15 12:08:20 -04:00
Phillip Shiu
2e5b922692 fix: abstract track selection bullets into new mako template 2021-09-15 12:08:08 -04:00
Dillon Dumesnil
1db8ee5edc Merge pull request #28669 from edx/ddumesnil/misc-cleanup
refactor: Misc. clean up from dashboard investigation
2021-09-15 07:52:56 -07:00