Merge pull request #28753 from edx/ashultz0/rm-duplicate-verified-name-flag

fix: remove now unnecessary course flag for verified names
This commit is contained in:
Andrew Shultz
2021-09-16 10:28:21 -04:00
committed by GitHub
3 changed files with 3 additions and 22 deletions

View File

@@ -140,18 +140,6 @@ COURSEWARE_MICROFRONTEND_PROCTORED_EXAMS = CourseWaffleFlag(
WAFFLE_FLAG_NAMESPACE, 'mfe_proctored_exams', __name__
)
# .. toggle_name: courseware.verified_name
# .. toggle_implementation: CourseWaffleFlag
# .. toggle_default: False
# .. toggle_description: Course waffle flag for verified name functionality (see https://github.com/edx/edx-name-affirmation)
# .. toggle_use_cases: temporary
# .. toggle_creation_date: 2021-7-14
# .. toggle_target_removal_date: None
# .. toggle_warnings: None
COURSEWARE_VERIFIED_NAME_FLAG = CourseWaffleFlag(
WAFFLE_FLAG_NAMESPACE, 'verified_name', __name__
)
def mfe_special_exams_is_active(course_key: CourseKey) -> bool:
"""
@@ -308,10 +296,6 @@ def streak_celebration_is_active(course_key):
)
def is_verified_name_enabled_for_course(course_key):
return COURSEWARE_VERIFIED_NAME_FLAG.is_enabled(course_key)
# .. toggle_name: COURSES_INVITE_ONLY
# .. toggle_implementation: SettingToggle
# .. toggle_type: feature_flag

View File

@@ -66,8 +66,7 @@ from ..module_render import get_module_for_descriptor, toc_for_course
from ..permissions import MASQUERADE_AS_STUDENT
from ..toggles import (
courseware_legacy_is_visible,
courseware_mfe_is_advertised,
is_verified_name_enabled_for_course
courseware_mfe_is_advertised
)
from .views import CourseTabView
@@ -445,8 +444,7 @@ class CoursewareIndex(View):
'section_title': None,
'sequence_title': None,
'disable_accordion': not DISABLE_COURSE_OUTLINE_PAGE_FLAG.is_enabled(self.course.id),
'show_search': show_search,
'is_verified_name_enabled': is_verified_name_enabled_for_course(self.course.id),
'show_search': show_search
}
courseware_context.update(
get_experiment_user_metadata_context(

View File

@@ -246,8 +246,7 @@ ${HTML(fragment.foot_html())}
</div>
</header>
<main id="main" tabindex="-1" aria-label="Content"
data-is-verified-name-enabled="${is_verified_name_enabled}">
<main id="main" tabindex="-1" aria-label="Content">
% if getattr(course, 'entrance_exam_enabled') and \
getattr(course, 'entrance_exam_minimum_score_pct') and \
entrance_exam_current_score is not UNDEFINED: