Commit Graph

58328 Commits

Author SHA1 Message Date
Justin Hynes
6b38debfeb feat: Update cert_generation mgmt command with ability to read arguments from config model
[MICROBA-1100]
* Add CertificationGenerationCommandConfiguration model that will store the command arguments for the `cert_generation` mgmt command
* Add ability to add entries to the CertificationGenerationCommandConfiguration through Django admin
* Update mgmt command with ability to read arguments from the config model/database
* Fix failing test in `test_cert_generation.py`
* Add new test for missing `users` argument in `test_cert_generation.py`
2021-04-01 07:39:33 -04:00
jawad khan
5025a3ffd9 feat!: remove "Text Me the App" page from web app because of security concern
Someone at edx was able to quickly send a few texts to himself using the tool.
Each text came from a different number and there was no message about the ability to unsubscribe or stop.
This could potentially be used to spam users as well as potentially result in charges to edX for high volume.

page url https://courses.edx.org/text-me-the-app
LEARNER-8286
2021-03-30 23:38:24 +05:00
Adam Blackwell
dd69020de1 fix: Add space after comma in legacy unenroll message. (#27177) 2021-03-30 10:48:44 -04:00
Christie Rice
8198606138 feat: Refactor code to check both regular and allowlist V2 certs (#27156)
MICROBA-1039
2021-03-30 10:23:23 -04:00
Dillon Dumesnil
feb4c13608 Merge pull request #27154 from edx/ddumesnil/hidden-content-fix-aa-724-part-3
fix: AA-724: Updating the HiddenContentTransformer
2021-03-30 05:41:55 -07:00
alangsto
736e399cde MST-643 prevent errors for escalation email if proctoring is disabled (#27166) 2021-03-30 08:33:48 -04:00
Ali Akbar
4a515e983c Merge pull request #26918 from edx/aakbar/PROD-1136
[Support Tool] Update the Enrollments to take Entitlements into account
2021-03-30 13:05:07 +05:00
edX requirements bot
27883f61d3 Updating Python Requirements (#27178) 2021-03-30 12:30:59 +05:00
Kellie Selinka
d902d46e3e Merge pull request #27176 from edx/kselinka_bump_edx_enterprise_down
bump edx-enterprise back down to 3.20.1
2021-03-29 17:13:30 -04:00
Michael Terry
5e3f97265e Merge pull request #27175 from edx/mikix/bail-early-for-hierarchy
fix: don't count hierarchy blocks as complete for assignments
2021-03-29 16:35:20 -04:00
Kellie Selinka
5bf44a9420 bump edx-enterprise back down to 3.20.1 2021-03-29 16:27:09 -04:00
Michael Terry
5d9e7e9fe5 fix: don't count hierarchy blocks as complete for assignments
When considering whether a subsection is complete as an assignment,
skip any "hierarchy" types (sequential, vertical, etc) that don't
have children. If the user can't see the content, don't risk
marking it as complete.

AA-726
2021-03-29 16:06:11 -04:00
Fred Smith
6ed9f541c9 Merge pull request #27168 from edx/derf/feat-use-github-version-of-py2neo
fix: use github version of py2neo
2021-03-29 14:46:47 -04:00
Fred Smith
36fa6e9899 Merge pull request #27169 from edx/jenkins/upgrade-python-requirements-41b01c0
Python Requirements Update
2021-03-29 14:16:02 -04:00
edX requirements bot
5111a83be6 Updating Python Requirements 2021-03-29 14:14:48 -04:00
Fred Smith
41b01c07eb fix: use github version of py2neo instead of PyPI
The version of Py2neo we depend on has been removed from PyPI.  This is
a stop-gap until we can upgrade it
2021-03-29 14:09:29 -04:00
Kellie Selinka
4650301f6a Merge pull request #27167 from edx/kselinka_bump_enterprise
bump edx-enterprise to 3.20.2
2021-03-29 13:17:21 -04:00
Kellie Selinka
00f4cb09f6 bump edx-enterprise to 3.20.2 2021-03-29 12:33:08 -04:00
Dillon Dumesnil
c4a96a2fa3 fix: AA-724: Updating the HiddenContentTransformer
We heard about a bug where learners granted extensions would still
lose access to content if it was marked as "hidden after due date".
This was caused by the HiddenContentTransformer using the due date
from collection time (publish time) rather than the user date returned
from the edx-when DateOverrideTransformer.

A small subtletly of this PR is that Transformers with the
FilteringTransformerMixin are executed before those without it so
part of the fix was to make the HiddenContentTransformer not use the
FilteringTransformerMixin to ensure the DateOverrideTransformer had
run first.

Part 3/3 - Removing old collect code with merged due date
2021-03-29 10:15:23 -04:00
Dillon Dumesnil
01839789e0 Merge pull request #27153 from edx/ddumesnil/hidden-content-fix-aa-724-part-2
fix: AA-724: Updating the HiddenContentTransformer
2021-03-29 07:13:40 -07:00
Thomas Tracy
9f4e51a241 feat: Add command to generate credentials config (#27088)
Adds a command to create an API connection to credentials for testing
program certificates on devstack. This command is not meant to be ran
manually, and will be included in a provisioning type script that will
be added later.
2021-03-29 10:04:59 -04:00
Christie Rice
b452f3d5f3 docs: Add ADR on regular course certificate requirements (#27140)
MICROBA-1039
2021-03-29 09:53:50 -04:00
edX requirements bot
0ad27ed2fe Updating Python Requirements (#27161) 2021-03-29 15:08:50 +05:00
Awais Jibran
529a805c0c Fixing dates serialization in course import (#27137) 2021-03-29 13:43:01 +05:00
Ali-D-Akbar
ee5b383ff6 PROD-1136: [Support Tool] Update the Enrollments support tool to take entitlements into account. 2021-03-29 12:26:16 +05:00
Dillon Dumesnil
1614fb2956 fix: AA-724: Updating the HiddenContentTransformer
We heard about a bug where learners granted extensions would still
lose access to content if it was marked as "hidden after due date".
This was caused by the HiddenContentTransformer using the due date
from collection time (publish time) rather than the user date returned
from the edx-when DateOverrideTransformer.

A small subtletly of these PRs is that Transformers with the
FilteringTransformerMixin are executed before those without it so
part of the fix was to make the HiddenContentTransformer not use the
FilteringTransformerMixin to ensure the DateOverrideTransformer had
run first.

Part 2/3 - Updating transform method + updating Read version
2021-03-26 14:05:53 -07:00
Dillon Dumesnil
8551528370 Merge pull request #27152 from edx/ddumesnil/hidden-content-fix-aa-724-part-1
fix: AA-724: Updating the HiddenContentTransformer
2021-03-26 14:03:42 -07:00
Feanil Patel
5fe4913735 Merge pull request #27155 from edx/feanil/fix_request_user_logging
fix: Don't make request change logging a waffle flag.
2021-03-26 15:45:57 -04:00
Feanil Patel
c1bdf01876 fix: Don't make request change logging a waffle flag.
Waffle flags are useful for gradual rollout but that's not possible this
high in the middleware because a lot of the data needed (request.user)
to partition incoming requests is not availabale this high in the
middleware.

Convert this to a WaffleSwitch which will be safer to operate.

Also increase the number of frames in the stack to print per change.
Printing just 1 did not provide enough info because DRF requests wrap
WSGI requests and have a setter proxy.  It will be useful to figure out
how they do this in case it's better that what we're doing in the safe
sessions middleware.

Ticket: https://openedx.atlassian.net/browse/ARCHBOM-1718
2021-03-26 14:38:35 -04:00
Dillon Dumesnil
d96f756994 fix: AA-724: Updating the HiddenContentTransformer
We heard about a bug where learners granted extensions would still
lose access to content if it was marked as "hidden after due date".
This was caused by the HiddenContentTransformer using the due date
from collection time (publish time) rather than the user date returned
from the edx-when DateOverrideTransformer.

A small subtletly of these PRs is that Transformers with the
FilteringTransformerMixin are executed before those without it so
part of the fix was to make the HiddenContentTransformer not use the
FilteringTransformerMixin to ensure the DateOverrideTransformer had
run first.

Part 1/3
2021-03-26 10:59:55 -07:00
Michael Terry
dc581d59fc Merge pull request #27149 from edx/mikix/bump-ace
feat: bump edx-ace to 1.1.0
2021-03-26 10:30:38 -04:00
Michael Terry
d7a242e888 feat: bump edx-ace to 1.1.0
This gives us the ability to set a Braze-specific from-address via
configuration settings.
2021-03-26 09:59:19 -04:00
Carla Duarte
0d7140875f Merge pull request #27141 from edx/ciduarte/AA-722-2
fix: surface assignment type short_label in Progress Tab MFE API
2021-03-26 09:47:01 -04:00
Zachary Hancock
a33e8c0812 update edx-proctoring to 3.7.15 (#27143) 2021-03-26 08:39:21 -04:00
edX requirements bot
71f9688cb5 Updating Python Requirements (#27145) 2021-03-26 14:24:49 +05:00
Carla Duarte
4570d4e3d8 fix: surface assignment type short_label in Progress Tab MFE API 2021-03-25 17:52:15 -04:00
Saad Yousaf
229565a072 Merge pull request #27126 from edx/saad/TNL-7971-followup
[TNL-7971] - Correct filename for anonymized id report.
2021-03-26 00:40:03 +05:00
Feanil Patel
68bd33f310 Merge pull request #27138 from edx/feanil/add_request_user_change_logging
feat: Add more detailed request user change logging.
2021-03-25 14:01:52 -04:00
Feanil Patel
4f9fe59731 test: Fix date tests that rely on user preference.
The function under test by the StrftimeLocalizedHtmlTest checks the
timezone in the user preferences of the user making the request.  If we
don't explicitly set a request here, it will simply use the last Request
that `crum` cached in the thread local cache.  This broke now
that we sometimes set the crum request.user to an invalid user in other
tests.

This change ensures that we have a valid request for these tests as a
part of the setup of this test class.
2021-03-25 13:18:07 -04:00
Waheed Ahmed
f8de211e17 Fix redirection on SSO auth complete.
Since we are handling the MFE redirection in login_and_registration_form()
we don't need to handle it here. It's redirecting the enterprise users to
MFE instead of FE which is currently handled in login_and_registration_form()
view.

VAN-425
2021-03-25 22:16:34 +05:00
Feanil Patel
c2eabf6cca test: Update query counts.
The new WaffleFlag.is_enabled check in middleware increased query counts
for multiple tests.
2021-03-25 12:14:53 -04:00
Feanil Patel
0714ac5f0e feat: Add more detailed request user change logging.
The change is behind a WafleFlag and can be turned on to log every time
the `user` attribute of an instrumented request changes.  This will
significantly increase log volume so it shouldn't be left on all the
time but can be turned on to quickly debug issues related to sessions.

Ticket: https://openedx.atlassian.net/browse/ARCHBOM-1718
2021-03-25 12:14:53 -04:00
Shimul Chowdhury
eba710ccb5 feat: added batch_get_or_create class method for ExternalId (#25844)
* Added batch_get_or_create_user_ids method for ExternalId Model

Update doc string

* Update docstring & fix bug on test

[BD-24] [BB-2726] [TNL-7330]
2021-03-25 12:09:32 -04:00
Christie Rice
dabad9fdfd feat: Add cert_generation management command (#27131)
MICROBA-1078
2021-03-25 11:01:41 -04:00
Waheed Ahmed
b200699fc6 Keep user on FE if there is a running pipeline for SAML IDPs.
For some SAML providers, learners are redirected to MFE and breaking
the flow. Check for running pipeline and if the provider is a SAML
provider keep them on FE.

VAN-425
2021-03-25 18:43:19 +05:00
Christie Rice
9a24e72643 fix: Require web certs (#27120)
MICROBA-1039
2021-03-25 09:29:51 -04:00
Régis Behmo
cfc45a1c19 docs: annotate REGISTRATION_EXTRA_FIELDS setting (#27136)
Close https://github.com/openedx/build-test-release-wg/issues/10
2021-03-25 08:02:24 -04:00
Zainab Amir
8cc5f13daf Add rate limit to registration endpoint (#27060)
Currently the registration endpoint has no rate limit. Added a new ratelimit
variable to support the change, it's value is set to 60/7d.

VAN-302
2021-03-25 16:28:30 +05:00
edX requirements bot
671ad883fc Updating Python Requirements (#27133) 2021-03-25 14:32:49 +05:00
AsadAzam
9bf96765cc display error during import upload (#27128) 2021-03-25 12:54:18 +05:00