Commit Graph

7419 Commits

Author SHA1 Message Date
Feanil Patel
f9a28d1654 fix: Mark user change as expected in LTIToolLaunchView.post
The lti user gets authenticated and logged in as a part of the LTI View
Post.  This results in the request user changing during the request.  We
mark it here so that it does not produce a false alarm in our
SafeSessions middleware.
2021-10-15 10:10:39 -04:00
Felipe Montoya
678c159cf8 docs: adding the first version of documentation for open edx events
Includes:
- general documentation
- links to individual events definitions and location
- adding examples to events docs
- adding annotations at the trigger location
2021-10-13 15:28:24 -05:00
Tim McCormack
fe3d855986 feat: Don't warn about expected user changes in safe-sessions (#28983)
This is intended to silence a rare false positive that seems to happen
when someone logs in on a browser that already has an active session
for another user. We believe there should be no further positives once
this case is handled.

- login and logout views annotate the response to indicate the session
  user should be changing between the request and response phases
- safe-sessions middleware skips the verify-user check when this
  annotation is present

Also:

- Adds a test around existing behavior for unexpected user-changes
- Remove logging control based on `is_from_log_out`. This reverts most
  of af9e26f/PR #11479 for two reasons:
  - The safe-sessions `_verify_user` code has since changed to check for
    `request.user.id == None`
  - A commit later in the PR changes the login and logout pages to
    signal that the user/session change is expected
2021-10-13 15:53:16 +00:00
Shafqat Farhan
feb732d859 fix: VAN-739 - removed is_active property from Segment 2021-10-11 19:23:14 +05:00
SaadYousaf
91fcad813d fix: update discussion features with support level added to API response 2021-10-11 17:40:44 +05:00
Manjinder Singh
9ef8332a60 Revert "feat: adding code owner for a Celery event"
This reverts commit 2c37fec345.
2021-10-08 17:30:16 -04:00
Manjinder Singh
2c37fec345 feat: adding code owner for a Celery event 2021-10-08 17:29:06 -04:00
Michael Terry
8253d41ccf fix: drop segment call for streak discount
It's being moved to the frontend, to better control when it's
emitted (we want to only emit it if the voucher has not yet been
claimed, which the frontend will ask ecommerce about).

AA-1012
2021-10-08 13:51:34 -04:00
Mubbshar Anwar
23c94b7ec5 fix: add opt in/out event (#28985)
add opt in/out event for Braze.

VAN-738
2021-10-08 22:39:54 +05:00
Mubbshar Anwar
66291c3aa6 feat: record opt in/out attribute (#28883)
* feat: record opt in/out attribute

save opt in/out attribute comming from frontend-app-authn register page.
VAN-738

* feat: VAN-738 - Send marketing event property and email subscription

* feat: VAN-738 - Send marketing event property and email subscription

* feat: VAN-738 - updated conditions

* feat: VAN-738 - added is_active for braze during registration

* feat: VAN-738 - added is_active for braze during registration

* feat: VAN-738 - fixed pep8 violation

Co-authored-by: Shafqat Farhan <shafqat.farhan@arbisoft.com>
2021-10-08 18:29:18 +05:00
David Ormsbee
ae124bd554 Revert "feat: store split modulestore's course indexes in Django/MySQL"
This reverts commit 96e5ff8dce.
2021-10-07 15:07:42 -04:00
Braden MacDonald
96e5ff8dce feat: store split modulestore's course indexes in Django/MySQL
Split modulestore persists data in three MongoDB "collections": course_index (list of courses and the current version of each), structure (outline of the courses, and some XBlock fields), and definition (other XBlock fields). While "structure" and "definition" data can get very large, which is one of the reasons MongoDB was chosen for modulestore, the course index data is very small.

By moving course index data to MySQL / a django model, we get these advantages:
* Full history of changes to the course index data is now preserved
* Includes a django admin view to inspect the list of courses and libraries
* It's much easier to "reset" a corrupted course to a known working state, by using the simple-history revert tools from the django admin.
* The remaining MongoDB collections (structure and definition) are essentially just used as key-value stores of large JSON data structures. This paves the way for future changes that allow migrating courses one at a time from MongoDB to S3, and thus eliminating any use of MongoDB by split modulestore, simplifying the stack.
2021-10-07 10:59:47 -04:00
Muhammad Soban Javed
fc14dba632 Merge pull request #28968 from edx/iamsobanjaved/django32-user-api-bool-fix
refactor: use value for filtering indexed boolean field
2021-10-07 17:53:06 +05:00
Jawayria
7d50ce104a refactor: use value to filter indexed boolean field (#28970)
* refactor: use value to filter indexed boolean field

* Update views.py

Co-authored-by: Awais Qureshi <awais.qureshi@arbisoft.com>
2021-10-07 17:52:45 +05:00
Soban Javed
a830b08f05 refactor: use value for filtering indexed boolean field 2021-10-07 16:06:58 +05:00
Kshitij Sobti
3e05e0f49b feat: add support for enabling/disabling the wiki app (#28889)
Currently the wiki app can't be enabled or configured. This change allows enabling/disabling the wiki app which effectively hides/shows the wiki tab.
2021-10-07 11:04:03 +05:00
Matthew Piatetsky
449d5c7a2d feat: only email users about their goal in the morning in their timezone (#28922) 2021-10-06 15:02:03 -04:00
Matthew Piatetsky
d7cc866280 feat: surface goals in courseware api (#28952) 2021-10-06 12:28:06 -04:00
Bianca Severino
12cdfa6201 Merge pull request #28927 from edx/bseverino/same-name-change
[MST-1105] Prevent name change request if requested name is identical to existing name
2021-10-06 11:07:40 -04:00
Bianca Severino
e9d22fc190 fix: prevent name change request if requested name is identical to the existing name 2021-10-06 10:01:23 -04:00
Awais Jibran
aac6c4c4cb fix: default discussion config (#28900)
* fix: default discussion config

* refactor: add closing bracket

Co-authored-by: Asad <asadazam93@gmail.com>
2021-10-06 16:37:16 +05:00
Robert Raposa
f3e5838b89 docs: update unexpected_multiple_exceptions comment (#28939)
Update the unexpected_multiple_exceptions comment based on findings
from monitoring since this was originally released.
2021-10-05 14:08:22 -04:00
João Victor Martins
1fc33070c3 docs: Add ADR for LTI tools in content libraries 2021-10-05 10:11:06 -07:00
Muhammad Soban Javed
d70c8ab968 Merge pull request #28680 from edx/iamsobanjaved/jsonfield-switch
feat: replace jsonfield2 with jsonfield
2021-10-05 22:03:30 +05:00
Muhammad Soban Javed
e58cae34e1 Merge pull request #28796 from edx/iamsobanjaved/django30-lang-BOM-2783
fix: use language preference from cookie instead of from session
2021-10-05 18:43:57 +05:00
Aarif
7d2cc016ec fix: added type annotations to fix mypy failure in CI (#28933) 2021-10-05 17:04:11 +05:00
Soban Javed
dd591dba55 feat: replace jsonfield2 with jsonfield
- updating all packages
- added migrations
2021-10-05 16:30:43 +05:00
Zachary Hancock
ae0927713d fix: consistent error response on name change (#28866) 2021-10-04 16:32:34 -04:00
Aarif
c162a25045 fix: fixed build errors blocking django 3.1 and 3.2 tests (#28923) 2021-10-05 00:39:08 +05:00
Kshitij Sobti
9e787a09bc chore: remove dependency on rest_condition (#28663)
rest-condition has not been updated for a while, and with DRF 3.9 it is no longer needed since the ability to combine Permission classes using boolean operators is now provided by DRF directly.
2021-10-04 15:38:17 -04:00
Régis Behmo
0af38bf2a7 build: run github actions on pull requests (#27786) 2021-10-04 21:29:18 +05:00
Soban Javed
44ddbdf925 fix: use cookies for storing language instead of session
- Fixed LANGUAGE_COOKIE settings name to LANGUAGE_COOKIE_NAME beacuse later is recognised by django
- Added test to verify cookies use in dark lang middleware
- Fixing Django 3.0 tests
2021-10-04 21:00:29 +05:00
Kyle McCormick
6ea900cba6 docs: remove link to edX.org-internal coursegraph queries (#28918)
I had thought this wiki page was publicly accessible, but it
turns out that it is restricted to edX employees. Making the
page publicly visible would involve editing some queries
to remove edX.org-specific information, which is doable but
not something I can commit to right now.
2021-10-04 11:34:29 -04:00
Robert Raposa
e41520dbae feat: return user id from login_refresh (#28905)
To enhance monitoring of login_refresh issues that happen
in the frontend, return user id as part of successful
refreshes.
2021-10-04 11:00:07 -04:00
Soban Javed
ec5f461d78 fix: update test for race condition while saving course overview
This test was failing for Django 3 and during investigation it found that it isn't working as per expected due to introduction of caching. So fixed the test case to avoid caching to mimic race condition.

BOM-2799
2021-10-01 19:08:57 +05:00
Rebecca Graber
bf025a9b0c feat: Add custom attribute for cookie header size
ARCHBOM-1910
2021-10-01 08:09:41 -04:00
Awais Jibran
872de99acc fix: textbooks should be enabled if course has any textbooks enabled. (#28887)
fix: proctoring settings to show pop up modal
fix: custom pages to be "disabled" by defualt
fix: only build lagacy link when app sends any link
2021-10-01 16:26:14 +05:00
Rebecca Graber
2ffbbeba9a chore: lint 2021-09-30 14:46:31 -04:00
Rebecca Graber
adcc9cb9b8 fix: tests 2021-09-30 14:34:57 -04:00
Rebecca Graber
0356d96b67 chore: lint 2021-09-30 12:50:04 -04:00
Rebecca Graber
8454c5bfcb chore: lint 2021-09-30 12:12:29 -04:00
Rebecca Graber
9e44714f4a feat: add custom attribute for total cookie header size 2021-09-30 11:45:55 -04:00
Usama Sadiq
d5e2ac9b0e fix: update static file path in tests (#28872)
fix similar test in openedx
2021-09-30 19:16:23 +05:00
Matthew Piatetsky
be5241a96d Merge pull request #28865 from edx/AA-905b
[AA-905] Refactor flag for recording user activity
2021-09-30 08:51:30 -04:00
Matthew Piatetsky
ae618151a9 fix: Remove debugging flag that is no longer necessary and refactor 2021-09-29 15:05:14 -04:00
Mike OConnell
3d07e72240 Merge pull request #28859 from edly-io/ERTE-55-1
feat: Added support for enterprise id in course_grade_passed_first_time event
2021-09-29 10:31:00 -04:00
David Ormsbee
82441d6f87 Merge pull request #28837 from edx/ormsbee/edx_when_outline_optimization
Re-enable edx-when outline optimization
2021-09-29 09:17:39 -04:00
RehanAziz
3633cdbc01 feat: Added support for enterprise id in course_grade_passed_first_time event 2021-09-28 18:52:15 +05:00
David Ormsbee
deaf80f346 revert: "[BD-13] Let ModuleSystem use UserService" (#28857)
This caused a regression where anonymous_id values were not as expected.
Reverting for now, with investigation to follow.
2021-09-27 15:42:35 -04:00
Julia Eskew
cc3747add6 feat: Optimize the querying of course block dates when querying dates for use in a
course outline, which don't need block dates below the subsection level of a course.
Pass the course's published version to all the appropriate places where edx-when's API
is called - to allow edx-when to more efficiently cache queried/processed results.

TNL-8061
2021-09-27 12:02:59 -04:00