Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: update unexpected_multiple_exceptions comment (#28939)

Browse Source 
Update the unexpected_multiple_exceptions comment based on findings
from monitoring since this was originally released.
This commit is contained in:
Robert Raposa
2021-10-05 14:08:22 -04:00
committed by GitHub
parent 849dd693cf
commit f3e5838b89
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
openedx/core/lib/request_utils.py
View File

@@ -476,8 +476,9 @@ def _log_and_monitor_expected_errors(request, exception, caller):
set_custom_attribute('checked_error_expected_from', 'multiple')
return
# Currently, it seems unexpected that middleware and drf will both handle different uncaught exceptions.
# We will monitor for this and adjust accordingly if it turns out this is a common case.
# We have confirmed using monitoring that it is very rare that middleware and drf handle different uncaught exceptions.
# We will leave this attribute in place, but it is not worth investing in a workaround, especially given that
# New Relic now offers its own expected error functionality, and this functionality may be simplified or removed.
set_custom_attribute('unexpected_multiple_exceptions', cached_module_and_class)
log.warning(
"Unexpected scenario where different exceptions are handled by _log_and_monitor_expected_errors. "