Commit Graph

58278 Commits

Author SHA1 Message Date
Azan Bin Zahid
5e466bc772 PROD-2314 2021-03-24 18:13:36 +05:00
Azan Bin Zahid
6ab28aab54 PROD-2302 2021-03-24 18:13:36 +05:00
Azan Bin Zahid
1e65f7c23b PROD-2303 2021-03-24 18:13:36 +05:00
Azan Bin Zahid
5c0fce308e PROD-2296 2021-03-24 18:13:36 +05:00
Usama Sadiq
3e6b3e41f8 refactor: remove unused imports (#27084) 2021-03-24 17:55:04 +05:00
Awais Jibran
49296005db Adding some minor changes to logs (#27127) 2021-03-24 17:25:04 +05:00
Sarina Canelake
e802614634 Merge pull request #27119 from edx/sarina/TNL-8138
fix: Add ‘ENABLE_HELP_LINK’ to Studio settings
2021-03-24 08:12:01 -04:00
Waheed Ahmed
e3406257fe Fix edxloggedin cookie not present issue.
If edxloggedin cookie is not present but the user is authenticated;
user is redirected to authn MFE and then back to dashboard instead
of the desired redirect URL (e.g. finish_auth) resulting in learners
not enrolling into the courses.

VAN-415
2021-03-24 16:26:31 +05:00
Azan Bin Zahid
b5e9c300f8 Merge pull request #27104 from edx/azan/PROD-2204
disbale xsslint
2021-03-24 13:00:25 +05:00
edX cache uploader bot
b2150cf52e Updating Bokchoy testing database cache (#27116) 2021-03-24 12:51:23 +05:00
edX requirements bot
ae2e41cd8e Updating Python Requirements (#27122) 2021-03-24 12:49:56 +05:00
jawad khan
186cc9f16c LEARNER-7858 (#26967)
Removed tabindex="-1" from main element to fix accessibility issue
Description

Removed tabindex="-1"  from main
We had a strange issue where TalkBack wasn’t reading content in some xBlocks but was reading some others. I figured out that if you remove tabindex=-1 from <main>, TalkBack works as expected again. Tangentially, this breaks the old method of implementing SkipNav links. Further tangentially, the SkipNav links were already broken (or in this case redundant on mobile). @wittjeff  will file two separate issues after this one PR is merged — one  for a better way to implement SkipNav links for  Learning MFE, and one for a better / functional way to implement SkipNav links for Mobile.

How to reproduce
Go to [this unit](https://courses.edx.org/xblock/block-v1:W3Cx+WAI0.1x+3T2019+type@html+block@2eb3c86c479f44ba964f88ff0bfd9211) on mobile and turn on TalkBack. It will skip main content. For further information on testing go to [Jira Ticket](https://openedx.atlassian.net/browse/LEARNER-7858)
2021-03-24 11:15:16 +05:00
Robert Raposa
650b0c1360 Merge pull request #27118 from regisb/regisb/fix-toggle-state-report-typeerror
[BD-21] fix: TypeError in toggle state report view
2021-03-23 17:32:30 -04:00
sarina
51ccf48f1c fix: Add ‘ENABLE_HELP_LINK’ to Studio settings
Fixes an issue where the button that linked to edX documentation for
course teams in Studio that displayed beside the logged-in user's username/
drop-down menu is gone. Regression from PR #26106

Ref: TNL-8138
2021-03-23 16:16:21 -04:00
Régis Behmo
dae4403ba7 fix: TypeError in toggle state report view
We were attempting to add course overrides twice to objects returned in
the toggle state report view. This was causing a TypeError (and thus a
500 error) because the second time, we were attempting to add entries to
an incorrect object.

This issue was not caught by unit tests because we were not testing the
view with WaffleFlagCourseOverride objects. This commit adds a unit test
to prevent future errors.

This is another fix for PR #27108.
2021-03-23 20:33:48 +01:00
Bianca Severino
1d2f891da2 Merge pull request #27117 from edx/bseverino/proctoring-3.7.14
Update edx-proctoring to 3.7.14
2021-03-23 15:28:23 -04:00
Bianca Severino
2db1c7b33f Update edx-proctoring to 3.7.14 2021-03-23 14:53:48 -04:00
Alex Dusenbery
9cb22de829 fix: upgrade edx-enterprise to 3.20.1 and edx-rbac to 1.4.2, so that JWT role/context pairs are de-duplicated.
ENT-4357
2021-03-23 14:45:11 -04:00
Lael Birch
d944bd37ee Merge pull request #27114 from edx/ENT-4333
Bump frontend-enterprise
2021-03-23 13:48:31 -04:00
David Joy
8c6a06cf5b fix: adjust discussions app APIs to match consuming frontend (#27085)
This commit adjusts a few values in our discussions configuration APIs to make them match what the frontend needs, as well as to more accurately reflect the providers available today.

- The `active` provider ID is expressed as None if it doesn’t exist
- The “cs_comments_service” provider has been renamed “legacy” - when we implement the new discussions micro-frontend, we’ll also have a separate provider for that, so they can’t both be “cs_comments_service”.  Also, cs_comments_service is such a bad name for anything.
- The hard-coded providers list in get_supported_providers now includes ‘legacy’ and ‘piazza’, our two known providers.  This list will be updated as more known providers come online.
- The PROVIDER_FEATURE_MAP has similarly been updated.

Part of this task: TNL-8093
2021-03-23 13:37:16 -04:00
stvn
a0003016b2 Merge PR #26750 colin-fredericks/jsinput-allow-downloads
* Commits:
  feat(jsinput): Allow JSInput problems to create downloads
2021-03-23 10:20:57 -07:00
edX requirements bot
6b8ff16a7f Updating Python Requirements (#27109) 2021-03-23 22:12:33 +05:00
Lael Birch
cf8237fb02 Bump frontend-enterprise 2021-03-23 12:02:08 -04:00
Raul Gallegos
130b9f7bb3 fix: contentstore next section navigation (#27112)
Fixes bug introduced by #25965 (commit dd96a2) pointed out in:

  https://github.com/edx/edx-platform/commit/dd96a2#r48570091

The next button redirect at the top of the sequence in Studio's Unit editing view
was not going to the correct location.
2021-03-23 11:49:33 -04:00
Jansen Kantor
23443c4376 Revert "fix: Stop rendering Visibility and Move buttons on libraries (#26885)" (#27113)
This reverts commit 777bb633c5.
2021-03-23 11:35:14 -04:00
Robert Raposa
cbc803cd15 feat!: remove old waffle classes (#27069)
BREAKING CHANGE: Remove WaffleSwitchNamespace, WaffleSwitch, WaffleFlagNamespace,
and WaffleFlag from waffle_utils, in favor of the Legecy* classes
in edx-toggles. Although this is a breaking change, we have
preemptively removed all known uses.

BD-21
2021-03-23 09:37:48 -04:00
Awais Jibran
0e4571a5e5 Do not monitor if asset file is not present (#27106) 2021-03-23 01:26:46 +05:00
Feanil Patel
c67c401f89 temp: remove false positives on safe sessions middleware (#27105)
* temp: remove false positives on safe sessions middleware

This is a temporary fix to deal with false positives in the system due
to the masquerading feature.  Long term we may not want to rely on
knowing about how masquerding works in the safe sessions middleware and
instead manage masquerding of the requset user in some other way.

Co-authored-by: Robert Raposa <rraposa@edx.org>
2021-03-22 14:44:52 -04:00
Simon Chen
4c5d56ef06 MST-682 Add external_user_key to the student profile CSV (#27091)
* MST-682 Add external_user_key to the student profile CSV
This is a request from some Masters school partners. They would like to download the student enrolled list with the Masters external_user_key data referenced. This way, the schools can properly match the students enrolled in the course with the students enrolled through Masters enrollment system
2021-03-22 14:25:34 -04:00
Daniel Francis
777bb633c5 fix: Stop rendering Visibility and Move buttons on libraries (#26885)
We're fixing an error that appears when you click the "edit access"
button on an XBlock in the library page.

Libraries in the "Add library" page shouldn't have the accessibility
config icon. Access settings for libraries are changed at the top, on
Settings > User Access. When clicking the access-button (the cog) on a
Library, an error appears. This is known to happen on koa.master and
open-release/juniper.3.

This happens due to the way XBlocks are rendered; as they get rendered
initially, the previews are unaware of whether they're part of a
library. We can confirm this by refreshing the page, this makes the
button disappear.

This fix removes the cogwheel when the XBlock is part of a library.
This doesn't affect the XBlocks imported to courses because those are
rendered on a Randomized Content XBlock, which does have its access
options.

Authored by: Daniel Francis <daniel.francis@opencraft.com>
2021-03-22 13:39:09 -04:00
Calen Pennington
91b74b7fd3 Merge pull request #23457 from open-craft/agrendalath/bb-2063-fix-marking-blocks-as-completed-on-course-outline-page-upstream
[BB-2063] Calculate completion for custom blocks on the Course Outline page
2021-03-22 13:33:18 -04:00
Azan Bin Zahid
ca6914c1f2 fix: move xss-lint disable comment to correct place 2021-03-22 21:20:26 +05:00
Agrendalath
e571693455 Support EXCLUDED blocks in Block Completion Transformer
For now only the discussion blocks were supported. If we had a custom XBlock that specified `completion_mode = XBlockCompletionMode.EXCLUDED`, then it could never be marked as completed on the course outline page, despite being marked as such inside the learning sequence.
2021-03-22 16:21:43 +01:00
Agrendalath
5a27b5df39 Calculate completion for custom blocks on the Course Outline page
This adds support for displaying completion on the course outline page, to remove the discrepancies between this view and the learning sequence. It also simplifies course outline page by reusing existing APIs for determining completion state and finding the "Resume block"'s target.
2021-03-22 16:21:32 +01:00
Ahtisham Shahid
da30f24108 Fixed Html escaping in course name in API (#27103)
* Fixed Html escaping in course name in API
2021-03-22 19:52:34 +05:00
Bianca Severino
ed63ffbb50 Merge pull request #27086 from edx/bseverino/proctoring-escalation-email
Allow `get_proctoring_escalation_email` to use a course key object
2021-03-22 10:12:45 -04:00
Christie Rice
43f32a8f6b feat: Add initial certificate generation checks for updated (V2) course certificates (#27090)
MICROBA-923
2021-03-22 10:07:21 -04:00
Robert Raposa
f9c11f061f Merge pull request #27059 from open-craft/nizar/update_block_structure_toggles_annotations
docs: updates ticket links for block structure settings and toggles
2021-03-22 09:29:48 -04:00
M. Zulqarnain
40a987d9d0 refactor: pyupgrade on LMS (#26851) 2021-03-22 17:51:23 +05:00
M. Zulqarnain
91d33611b1 refactor: pyupgrade in profile_images, programs, safe_sessions (#26953) 2021-03-22 17:51:13 +05:00
Robert Raposa
1c19fbf3b3 Merge pull request #26325 from regisb/regisb/migrate-toggle-state-report
[BD-21] Migrate toggle state report to edx-toggles
2021-03-22 08:27:49 -04:00
Awais Qureshi
c43cdd0cee Merge pull request #27100 from edx/revert-27097-revert-27087-fixing-toggles
Revert "Revert "temp: Apply pylint amnesy ( Type annotation-invalid-choice )""
2021-03-22 17:26:23 +05:00
Awais Jibran
2ec17309d0 Code Refactor (#27101) 2021-03-22 16:07:06 +05:00
Awais Jibran
5f773d326d Add missing import logs. (#27066) 2021-03-22 15:28:13 +05:00
Awais Qureshi
23bcd6f05d revert: Reverts #27097
#27097 reverted the pylint amnesty change. After reverting the ubuntu20 deployment, now this can be deployed again.
2021-03-22 15:17:22 +05:00
edX requirements bot
41c1d237eb Python Requirements Update (#27094)
* Updating Python Requirements

* fix proctoring test

Co-authored-by: Zulqarnain <muhammad.zulqarnain@arbisoft.com>
2021-03-22 15:15:46 +05:00
Nadeem Shahzad
44897fe4b8 Merge pull request #27097 from edx/revert-27087-fixing-toggles
Revert "temp: Apply pylint amnesy ( Type annotation-invalid-choice )"
2021-03-22 13:08:45 +05:00
Awais Qureshi
20c39b267e Revert "temp: Apply pylint amnesy ( Type annotation-invalid-choice )" 2021-03-22 12:47:43 +05:00
Awais Qureshi
60cd0c1295 Merge pull request #27087 from edx/fixing-toggles
temp: Apply pylint amnesy ( Type annotation-invalid-choice )
2021-03-22 11:19:50 +05:00
Sofiane Bébert
5d7cd3d278 docs: annotate auto_certificate_generation (#26770) 2021-03-19 16:01:55 -04:00