Commit Graph

58708 Commits

Author SHA1 Message Date
Usama Sadiq
3ff951940d refactor: pyupgrade second iteration 2021-05-03 14:55:37 +05:00
Shafqat Farhan
7c391f4c7e Merge pull request #27484 from edx/shafqat/VAN-437
[VAN-437] - Unlocking the learners upon successful password reset
2021-05-03 12:06:06 +05:00
stvn
9f1debac14 Merge PR #27343 bd03/api/legacy
* Commits:
  docs: Remove completed TODO discussions item
  feat: Add support to Discussions API for legacy cohort settings
  refactor: Remove get_course_discussion_settings helper
  refactor: Remove set_course_discussion_settings helper
  refactor: Add better DRF support to legacy discussions settings
2021-04-30 12:33:13 -07:00
Matt Tuchfarber
39bca7bba4 Merge pull request #27433 from edx/tuchfarber/fix_facebook_share
fix: Add callback function to Facebook share
2021-04-30 15:15:30 -04:00
stvn
718458115a docs: Remove completed TODO discussions item 2021-04-30 11:47:34 -07:00
stvn
e62705a365 feat: Add support to Discussions API for legacy cohort settings 2021-04-30 11:47:34 -07:00
stvn
1b76999c2f refactor: Remove get_course_discussion_settings helper 2021-04-30 11:47:34 -07:00
stvn
146887df1b refactor: Remove set_course_discussion_settings helper 2021-04-30 10:54:59 -07:00
stvn
6156064492 refactor: Add better DRF support to legacy discussions settings
so that we can re-use the existing serializer as a portability-shim in
the new API.
2021-04-30 10:54:55 -07:00
Matt Tuchfarber
b3e76dc151 fix: Facebook share button on course certificates.
Facebook requires a callback when using the `.ui()` method now. I don't
know when this changed, but the share button is currently broken on
course certificates.

Facebook documentation of the `.ui()` method:
https://developers.facebook.com/docs/javascript/reference/FB.ui/
2021-04-30 13:34:58 -04:00
Syed Muhammad Dawoud Sheraz Ali
0eb209d049 Merge pull request #27483 from edx/dsheraz/PROD-2334
feat: add pacing info in course enrollment serializer
2021-04-30 21:53:15 +05:00
DawoudSheraz
573d34c593 feat: add pacing info in course enrollment serializer 2021-04-30 19:45:47 +05:00
Shafqat Farhan
30bf95b053 VAN-437 - Unlocking the learners upon successful password reset 2021-04-30 18:36:21 +05:00
Usama Sadiq
f74d7c9ea7 refactor: pyupgrade second iteration 2021-04-30 15:35:47 +05:00
edX requirements bot
fe37651d15 Updating Python Requirements (#27481) 2021-04-30 11:59:02 +05:00
David Ormsbee
2c77ac6bcb fix: don't bubble up empty partition groups from units.
In dfb80acc1, we allowed group_access settings to bubble up from
Units to Sequences in the case where all Units had the same group
settings for a particular user partition. This caused an issue
where the group being bubbled up could be empty if the Unit was
misconfigured in OLX (this is already caught if done directly on
the Sequence). This commit fixes things so that empty partition
group settings never bubble up.

We don't want empty partition groups to bubble up because it would
mean that no groups are allowed to access the Sequence, which is
probably an error. (There is a separate visible_to_staff_only flag
when you want to hide content from all non-staff users.)
2021-04-29 18:16:09 -04:00
David Ormsbee
3e673f59b3 perf: Remove Modulestore call from Credit Service.
We can get the same information much more cheaply and predictably
by using CourseOverviews. This was contributing to slow traces for
the edx_proctoring.views:StudentOnboardingStatusView.get
transaction.
2021-04-29 10:43:47 -04:00
Dillon Dumesnil
874242a1d4 Merge pull request #27456 from edx/ddumesnil/update-enrollment-activated-segment-aa-775
feat: AA-775: add course start and pacing to enrollment.activated segment event
2021-04-29 06:57:14 -07:00
Tim McCormack
c8b87560c7 doc: Describe how to upgrade a single dependency (#27471) 2021-04-29 13:45:08 +00:00
edX requirements bot
3c0cfd87a3 Updating Python Requirements (#27474) 2021-04-29 13:02:02 +05:00
edX cache uploader bot
94818924a5 Updating Bokchoy testing database cache 2021-04-29 12:08:51 +05:00
edX Transifex Bot
7d6edbe41d geoip2: update maxmind geolite country database 2021-04-29 02:11:21 +05:00
Justin Hynes
5db0b9f7c7 Merge pull request #27464 from edx/jhynes/microba-1181_fix
fix: fix issue where we were not generating a certificate `verify_uuid` when needed
2021-04-28 13:47:56 -04:00
David Ormsbee
dfb80acc11 feat: Enrollment Tracks OutlineProcessor (MST-685)
NOTE: This will require a forced backfill of course outlines to update
the course content data in learning_sequences:

  python manage.py cms backfill_course_outlines --force

Without this backfill, the learning_sequences API will continue to serve
stale content data that has no user partition group data. It won't cause
errors, but it won't do the exclusions properly.

Commit summary:

* Created EnrollmentTrackPartitionGroupsOutlineProcessor to process the
  enrollment_track User Partition Group, allowing Sequences and Sections
  to be removed based on their group_access settings.
* Added user_partition_groups attribute to CourseLearningSequenceData
  and CourseSectionData in learning_sequences/data.py, along with
  backing model data.
* get_outline_from_modulestore now extracts group_access settings from
  Sections and Sequences. It also bubbles up group_access settings from
  Units, meaning that if a Sequence with no group_access setting has
  Units that are all set to show only to the Verified enrollment track,
  then the Sequence will only show to the Verified enrollment track.

This commit adds model-level support for all user partition groups by
capturing all the content group associations (group_access), but it only
implements the code checks for the enrollment track partition. It's not
clear that we want to generalize, since there's only one other partition
type (A/B testing) that is applicable at the outline level.

It's important to note that there is no way to set the group_access for
a Section or Sequence in Studio today. It's only possible by direct
editing of the OLX for import. That being said, the block structures
framework supports applying course groups at this level, and this commit
moves learning_sequences closer to feature parity.

The bubbling up from Units to the parent Sequence was done to mitigate
confusion when a Sequence is entirely composed of Units that are not
visible to the user because of content group restrictions. It's not
clear whether this is something we want to do in the long term, since it
would simplify the code to always specify group_access at the Sequence
level. This first pass is done partially to collect better data about
places in our courses where this kind of usage is already happening.

Most of the EnrollmentTrackPartitionGroupsOutlineProcessor code and its
tests were written by @schenedx.
2021-04-28 12:58:59 -04:00
Justin Hynes
5fe4e5c50b fix: fix issue where we were not generating a certificate verify_uuid when needed
[MICROBA-1181]
- change how we determine if we need to generate a verify_uuid for a learner's certificate record
2021-04-28 11:46:19 -04:00
Dillon Dumesnil
1f58bbe522 feat: AA-775: add course start and pacing to enrollment.activated segment event 2021-04-28 11:29:22 -04:00
Nathan Sprenkle
3ce04b7983 docs: update grades docs (#27341)
* docs: fix formatting inconsistencies in grade data model docs

* docs: add subsection grade override model

* docs: add gradebbook info to grades / background

* docs: fix formatting issues in grades / background
2021-04-28 11:22:13 -04:00
Kyle McCormick
3fbaf72601 fix: only show 'View in New Exp.' to global staff if MFE preview enabled (#27399)
Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting
was removed, the "View in New Experience" button began
to always appear in Legacy courseware for global staff
members in *all* environments.

This was OK for edx.org's purposes, since the Learning MFE
is deployed in all of our production environments.
However, many (perhaps most) Lilac Open edX instances will
*not* deploy the Learning MFE. So, we need to make sure that
this button is not shown by default.

Since we cannot programmatically tell from LMS whether
or not the Learning MFE is deployed, we will depend on
the value of the `courseware.microfrontend_course_team_preview`
flag, which is already being used to decide whether
course staff can see the "View in New Experience" button.

Whether or not the button is shown, global staff will
still be permitted to browse courses in the Learning
MFE if it is deployed.

https://github.com/openedx/build-test-release-wg/issues/49
2021-04-28 09:17:18 -04:00
Zachary Hancock
206501cb49 update edx-proctoring-proctortrack (#27436) 2021-04-28 08:55:26 -04:00
Christie Rice
44ed703d41 fix: Allow allow_certificate field to be null in preparation for removing it (#27432)
DEPR-140 MICROBA-985
2021-04-28 08:50:18 -04:00
edX cache uploader bot
af59696087 Updating Bokchoy testing database cache (#27445) 2021-04-28 17:36:15 +05:00
Justin Hynes
a2c7de459a Merge pull request #27434 from edx/jhynes/microba-1139_cert-error-cleanup
fix: Clean up old errors from certificate records now in `downloadable` status
2021-04-28 07:37:16 -04:00
Matthew Piatetsky
3fdb92f3f1 Merge pull request #27323 from edx/AA-719
[AA-721] Add necessary data for new progress page
2021-04-28 07:16:26 -04:00
edX requirements bot
fcd5ed5b40 Updating Python Requirements (#27437) 2021-04-28 11:49:25 +05:00
stvn
9b84869a9a Merge PR #27282 bd03/api/post-legacy
* Commits:
  feat: Add support for legacy discussions settings to API
  test: Add CourseFactory to discussions API tests
2021-04-27 13:47:07 -07:00
Justin Hynes
563b48c50c [MICROBA-1139]
* Change order of object Manager declarations in the GeneratedCertificate model. Declaration order matters and It appears that having the "base" `objects` declaration after the other Custom Managers creates an issue where I cannot access `objects` in a migration without this change.
* As part of the manager migration there is a cleanup function that resets the `error_reason` field to an empty string for all certificates in the `downloadable` state that currently have an error listed in the record.
2021-04-27 15:55:51 -04:00
stvn
eaeec735a9 feat: Add support for legacy discussions settings to API 2021-04-27 12:50:53 -07:00
stvn
4776ab1504 test: Add CourseFactory to discussions API tests 2021-04-27 12:37:29 -07:00
Olivia Ruiz-Knott
d7a4947ea9 Merge pull request #27322 from edx/ork/MICROBA-963_move-notify-credentials-to-celery-task
perf: move notify_credentials to a celery task
2021-04-27 09:47:03 -06:00
Binod Pant
735d01283e ENT-4383 fix the hinted login page experience when enterprise login enables hinted login (#27431)
* fix: 🐛 Correctly check that saml provider is available using tpa_hint in next param

This fixes the issue of 404 when an enterprise customer sends a tpa_hint in next, but that param is not correctly checked to disable auth MFE. The hinted login page now works with this change.

ENT-4383

* feat: comment update

comment update

ENT-4383
2021-04-27 11:33:00 -04:00
stvn
39ffd01c12 Merge PR #27371 bd03/api/change-provider/lti
* Commits:
  feat: Hide lti_configuration from non-LTI discussions providers
  fix: Update discussions lti_configuration during provider_type change
  feat: Add helper for discussions configuration to indicate feature support
  refactor: Remove superfluous dict comprehension
2021-04-27 08:21:57 -07:00
Zachary Hancock
25efc6ef30 update edx-proctoring to 3.8.8 (#27421) 2021-04-27 11:04:26 -04:00
Christie Rice
a6d9275cde fix: Ignore passing signal if the cert status is already downloadable (#27403)
MICROBA-1106
2021-04-27 10:24:30 -04:00
Matt Hughes
637405aecf [fix]: studio display of ungraded subs.s w/useless due dates
By "useless" due dates I'm specifically talking about due dates which
are erroneously set in the course strucutre, but which don't matter
because the entire course is self-paced, rather than instructor-paced.

JIRA:EDUCATOR-5713
2021-04-27 10:02:07 -04:00
Christie Rice
6e1f700cdc feat: Generate more certificate status for V2 course certs (#27326)
MICROBA-1106
2021-04-27 09:40:06 -04:00
Hammad Ahmad Waqas
7a3b53afec Merge pull request #27430 from edx/hammad/ENT-4483
Updated account view to accept application/json for the post request.
2021-04-27 17:37:48 +05:00
Awais Qureshi
5e1449640d Merge pull request #27428 from edx/remove-con-Sphinx--
refactor: removing Sphinx constraint.
2021-04-27 16:50:44 +05:00
HammadAhmadWaqas
149e448e5b Updated account view to accept application/json for the post request. 2021-04-27 16:47:57 +05:00
Awais Qureshi
a54d5f59be Merge pull request #27429 from edx/jenkins/upgrade-python-requirements-79d93a2
Python Requirements Update
2021-04-27 15:57:07 +05:00
edX requirements bot
6bef014dc2 chore: Updating Python Requirements 2021-04-27 06:55:08 -04:00