Commit Graph

121 Commits

Author SHA1 Message Date
Awais Jibran
92b99c7dc3 Fix discussion user roles 2016-11-10 17:11:52 +05:00
alisan617
e80d9b5792 Refactor discussion tab UI code into parts to be reusable for inline discussions
TNL-5669
2016-11-08 14:17:01 -05:00
Toby Lawrence
2acb4a6cad [PERF-386] Utilize ForumsConfig to enable and disable forums.
This specifically enables/disables the underlying comment service client
used to make calls to the service.  When disabled, this client will now
throw an exception which can be propagated upwards so that callers can
make the right decision about how to notify users of the error, or
handle retry, etc etc.
2016-11-03 10:20:19 -04:00
cahrens
827f91a9f9 Remove unnecessary ignores in a11y tests.
Also update JIRA tickets.
2016-10-25 13:38:55 -04:00
Toby Lawrence
6704e17afd [TNL-5632] Optimize the single_thread view.
Firstly, we're now explicitly instructing the comments service to not
return thread responses/comments if the request isn't AJAX.  So, if you
load the URL for a single discussion thread in your browser, this would
be a non-AJAX call and we'll avoid loading the responses for the entire
thread behind-the-scenes.  Big win here for large threads.

Next, we removed a redundant "get threads" call which was also happening
behind-the-scenes.  This call was redundant as the front-end JS also
grabs the thread list when a topic is chosen, so we were making an
extranenous call for no benefit.  Poof, gone!

Finally, we added some caching of database queries that are required to
drive a lot of the permissions/cohorts machinery around discussion.
This will have a minimal effect but introduced a cleaner way to apply
general memoization at the per-request level which will let us further
cache things as we identify them as issues.
2016-10-18 13:11:30 -04:00
alisan617
d5635cf1ba New inline discussion home view UI
TNL-4756
2016-10-14 10:54:50 -04:00
Nimisha Asthagiri
14d8a46d8c Merge pull request #13739 from edx/flaky/cohort-test
Fix flaky bokchoy test: test_automatic_cohort_help, test_manual_cohort_help
2016-10-13 11:36:37 -04:00
Nimisha Asthagiri
9f1d4cbf6f Fix flaky test_automatic_cohort_help bokchoy test
TNL-5709
2016-10-13 03:58:01 -04:00
Noraiz Anwar
34ab38d729 Fix mathjax rendering
TNL-5451
2016-10-06 12:30:46 +05:00
alisan617
0ffeb4639b Make the left sidebar in Discussion page accessible
TNL-5169
2016-09-22 15:28:29 -04:00
Mushtaq Ali
a1945c18d1 Remove icon-aria-hidden rule for a11y discussions
TNL-4637 TNL-4641 TNL-4645
2016-09-19 12:30:20 +05:00
Brian Jacobel
c28fc04b78 Commenting out color-contrast tests for DiscussionOpenClosedThreadTest because of Jenkins issues 2016-09-16 13:11:21 -04:00
Brian Jacobel
a229e1f028 Fix DiscussionHomePageTest color-contrast issues - TNL-4635 2016-09-16 13:11:21 -04:00
Brian Jacobel
a19274c84f Fix DiscussionOpenClosedThreadTest color-contrast issues - TNL-4644 2016-09-16 13:11:20 -04:00
Brian Jacobel
ad1aa2b35f Fix DiscussionTabMultipleThreadTest color-contrast issues - TNL-4639 2016-09-16 13:11:20 -04:00
Mushtaq Ali
3c16225496 Merge pull request #13411 from edx/mushtaq/a11y-discussions-duplicate-id
Remove duplicate-id rule for a11y discussions
2016-09-08 18:33:13 +05:00
Brian Jacobel
49f99146ec Merge pull request #13417 from edx/bjacobel/flaky-5453
Mark DiscussionResponseEditTest.test_vote_report_endorse_after_edit as flaky
2016-09-07 14:04:46 -04:00
Brian Jacobel
d148868b57 Mark DiscussionResponseEditTest.test_vote_report_endorse_after_edit as flaky 2016-09-07 11:24:47 -04:00
Mushtaq Ali
e1247ba1e1 Remove duplicate-id rule for a11y discussions
TNL-4647
2016-09-07 13:20:13 +05:00
Mushtaq Ali
bcab8101cb Ensure correct aria-valid-attr-value for discussions 2016-09-06 15:58:39 +05:00
Andy Armstrong
f1bad0721f Make discussion links into buttons for a11y
TNL-4640
2016-09-02 16:34:15 -04:00
Awais Jibran
68303997c8 Fix Discussion blackout date still has Add a Response text box
TNL-5111
2016-08-24 12:03:29 +05:00
Chris Rodriguez
b5efcc15f5 AC-530 fixing link-href ignores in the platform 2016-08-19 10:04:40 -04:00
Brian Jacobel
df35415ec1 Remove forum-nav-header and wire breadcrumbs to replace it
TNL-5186
2016-08-17 16:21:13 -04:00
Brian Jacobel
1f2c843f23 Move search box to header. Add search results to breadcrumbs when you search 2016-08-17 16:21:12 -04:00
Brian Jacobel
a60d456f28 Add breadcrumbs to discussion forums header 2016-08-17 16:21:12 -04:00
Andy Armstrong
89f93df46e Refactor out a new discussions Django app 2016-08-17 16:20:45 -04:00
Diana Huang
8ca5739f0f Open the topic list by default. 2016-08-17 16:20:43 -04:00
Brian Jacobel
71a048a631 Add bok choy tests for discussions editor preview pane 2016-08-12 10:24:21 -04:00
Calen Pennington
bc20a37c2b Simplify how shards are selected in CI 2016-08-03 16:23:02 -04:00
Ned Batchelder
8571ceabeb Fix many wrong-assert-type errors 2016-08-03 12:44:41 -04:00
Ned Batchelder
eef964f5f6 Fix unused-variable errors 2016-08-03 12:44:41 -04:00
Shauna Gordon-McKeon
f8d28889b9 Remove unused imports, move too-long imports to multiple lines 2016-07-28 16:35:40 -04:00
Shauna Gordon-McKeon
29bb5b50e9 Switch relative to absolute urls in imports (video, discussion, misc) 2016-07-28 16:35:40 -04:00
raeeschachar
e8d32c839d Skipped test failing on chrome due to old version 2016-07-26 11:49:18 +00:00
E. Kolpakov
33b3dfcc92 Converts Discussion XModule to Discussion XBlock
* Renames discussion_module to discussion_xblock
* Moves common/lib/xmodule/xmodule_discussion to openedx/core/lib/xblock_builtin/xblock_discussion
2016-06-29 06:47:04 +12:00
raeeschachar
c07cb1905c Fixed test default sort preference failing on chrome 2016-06-24 01:46:14 +05:00
Brian Jacobel
b6cf9d231f Disallow reporting and upvoting of your own posts in discussion forums 2016-06-15 12:01:23 -04:00
Chris Rodriguez
257903fe15 AC-414 adding headings as first child to sections 2016-06-10 12:30:03 -04:00
Chris Rodriguez
6be4f84aff Using latest version from NPM and ignoring section tests for now 2016-06-06 13:10:51 -04:00
Calen Pennington
80fdc5212c Merge pull request #12580 from edx/zoldak/TNL-4682
Mark tests as flaky  TNL-4682
2016-06-02 16:27:08 -04:00
Andy Armstrong
7e2a174eec Move discussion board to the Pattern Library
TNL-4622
2016-06-02 12:48:12 -04:00
Jesse Zoldak
86408e795c Mark tests as flaky TNL-4682 2016-05-27 15:33:51 -04:00
Diana Huang
cbe9142996 Add a11y tags on accessibility tests. 2016-05-25 10:59:24 -04:00
Diana Huang
677403192b Add accessibility tests for discussion forums. 2016-05-25 09:26:35 -04:00
wajeeha-khalid
5b5fb2464d TNL-3818: fixed recent activity mapping in thread-list sort for Forums Web 2016-04-13 17:47:31 +05:00
Eric Fischer
c46e5c1cb0 Fix flaky discussion tests
Ajax callbacks are used in a lot of places in discussions; our tests
need to wait for those callbacks to finish in several places.
2016-03-14 10:27:15 -04:00
Ben Patterson
de45c0d36d Flag test as flaky. See TNL-4151. 2016-02-23 08:20:06 -05:00
cahrens
d8a63fbd93 Remove flaky decorator from test_cancel_comment_edit.
Test passed over 100 times in Jenkins.
TNL-4057
2016-02-05 21:22:39 -05:00
Christine Lytwynec
8c8953fe32 Update discussion markdown editor add link and image modals 2016-01-27 14:43:29 -05:00