Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove duplicate-id rule for a11y discussions

Browse Source 
TNL-4647
This commit is contained in:
Mushtaq Ali
2016-09-07 13:20:13 +05:00
parent 3499b257c7
commit e1247ba1e1
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/static/common/templates/discussion/thread-response.underscore
View File

@@ -11,8 +11,8 @@
<% if (create_sub_comment && !readOnly) { %>
<form class="comment-form" data-id="<%- wmdId %>">
<ul class="discussion-errors"></ul>
<label class="sr" for="add-new-comment"><%- gettext("Add a comment") %></label>
<div class="comment-body" id="add-new-comment" data-id="<%- wmdId %>"
<label class="sr" for="add-new-comment-<%- wmdId %>"><%- gettext("Add a comment") %></label>
<div class="comment-body" id="add-new-comment-<%- wmdId %>" data-id="<%- wmdId %>"
data-placeholder="<%- gettext('Add a comment') %>"></div>
<div class="comment-post-control">
<button class="btn-brand discussion-submit-comment control-button"><%- gettext("Submit") %></button>

1
common/test/acceptance/tests/discussion/test_discussion.py
View File

@@ -827,7 +827,6 @@ class DiscussionResponseEditTest(BaseDiscussionTestCase):
'section', # TODO: AC-491
'color-contrast', # TNL-4644
'icon-aria-hidden', # TNL-4645
'duplicate-id', # TNL-4647
]
})
page.visit()