Commit Graph

58424 Commits

Author SHA1 Message Date
Zaman Afzal
3bcfe511b3 update edx-enterprise version (#27259) 2021-04-06 20:02:12 +05:00
Justin Hynes
eda12d8cf8 Merge pull request #27246 from edx/jhynes/microba-1109_update_checks
fix: update v2 certificate generation eligibility logic
2021-04-06 10:14:40 -04:00
Azan Bin Zahid
7c3f22a0a2 Merge pull request #27257 from edx/IM/security-fixes-10-thresholds
chore: update thresholds after IM security fixes 10
2021-04-06 18:23:56 +05:00
Justin Hynes
13d174fdda fix: update v2 certificate generation eligibility logic
[MICROBA-1109]
* Remove the requirement for the `auto_certificate_generation` waffle switch to be enabled in order for a learner to be eligible for a certificate. This switch should control _when_ a certificate is generated, not _if_ a certificate will be generated for a learner.
* Move the `auto_certificate_generation_enabled` check to happen before we try to generate v2 certificates in signals.py
* Update unit tests
* Update documentation
2021-04-06 08:50:54 -04:00
Sarina Canelake
6e71251f57 Merge pull request #27209 from raccoongang/ideg/fix_language_preferences_change
fix: Language preferences change enhancement.
2021-04-06 08:09:40 -04:00
Jawayria
106b22ea70 Merge pull request #27182 from edx/jawayria/bom-2462-commit-msg
build: updating commit message
2021-04-06 17:03:45 +05:00
Azan Bin Zahid
705253e20a chore: update thresholds after IM security fixes 10 2021-04-06 15:40:04 +05:00
edX requirements bot
401789dad3 Updating Python Requirements (#27251) 2021-04-06 13:03:24 +05:00
Usama Sadiq
91ea53da56 refactor: Ran pyupgrade on openedx/core/djangoapps/user_api 2021-04-06 12:50:48 +05:00
Usama Sadiq
c14eab1332 refactor: Ran pyupgrade on openedx/core/djangoapps/site_configuration 2021-04-06 12:50:34 +05:00
Usama Sadiq
ebcf204d60 refactor: ran pyupgrade on openedx/core/djangoapps
ran pyupgrade on openedx/core/djangoapps/{schedules, self_paced, service_status}
2021-04-06 12:50:11 +05:00
edX cache uploader bot
9106174b5a Updating Bokchoy testing database cache 2021-04-06 12:19:47 +05:00
Simon Chen
1d186b34bf MST-734 Fix production issue on Learner Onboarding Status Panel (#27248)
* MST-734 Fix production issue on Learner Onboarding Status Panel
Fix the prod issue where learning sequence service object missing the needed get_user_course_outline service API
The user web API call currently returns 500
2021-04-05 16:54:58 -04:00
stvn
716b84d9df Merge PR #27202 fix/capa/empty-option-text
* Commits:
  fix: Allow capa_problem optioninput option with empty text
  refactor: Refactor capa_problem optioninput option text handling
2021-04-05 13:27:22 -07:00
Simon Chen
151efd2cb6 Add edx-proctoring=3.8.2 to edx-platform constraint file to prevent others from upgrading it to 3.8.3 accidentally (#27249) 2021-04-05 15:57:22 -04:00
Simon Chen
5e79e198ac [Revert] The edx-proctoring version 3.8.3 resulted in 500 error on Onboarding Status Panel API call (#27247) 2021-04-05 15:09:42 -04:00
Christie Rice
1181fb343e feat!: Remove allow_certificate checks from course certificates (#27206)
DEPR-140 MICROBA-985
2021-04-05 14:00:07 -04:00
Simon Chen
9d7bd99f8d MST-734 Use exam due dates to test onboarding status visibility (#27243)
The version of proctoring 3.8.3 uses the onboarding exam due dates or course end dates as the testing date for learning sequence service to test the visibility of the onboarding status panel for learners. This change would allow onboarding exam with due dates to display to course enrollees correctly
2021-04-05 13:08:07 -04:00
Robert Raposa
96be45f1bd Merge pull request #27222 from edx/robrap/ARCHBOM-1721-toggle-doc-cleanup
ARCHBOM-1721: docs: update toggle docs
2021-04-05 10:47:55 -04:00
alangsto
4640280daa fix: Update expiration timeline on dashboard and specify ID verification (#27199)
MST-706. ID Verification is now valid for 2 years, so messaging used to notify learners about their ID expiration should be updated to reflect this. We have chosen to only update the messaging that is related to the current IDV flow (going through IDV on the account MFE), as the old IDV flow is no longer used by learners on edX.
2021-04-05 10:18:54 -04:00
Justin Hynes
85af4e81ec Merge pull request #27216 from edx/jhynes/microba-1100-remove-allowlist-mgmt-cmd
chore: remove `cert_allowlist_generation` management command
2021-04-05 08:06:59 -04:00
Awais Jibran
bc8e21d340 Address comments in the doc (#27240) 2021-04-05 17:06:36 +05:00
edX requirements bot
a86b474931 Updating Python Requirements (#27237) 2021-04-05 13:17:30 +05:00
Ali Akbar
4b954855cb Merge pull request #27229 from edx/aakbar/PROD-2327
refactor: update contact us form
2021-04-05 13:13:32 +05:00
stvn
21dce731f9 fix: Allow capa_problem optioninput option with empty text
This fixes TNL-7973 [1].

Background
----------

> An alert was sent out because a malformed capa problem caused block
> transformers to fail to run.

> This specific error/alert was triggered when an optionresponse problem
> lacked text. The authoring-based fix is to edit the offending
> option-response problem to remove the empty option.

> Expected behavior: We should be able to keep the error local to the
> ProblemBlock and not blow up the whole course publish block
> transformer collection process.

> This is a really easy error for authors to make, and the consequences
> to them (one problem doesn’t work) are disproportionate to the
> consequences [...] (alerting triggered).

- [1] https://openedx.atlassian.net/browse/TNL-7973
2021-04-02 14:36:20 -07:00
Feanil Patel
9f4a8e6724 Merge pull request #27233 from edx/feanil/flag_management
feat!: Replace logging WaffleSwitch with a django settinge.
2021-04-02 15:12:11 -04:00
Feanil Patel
ba4d98898e Merge pull request #27231 from edx/feanil/more_safe_sessions_updates
fix: Reduce safe-sessions false alarms.
2021-04-02 14:45:22 -04:00
Feanil Patel
8e7144ae2e revert: "test: Update query counts."
This reverts commit c2eabf6cca.

We are changing this from a waffle setting to a django setting so we can
undo this query count bump.
2021-04-02 14:42:55 -04:00
Feanil Patel
455033458c feat!: Replace logging WaffleSwitch with a django settinge.
This was initially introduced as a temporary flag to be able to get more
information.  But if we get this kind of issue again, we'll need
something like this logging to determine the source of the session
collision.  Rather than removing the code and adding it back in later,
convert this temporary switch into an opt-in setting that can be used
again in the future.

BREAKING_CHANGE: 'safe_session.log_request_user_changes' switch no
longer exists and is replaced with the 'LOG_REQUEST_USER_CHANGES' django
setting which defaults to 'False'
2021-04-02 14:20:07 -04:00
Feanil Patel
4f725aa152 test: Add a test for setup_masquerade.
Test to verify the side-effects of calling this function since we now
rely on one of them in the SafeSessionMiddleware.
2021-04-02 14:19:10 -04:00
Feanil Patel
c45ffd7509 test: Test login redirects prefer session cookies.
Add a test to ensure that the login page redirect as long as we have a
valid session even if we have expired on non-existent JWT cookies.
2021-04-02 14:19:10 -04:00
Feanil Patel
118f095110 fix: Assume logged in if user has a valid session.
Previously they also had to have a valid JWT cookie which led to a weird
corner case where a user was logged in but still showed the login form
resulting in some confusion and odd behavior.

This change gives precedence to the session token to determine whether
or not someone is logged into the LMS but ensures that if you go through
the login flow, you refresh your JWT cookies. This should not cause any
breakage for MFE flows that might redirect to the LMS login page since
the JWT would get refreshed if it's out of date but the session is
valid.
2021-04-02 14:19:10 -04:00
Feanil Patel
23f2b758d4 fix: Print more stack frames on requset tracing.
Six frames was not enough because for DRF views the request gets wrapped
in a proxy object and so we need more of the stack to see what part of
the code we're in that actually invokes the use change.
2021-04-02 14:19:07 -04:00
David Ormsbee
d2389fb7fb fix: Don't break export when transcript is Latin-1 encoded.
Video SJSON transcripts are supposed to be UTF-8 encoded, but SJSON
is an ad hoc thing we made up to make it easier to build the
transcripts viewer in the VideoBlock, and it's not well specified.
Prior to this commit, if you had an SJSON file with Latin-1 encoded
text outside the standard ASCII range (e.g. û), then we'd error out
while trying to export it.

This was blocking an effort to export some Old Mongo courses (TNL-8007).
2021-04-02 13:33:16 -04:00
Awais Jibran
2641336fc1 Update error message (#27232) 2021-04-02 22:05:59 +05:00
Michael Terry
b897bd4b44 Merge pull request #27230 from edx/mikix/video-completion-typo
fix: fix typo that prevented video completion working as intended
2021-04-02 12:30:51 -04:00
Asad Iqbal
82c90b40b0 Added setting to manage from_email address (#24951)
Co-authored-by: asadiqbal08 <asad.iqbal@arbisoft.com>
2021-04-02 12:08:51 -04:00
Michael Terry
5169d70b14 fix: fix typo that prevented video completion working as intended
Neither of these settings were being correctly set:
* COMPLETION_BY_VIEWING_DELAY_MS
* COMPLETION_VIDEO_COMPLETE_PERCENTAGE

AA-743
2021-04-02 11:50:19 -04:00
Bianca Severino
3712e0ee2e Merge pull request #27205 from edx/bseverino/idv-validate-image-data
[MST-718] Validate the media type of uploaded IDV images
2021-04-02 11:38:47 -04:00
Nathan Sprenkle
c97932fa99 fix: add missing protocol to web link for assets (#27220)
* fix: add missing protocol to web link for assets

* test: fix asset path test

* refactor: update asset web URL to use urljoin
2021-04-02 11:13:57 -04:00
Bianca Severino
4fc5713792 fix: validate the media type of uploaded IDV images 2021-04-02 10:49:08 -04:00
Jawayria
de2a28bd82 Merge pull request #26598 from edx/jawayria/bom-2408-1
BOM-2408: Removed unused imports from openedx/core/djangoapps/{api_ad…
2021-04-02 19:38:00 +05:00
Jawayria
b899e6bced Merge pull request #26595 from edx/bom-2352-10
BOM-2352: Removed unused imports from lms/envs
2021-04-02 19:37:46 +05:00
Ben Holt
ec3c31eb05 feat: added another 'Date' expose-headers for outline api clients (#27221)
Exposed the Date header on the outline api so clients can accurately compute times relative to the dates returned by the API; this was previously done with the course API (#26979)

Browser time is notoriously unreliable for this, especially for a Learner-facing countdown call-to-action based on the access expiration date. (REV-2126)

Using the Date header for this allows the client to make use of information that is already sent, does not require additional calls nor modifying the API, and could be generalized to more or all our APIs without modifying them.
2021-04-02 10:37:19 -04:00
AsadAzam
c4da6c1fe4 Display import errors to user (#27147)
* Display import errors to user

* Refactored

* Refactored

* Refactored

* Fixed quality

* Fixed quality

* Refactored code

* Fixed message

* Refactored code
2021-04-02 18:53:39 +05:00
Jawayria
42e7576500 refactor: Removed unused imports
Removed unused imports from lms/envs
2021-04-02 18:30:19 +05:00
Jawayria
55b692aede refactor: Removed unused imports
Removed unused imports from openedx/core/djangoapps/{api_admin, catalog, ccxcon, certificates}
2021-04-02 18:28:16 +05:00
Jawayria
c64d6ab1f0 Merge pull request #26594 from edx/jawayria/bom-2352-9
BOM-2352: Removed unused-imports from lms/djangoapps/verify_student
2021-04-02 18:25:58 +05:00
Ali-D-Akbar
49315ac6b5 refactor: update contact us form 2021-04-02 18:02:17 +05:00
Jawayria
3743aa7dc8 BOM-2352: Removed unused-imports from lms/djangoapps/verify_student 2021-04-02 17:15:14 +05:00