Commit Graph

13058 Commits

Author SHA1 Message Date
Kshitij Sobti
6042972235 fix: Use legacy view for legacy URLs (#30006)
If a user navigates to a legacy URL, then use the legacy view for discussions.
2022-03-03 16:19:12 +05:00
Justin Hynes
a94d5e1ae3 Merge pull request #30000 from openedx/jhynes/revert_microba-1666
revert: reverts 53041a2 after reports of bulk email message issues
2022-03-02 14:41:39 -05:00
Justin Hynes
bbb0bc77d9 revert: reverts 53041a2, causing email issues
[MICROBA-1666]

This reverts commit 53041a2d34 after course team started reporting issues of images in emails not respecting dimensions set with the email editor.

After a brief investigation we found unexpected attributes (like `width` and `height` of an image) being stripped from the HTML.
2022-03-02 14:03:55 -05:00
Bianca Severino
b50de1d6e5 Merge pull request #29993 from openedx/bseverino/confirm-name-change
[MST-1362] Add REST endpoint to confirm name changes
2022-03-02 09:49:51 -05:00
Muhammad Adeel Tajamul
d0e6b2dd20 Merge pull request #29982 from openedx/tnl-9619
fix: post summary taking more than one lines
2022-03-02 07:14:26 +05:00
Jansen Kantor
05b8da5d93 feat: teams csv export split username / external key columns (#29981)
When doing import, we ran into an issue where there was a learner with an external program key that was the
same as an existing, completely unrelated edX account username. Rather than try to guess which learner we want
or do the lookups backwards, it seemed that splitting these columns to avoid any ambiguity would be the most
straightforward and simple approach
2022-03-01 20:04:32 -05:00
Bianca Severino
f177855e1b feat: add REST endpoint to confirm name changes 2022-03-01 16:22:31 -05:00
Michael Terry
5e80b692c8 Merge pull request #29987 from openedx/mikix/no-enrollment-old-mongo
feat: mark Old Mongo courses as invitation-only
2022-03-01 10:13:42 -05:00
Michael Terry
ff90533074 feat: mark Old Mongo courses as invitation-only
This is in service of dropping support for these ancient
courses and removing legacy code that they rely on.

Eventually, we'll remove all access. But this is a first step,
to reduce enrolled learners.

DEPR-58
2022-02-28 16:31:46 -05:00
Justin Hynes
884e8af0f2 docs: ADR for bulk email content html sanitization
[MICROBA-1666]

* Add ADR explaining introduction of bulk email HTML content sanitization and the new `BULK_COURSE_EMAIL_ALLOWED_HTML_TAGS` setting.
2022-02-28 16:01:25 -05:00
Justin Hynes
e608db847c Merge pull request #29969 from openedx/jhynes/microba-1666_sanitize-bulk-email
feat: sanitize bulk course email message content before storing in database
2022-02-28 13:25:11 -05:00
Justin Hynes
53041a2d34 feat: sanitize bulk course email message content before storing in database
[MICROBA-1666]

* Use bleach to sanitize user-provided content of bulk course emails before storing in the database.
* Add new `BULK_COURSE_EMAIL_ALLOWED_HTML_TAGS` setting to enable configuration of allowed HTML tags in bulk course emails.
2022-02-28 08:49:06 -05:00
adeel.tajamul
4af4a6a802 fix: post summary taking more than one lines 2022-02-28 15:58:55 +05:00
Kshitij Sobti
f7df694c5f feat: add provider info to the discussion configuration API (#29864)
The new discusions MFE needs to know which provider is in use (legacy or new) to deliver the expected experience. This adds the provider name and other relevant configuration to the discussion configuraiton API.
2022-02-28 11:23:28 +05:00
Bianca Severino
cc43b5e567 Merge pull request #29952 from openedx/bseverino/name-affirmation-plugin
[MST-1360] Only enable verified name feature if Name Affirmation is installed
2022-02-23 09:18:44 -05:00
AsadAzam
60a21ad664 fix: add separate flag for new structure discussions (#29962)
* fix: add separate flag for new structure discussions

* fix: fixed tests
2022-02-23 10:57:19 +05:00
Ahtisham Shahid
4138c2cc16 fix: Updated discussions banner text as per changed requirements (#29961) 2022-02-22 13:03:03 +05:00
Ahtisham Shahid
af86e1612c fix: moved new discussions mfe behind waffle flag (#29941) 2022-02-21 21:04:50 +05:00
Bianca Severino
76f9756f92 feat: only enable verified name feature if Name Affirmation is installed 2022-02-18 13:25:30 -05:00
Dillon Dumesnil
31f33da625 fix: Update get user timezone logic
Adds in sanitization of the timezone to ensure the timezone is
formatted correctly and error handling to reasonably fall back to UTC
2022-02-18 13:20:20 -05:00
Michael Terry
203863376b feat: enable user tours by default, dropping rollout toggle
AA-1177
2022-02-17 14:56:50 -05:00
Michael Terry
203e2e9c04 Merge pull request #29945 from openedx/mikix/hide-old-mongo
feat: hide Old Mongo courses from catalog
2022-02-17 12:46:14 -05:00
Michael Terry
10ce36ea14 feat: hide Old Mongo courses from catalog
This is step one of removing access altogether. But first, let's
not advertise them.

DEPR-58
DEPR-123
2022-02-17 12:18:36 -05:00
Carlos Muniz
37bf73ca50 refactor: Replace videosequence & problemset (#29905)
`videosequence` and `problemset` have been replaced with `sequential`.

`problemset` and `videosequence` are old-but-not-entirely-unused aliases to the `sequential` block type (in Studio-speak, "Subsection").
Since [these block types have been removed from the 6 courses that used them](https://openedx.atlassian.net/browse/DEPR-151?focusedCommentId=588197), this ticket removes the support for the `problemset` and `videosequence` block-types.

For more information, see ticket: [DEPR-151](https://openedx.atlassian.net/browse/DEPR-151)
2022-02-16 10:21:31 -05:00
AsadAzam
2133ec2099 fix: post anonymous to peers not visible for ta (#29915)
* fix: post anonymous to peers not visible for ta

* test: fix tests
2022-02-16 14:41:37 +05:00
Bianca Severino
af81b3a609 chore: replace integrity signature flag with django setting 2022-02-15 09:57:00 -05:00
Ahtisham Shahid
649a66de4e fix: Added additional conditions for tab view rendering (#29906) 2022-02-15 18:48:57 +05:00
Awais Ansari
be5b27b06e feat: update the discussion preview bar text (#29916)
* feat: update the discussion preview bar text

* fix: update the legacy view button color

* test: fix discussion preview bar failing test cases after text update
2022-02-15 16:41:31 +05:00
Michael Terry
e81c4fe49d Merge pull request #29911 from openedx/mikix/more-old-mongo-test-cleanup
test: more Old Mongo removal from tests
2022-02-11 15:10:45 -05:00
Michael Terry
b905de757b test: more Old Mongo removal from tests
Convert more tests from MONGO_AMNESTY to SPLIT modulestores.

This is in preparation for just wholesale denying access to Old
Mongo, so I either converted tests to split or just deleted some
test variants that were Old Mongo specific. (e.g. ddt lines)
2022-02-11 14:50:30 -05:00
Nathan Sprenkle
6ae626a5d5 feat: ESG logging updates (#29895)
* feat: log exceptions for fall-through exceptions

* chore: remove unused XBlock handler

* refactor: log errors for XBlock handlers

* refactor: log bad ORA locations

* feat: log lock/grade contest errors

* feat: log output data for ESG endpoints

* feat: unpack extra error info from more endpoints
2022-02-11 13:56:25 -05:00
Mubbshar Anwar
efa0f4c644 fix: course/program email information issues (#29884)
dynamically render course/program information in braze email template
VAN-858
2022-02-11 11:40:45 +05:00
Ahtisham Shahid
75d8448ef5 refactor: Moved ProgramDiscussion/Live Configuration Models to program's app (#29871)
refactor: Moved ProgramDiscussion/Live Configuration Models to program's app
2022-02-09 15:43:22 +05:00
AsadAzam
93d8a123d3 fix: remove visibility of anonymous posts for ta (#29883) 2022-02-09 11:02:11 +05:00
dyudyunov
2716810f48 fix: course discovery dates localization after user logout
Preconditions:
- course discovery enabled

STR:
- log in
- choose any language with different date format (e.g. ukrainian)
- check date format changed on the /courses page
- logout and go to /courses again

AR:
- date format is english on /courses, but stays the same as for logged in
user on the main page

ER:
- date format stays the same as for logged in user
2022-02-08 10:07:35 +02:00
Ahtisham Shahid
727efde55c Revert "fix: Hide headers and footer in disucssion mfe UI in edx-platform (#29874)" (#29885)
This reverts commit 7f9dbfc8e7.
2022-02-08 12:23:23 +05:00
Michael Terry
6ac9bae571 Merge pull request #29117 from openedx/mikix/drop-learning-sequence-flag
feat: enable using learning sequence outlines by default
2022-02-07 11:32:59 -05:00
Kshitij Sobti
5708787527 feat: show share feedback button only for discussions MFE when URL is configured (#29785)
Removes the share feedback button unless a URL is configured, and only shows it for the discussions MFE view.
2022-02-07 14:57:32 +05:00
Michael Terry
cb1bb7fa64 test: switch default test store to the split store
It's long past time that the default test modulestore was Split,
instead of Old Mongo. This commit switches the default store and
fixes some tests that now fail:
- Tests that didn't expect MFE to be enabled (because we don't
  enable MFE for Old Mongo) - opt out of MFE for those
- Tests that hardcoded old key string formats
- Lots of other random little differences

In many places, I didn't spend much time trying to figure out how to
properly fix the test, and instead just set the modulestore to Old
Mongo.

For those tests that I didn't spend time investigating, I've set
the modulestore to TEST_DATA_MONGO_AMNESTY_MODULESTORE - search for
that string to find further work.
2022-02-04 14:32:50 -05:00
Jansen Kantor
30dcdb487a fix: uncaught ItemNotFoundErrors (#29870) 2022-02-04 10:24:15 -05:00
Ahtisham Shahid
7f9dbfc8e7 fix: Hide headers and footer in disucssion mfe UI in edx-platform (#29874) 2022-02-04 14:08:36 +05:00
Ali Akbar
232850e8e8 Merge pull request #239 from edx/aakbar/PROD-2630-xss-fix
fix: escape vulnerable enrollment mode
2022-02-03 21:44:21 +05:00
Bianca Severino
a84397e4ad Merge pull request #29820 from openedx/bseverino/remove-idv-experiment
[MST-869] Remove code related to IDV experiment
2022-02-02 11:38:08 -05:00
Kshitij Sobti
23be63309b feat: Add a new user API for discussions (#29287)
Adds a new user API for discussion that returns the discussion stats across the course.
2022-02-01 17:51:01 +05:00
Nathan Sprenkle
1212e3550c feat: ora staff grader backend (#29828)
- Adds Enhanced Staff Grader (ESG) backend-for-frontend (BFF) in `lms/djangoapps/ora_staff_grader`
    - Adds routing to ESG BFF at `{lms_url}/api/ora_staff_grader/*`
    - Adds mock implementation routing at `{lms_url}/api/ora_staff_grader/mock/*`
    - Adds `ORA_GRADING_MICROFRONTEND_URL` setting for routing to ESG microfrontend (MFE)
- Updates to the teams app:
    - Add`get_teams_in_teamset` to the teams API.
    - Add `get_team_names` to teams service.
- Adds `openassessment.staffgrader` app for appropriate ORA migrations.
- Modifies management commands for creation of users.
- Updates test factory to return display org with course overview.

Co-authored-by: jansenk <jkantor@edx.org>
Co-authored-by: Leangseu Kim <lkim@edx.org>
Co-authored-by: Ben Warzeski <bwarzeski@edx.org>
2022-01-31 11:09:41 -05:00
Matjaz Gregoric
65f0a2fd3a fix: send forum notifications for question threads (#29611)
Responses to forum questions did trigger email notifications.

This fix makes email notifications for question-type threads work the
same way as they work for regular discussion-type threads.

See:
https://github.com/openedx/build-test-release-wg/issues/86
2022-01-31 20:44:42 +05:00
Ned Batchelder
fee4ec26f5 fix: return a sorted list so tests can be deterministic
Tests on Maple were failing:

```
    def test_retirement_for_multiple_users(self):
        user_retirement_url = reverse('bulk_retirement_api')
        expected_response = {
            'successful_user_retirements': [self.user3.username, self.user4.username],
            'failed_user_retirements': []
        }
        with self.settings(RETIREMENT_SERVICE_WORKER_USERNAME=self.user1.username):
            response = self.client.post(user_retirement_url, {
                "usernames": f'{self.user3.username},{self.user4.username}'
            })
            assert response.status_code == 200
>           assert response.data == expected_response
E           AssertionError: assert {'failed_user... 'testuser3']} == {'failed_user... 'testuser4']}
E             Omitting 1 identical items, use -vv to show
E             Differing items:
E             {'successful_user_retirements': ['testuser4', 'testuser3']} != {'successful_user_retirements': ['testuser3', 'testuser4']}
E             Use -v to get the full diff
```

`sorted(set(...))` still produces a list, and I guess we didn't care
about the order before, since it wasn't determined.  So this should be
an acceptable change.
2022-01-31 04:09:45 -08:00
Kshitij Sobti
2758301c31 feat: Discussion Topics API v2 [BD-38] [TNL-9332] [BB-5189] (#29530)
* feat: New API for discussion topics

Creates a new API for discussion topics that uses auto-crated discussion topic links for the new discussion provider.

* squash!: refresh migration
2022-01-31 15:57:49 +05:00
Dillon Dumesnil
d8d4826bf0 Merge pull request #29821 from eduNEXT/MJG/fix-available-cert-date-preview
fix: avoid TypeError when comparing course.end with current date
2022-01-28 07:18:22 -08:00
Julia Eskew
0eb0f99d00 feat: Add org-level waffle overrides to allow a waffle flag to be overridden for all
courses in a particular organization, without needing to make a separate course-level
waffle override for each individual course for an organization.
2022-01-28 08:00:18 -05:00