Commit Graph

6834 Commits

Author SHA1 Message Date
brianhw
1be7dbe3d1 Merge pull request #1495 from edx/brian/remove-celery-group
Remove the use of celery.group from bulk email subtasks.
2013-10-28 10:31:31 -07:00
Greg Price
d2e0f27a0a Merge pull request #1510 from edx/gprice/lms-forum-perf
Improve forums performance
2013-10-28 10:28:37 -07:00
Greg Price
e6ecb6ecfe Improve performance of forum views
Avoid recomputing course module information for every thread, which
should dramatically improve the performance of high-percentile latency
queries.

JIRA: FOR-250
2013-10-28 13:04:52 -04:00
Brian Wilson
5b48ed840b Refactor subtask creation logic to be less email-specific. 2013-10-28 12:58:11 -04:00
Greg Price
a7d769dfea Remove an unnecessary global
The _DISCUSSIONINFO global was originally used as a cache, but has since
lost that capability and is therefore just harmful. This is a precursor
to more refactoring that will improve the performance of the forums and
may itself provide some performance improvement because it separates the
computation done by two functions that each previously computed the
entirety of _DISCUSSIONINFO.
2013-10-28 12:57:51 -04:00
Brian Wilson
0f8f82c845 Define and use SubtaskStatus class. 2013-10-28 12:57:41 -04:00
Brian Wilson
ed4b954a53 Remove the use of celery.group from bulk email subtasks. 2013-10-28 12:47:11 -04:00
Carlos Andrés Rocha
eebfe57c68 Merge pull request #1505 from rocha/allow-course-export-to-write-to-stdout
Allow the export_course command to dump results to stdout
2013-10-28 09:21:34 -07:00
Greg Price
545701d520 Add forum utility code unit test coverage
This is in preparation for significant refactoring of the code in
question.
2013-10-28 11:58:43 -04:00
Greg Price
54ad411078 Remove unused code 2013-10-28 11:58:43 -04:00
Carlos Andrés Rocha
b797e34deb Allow the export_course command to dump results to stdout 2013-10-28 11:47:44 -04:00
Greg Price
7abaecd8b7 Improve forum error handling
CommentClientError now has sane subclasses that are meaningfully
distinct, and each subclass is handled appropriately. Errors raised by
the requests library are no longer handled by turning them into
CommentClientErrors, since there is no meaningful handling we can do,
and this way we will get more visibility into why errors are occurring.
Also, HTTP status codes from the comments service indicating client
error are correctly passed through to the client.
2013-10-28 11:23:06 -04:00
Ned Batchelder
d319159dbf Cheatsheet modal is accessible.
Use the leanModal stuff to show the cheatsheet dialog in the wiki.

LMS-1303
2013-10-25 17:40:08 -04:00
David Baumgold
dc589f723c Merge remote-tracking branch 'origin/release' 2013-10-25 15:29:03 -04:00
Calen Pennington
c3d25e1e61 Prevent unbounded nesting of lms field_datas
Previously, whenever a XModule was created from a XDescriptor, we
created another level of nesting of FieldData objects. This change
prevents that nesting.

[TKTS-393]
2013-10-25 12:21:05 -04:00
Carlos Andrés Rocha
7d76f36018 Make course xml export work for all modulestores
Also let xml import work on modulestores that don't use write signaling
2013-10-25 11:58:17 -04:00
Brian Talbot
de12777555 simplifying semantic and stylistic properties of skip nav UI 2013-10-24 17:12:40 -04:00
Brian Talbot
5b63b176da revises semantics and Sass used for skip navigation 2013-10-24 17:12:19 -04:00
Diana Huang
d34c4a66c7 Add skip links to both CMS and LMS
* add HTML for links
* hide links when they are not focused
* when focused, show link (as recommended)
* move accessibility tools to common

LMS-1311
2013-10-24 17:10:33 -04:00
Giulio Gratta
5a46177a5e A11Y changes: better :focus styling, increased contrast, and added image alt texts
- Doubled up :hover and :focus styling to improve a11y
- Increase contrast of certain UI elements for improved a11y
- Added some image alt text for a11y
- Changed video caption styling to blue and made them underline on hover and added a skip link before video for screenreaders.

Fixes Bugs:
- LMS-1336
2013-10-24 12:47:19 -07:00
Joe Blaylock
9e76c6120b Merge pull request #1286 from edx/jrbl/certs-single-user
Certificates: Add regeneration command
2013-10-24 11:59:32 -07:00
Adam
4257f71453 Merge pull request #1473 from edx/adam/fix/a11y-modal-management
makes ajustments to modals on page load
2013-10-24 07:13:55 -07:00
Alexander Kryklia
ee02a2dd97 Merge pull request #1421 from edx/anton/metadata-time-field
Anton/metadata time field
2013-10-24 05:50:13 -07:00
Sarina Canelake
aabe8fc6b4 UX explaining inst dash email subject length (128 characters) 2013-10-23 23:18:24 -04:00
Sarina Canelake
185cf42e8f Merge pull request #1462 from edx/sarina/adjust-email-template
Change footer color in bulk email template
2013-10-23 14:59:12 -07:00
Adam Palay
dec40c7d56 makes ajustments to modals on page load 2013-10-23 16:36:14 -04:00
Jay Zoldak
45f87b30c0 Improve problems acceptance tests. Disable brittle video test. 2013-10-23 13:53:11 -04:00
Szczork
b3844af28d Translation overrides
Usefull variables for translation
2013-10-23 12:39:31 -04:00
Sarina Canelake
90baa0c9af Change footer color in bulk email template 2013-10-23 11:37:51 -04:00
John Jarvis
68d31b9808 adding STATIC_ROOT_BASE to lms/envs/aws.py 2013-10-23 10:30:05 -04:00
brianhw
e1b39774de Merge pull request #1458 from edx/brian/email-dupe-retry
Check for requeued subtasks when in RETRY state.
2013-10-23 07:04:37 -07:00
Diana Huang
813c8c4cec Merge pull request #1426 from edx/diana/django-wiki-colors
Better indication of what mode is active in the wiki.
2013-10-23 06:13:50 -07:00
Alexander Kryklia
0da81e2a56 Update IsoTIme to be timedelta and update tests. 2013-10-23 13:03:55 +03:00
Usman Khalid
91fbc6610e dashboard.html: Made strings translatable 2013-10-23 14:52:13 +05:00
Usman Khalid
cfaf1275a7 leanModel is setup on jQuery.ready() 2013-10-23 14:52:13 +05:00
polesye
6c08708131 Merge pull request #1111 from edx/anton/video_subtitles
Add Timed Transcripts Editor.
2013-10-23 02:38:39 -07:00
Greg Price
bfd2957194 Merge pull request #1457 from edx/gprice/add-newrelic-instrumentation
Add newrelic instrumentation to forum views
2013-10-22 15:23:15 -07:00
Brian Wilson
16b85c0c2a Check for requeued subtasks when in RETRY state. 2013-10-22 18:17:00 -04:00
Diana Huang
52ed7b277d Add i18n hooks.
LMS-1306
2013-10-22 16:32:10 -04:00
Greg Price
85f5c9328f Add newrelic instrumentation to forum views 2013-10-22 14:51:38 -04:00
Greg Price
60306f2471 Remove unnecessary login_required decorator 2013-10-22 14:51:38 -04:00
David Baumgold
f3bcef2fba Merge pull request #1452 from edx/rc/2013-10-23-fixes
release candidate improvements v2
2013-10-22 11:46:12 -07:00
Anton Stupak
aecc20af6b Add Timed Transcripts Editor. 2013-10-22 21:45:03 +03:00
Brian Wilson
a7b5663c4d Add cache-based locking to subtasks to ensure that the same task is not running in two workers at the same time. 2013-10-22 14:35:06 -04:00
Brian Wilson
ecb58e863f Add cache-based locking to subtasks to ensure that the same task is not running in two workers at the same time. 2013-10-22 14:32:52 -04:00
Diana Huang
0752375e46 Indicate active status more clearly for people
with vision impairments

* bold text when active
* add in some extra text for screen readers

LMS-1306
2013-10-22 14:21:35 -04:00
Adam
1f7bb112bf Merge pull request #1401 from edx/adam/a11y-modal-management
optimize keyboard focus management on dashboard's modals
2013-10-22 11:17:10 -07:00
Brian Talbot
5730f6e35c LMS: adds correct css/style assets back to password reset and confirm views 2013-10-22 14:09:46 -04:00
Julia Hansbrough
a48bee7f13 Fixed indentation 2013-10-22 14:09:30 -04:00
Julia Hansbrough
68a507383f Fixed a bug where legacy instructor dash's email editor failed to load 2013-10-22 14:09:24 -04:00