Commit Graph

19121 Commits

Author SHA1 Message Date
brianhw
1be7dbe3d1 Merge pull request #1495 from edx/brian/remove-celery-group
Remove the use of celery.group from bulk email subtasks.
2013-10-28 10:31:31 -07:00
Greg Price
d2e0f27a0a Merge pull request #1510 from edx/gprice/lms-forum-perf
Improve forums performance
2013-10-28 10:28:37 -07:00
Greg Price
e6ecb6ecfe Improve performance of forum views
Avoid recomputing course module information for every thread, which
should dramatically improve the performance of high-percentile latency
queries.

JIRA: FOR-250
2013-10-28 13:04:52 -04:00
Brian Wilson
5b48ed840b Refactor subtask creation logic to be less email-specific. 2013-10-28 12:58:11 -04:00
Greg Price
a7d769dfea Remove an unnecessary global
The _DISCUSSIONINFO global was originally used as a cache, but has since
lost that capability and is therefore just harmful. This is a precursor
to more refactoring that will improve the performance of the forums and
may itself provide some performance improvement because it separates the
computation done by two functions that each previously computed the
entirety of _DISCUSSIONINFO.
2013-10-28 12:57:51 -04:00
Brian Wilson
0f8f82c845 Define and use SubtaskStatus class. 2013-10-28 12:57:41 -04:00
Brian Wilson
ed4b954a53 Remove the use of celery.group from bulk email subtasks. 2013-10-28 12:47:11 -04:00
David Baumgold
c4434cb1f0 Merge pull request #1491 from edx/db/release-script-include-jira
Improved release script
2013-10-28 09:44:34 -07:00
Carlos Andrés Rocha
eebfe57c68 Merge pull request #1505 from rocha/allow-course-export-to-write-to-stdout
Allow the export_course command to dump results to stdout
2013-10-28 09:21:34 -07:00
Greg Price
545701d520 Add forum utility code unit test coverage
This is in preparation for significant refactoring of the code in
question.
2013-10-28 11:58:43 -04:00
Greg Price
54ad411078 Remove unused code 2013-10-28 11:58:43 -04:00
Greg Price
b4ae47972f Merge pull request #1496 from edx/gprice/comment-client-error-sanity
Improve forum error handling
2013-10-28 08:48:40 -07:00
David Baumgold
c1a152d60a Improved release script 2013-10-28 11:48:05 -04:00
Carlos Andrés Rocha
b797e34deb Allow the export_course command to dump results to stdout 2013-10-28 11:47:44 -04:00
Will Daly
42f9b06b06 Merge pull request #1515 from edx/will/fix-js-transcript-tests
Add explicit wait to JS transcript tests
2013-10-28 08:26:27 -07:00
Greg Price
7abaecd8b7 Improve forum error handling
CommentClientError now has sane subclasses that are meaningfully
distinct, and each subclass is handled appropriately. Errors raised by
the requests library are no longer handled by turning them into
CommentClientErrors, since there is no meaningful handling we can do,
and this way we will get more visibility into why errors are occurring.
Also, HTTP status codes from the comments service indicating client
error are correctly passed through to the client.
2013-10-28 11:23:06 -04:00
Ned Batchelder
d8444266d7 Merge pull request #1509 from edx/ned/fix/lms-1303
Cheatsheet modal is accessible. LMS-1303
2013-10-28 08:13:22 -07:00
Will Daly
3c9d86f7bd Add explicit wait to JS transcript tests 2013-10-28 10:42:22 -04:00
Christina Roberts
5449a3ccbb Merge pull request #1506 from edx/christina/codemirror-css
Add css mode to the compressed file.
2013-10-28 06:18:58 -07:00
Usman Khalid
e027e50028 Merge pull request #1345 from edx/usman/lms1222-email-confirm-transaction-errors
Commit/rollback transaction after rendering response to prevent TransactionManagementErrors due to db access in templates.
2013-10-28 03:13:01 -07:00
dcadams
5fbda0c63b Merge pull request #1396 from edx/dcadams/fix_static_paths
Fix for static path parsing
2013-10-25 14:54:59 -07:00
Ned Batchelder
d319159dbf Cheatsheet modal is accessible.
Use the leanModal stuff to show the cheatsheet dialog in the wiki.

LMS-1303
2013-10-25 17:40:08 -04:00
David Adams
20f1feb7b1 Fix for static path parsing
When a url contains a query parameter it gets incorrectly parsed
when replacing the /static portion.

This fix handles urls with query parameters.
2013-10-25 13:02:29 -07:00
cahrens
c7c0aacb00 Add css mode to the compressed file.
STUD-833
2013-10-25 15:33:31 -04:00
David Baumgold
dc589f723c Merge remote-tracking branch 'origin/release' 2013-10-25 15:29:03 -04:00
Jason Bau
832e262400 Merge pull request #1497 from edx/jbau/fix-ora-uploads
test bucket existence before creation
2013-10-25 10:53:25 -07:00
David Baumgold
6993161d14 Merge pull request #1504 from cpennington/field-data-nesting-hotfix
Prevent unbounded nesting of lms field_datas
2013-10-25 09:54:36 -07:00
Calen Pennington
c3d25e1e61 Prevent unbounded nesting of lms field_datas
Previously, whenever a XModule was created from a XDescriptor, we
created another level of nesting of FieldData objects. This change
prevents that nesting.

[TKTS-393]
2013-10-25 12:21:05 -04:00
Carlos Andrés Rocha
7d76f36018 Make course xml export work for all modulestores
Also let xml import work on modulestores that don't use write signaling
2013-10-25 11:58:17 -04:00
Jason Bau
d0185c934a make OEE upload test pass 2013-10-25 08:32:50 -07:00
Jason Bau
63bdeea44b test bucket existence before creation 2013-10-25 08:32:50 -07:00
Usman Khalid
8f356fc3ec student.views.confirm_email_change: commit/rollback transaction after rendering response instead of before 2013-10-25 15:02:53 +00:00
Usman Khalid
6ddd0ae5ab student.tests: Added db access in mock_render_to_response() to test any issues with @transaction.commit_manually 2013-10-25 15:02:52 +00:00
Diana Huang
30861d0b3d Merge pull request #1498 from edx/diana/fix-cms-acceptance
Add masked input back into RequireJS
2013-10-25 04:27:40 -07:00
thedeadparrot
19129e6081 Add masked input back into RequireJS 2013-10-24 19:50:56 -04:00
Diana Huang
6f34bb1dac Merge pull request #1468 from edx/diana/navigation-skip-links
Add skip links to both CMS and LMS
2013-10-24 14:15:58 -07:00
Diana Huang
f2f067a37d Update CHANGELOG 2013-10-24 17:15:31 -04:00
Diana Huang
67da62f83c Update the JS to match the new semantics.
Bug: LMS-1311
2013-10-24 17:12:40 -04:00
Brian Talbot
de12777555 simplifying semantic and stylistic properties of skip nav UI 2013-10-24 17:12:40 -04:00
Diana Huang
43bdb5da54 Minor fixes to match new HTML and CSS updates.
LMS-1311
2013-10-24 17:12:20 -04:00
Brian Talbot
5b63b176da revises semantics and Sass used for skip navigation 2013-10-24 17:12:19 -04:00
Diana Huang
20b9258d43 Add in tabIndex to ensure that the tabbing works properly for link.
LMS-1311
2013-10-24 17:10:33 -04:00
Diana Huang
d34c4a66c7 Add skip links to both CMS and LMS
* add HTML for links
* hide links when they are not focused
* when focused, show link (as recommended)
* move accessibility tools to common

LMS-1311
2013-10-24 17:10:33 -04:00
Calen Pennington
71ece15cfb Merge pull request #1488 from cpennington/update-newrelic
Upgrade newrelic so that we can use the new histogram and percentile features
2013-10-24 13:48:43 -07:00
Christina Roberts
3958bab6ae Merge pull request #1454 from edx/christina/assets
Update URLs for assets
2013-10-24 13:22:39 -07:00
Will Daly
3fa5559a36 Merge pull request #1487 from edx/will/fix-js-transcript-test
Added explicit wait to failing JS test
2013-10-24 13:18:12 -07:00
cahrens
39a8d07e47 Update URLs for assets. 2013-10-24 16:00:56 -04:00
Giulio Gratta
ea163de038 Merge pull request #1479 from edx/giulio/a11y-batch1
A11Y changes: better :focus styling, increased contrast, and added image alt texts
2013-10-24 12:47:43 -07:00
Giulio Gratta
5a46177a5e A11Y changes: better :focus styling, increased contrast, and added image alt texts
- Doubled up :hover and :focus styling to improve a11y
- Increase contrast of certain UI elements for improved a11y
- Added some image alt text for a11y
- Changed video caption styling to blue and made them underline on hover and added a skip link before video for screenreaders.

Fixes Bugs:
- LMS-1336
2013-10-24 12:47:19 -07:00
Joe Blaylock
9e76c6120b Merge pull request #1286 from edx/jrbl/certs-single-user
Certificates: Add regeneration command
2013-10-24 11:59:32 -07:00