Commit Graph

23296 Commits

Author SHA1 Message Date
Kshitij Sobti
140a1bf3d8 docs: ADR for new way to enable/disable teams (#28891)
Enabling or disabling team currently requires adding a team set/topic/group or removing them all. This ADR proposes a new mechanism.
2021-10-25 15:50:52 +05:00
Awais Jibran
ed74db1daf Revert "feat: Add support for returning thread counts for all topics in a course [BD-38] [TNL-8724] [BB-4927] (#29062)" (#29087)
This reverts commit a2f04fb78b.
2021-10-22 17:21:44 +05:00
M. Zulqarnain
9833134fae Post Django 3.2 Cleanup (#29069)
* chore: Post Django 3.2 Cleanup
2021-10-22 13:55:16 +05:00
Zainab Amir
6019971dd4 feat: put year of birth behind feature flag (#29007) 2021-10-22 12:17:06 +05:00
Attiya Ishaque
7e3985291d feat: [VAN-751] Put user's year of birth behind the feature flag (#29025) 2021-10-22 11:33:01 +05:00
Kshitij Sobti
a2f04fb78b feat: Add support for returning thread counts for all topics in a course [BD-38] [TNL-8724] [BB-4927] (#29062)
* feat: Add support for returning thread counts for all topics in a course

In the new discussions experience the thread counts for questions and discussions are displayed in the UI.
This uses a new cs_comments_service API to fetch that data and embed it in the topic listing.

* fix: apply review feedback fixes
2021-10-22 11:22:05 +05:00
Usama Sadiq
95427251dc fix: fixed pylint warnings 2021-10-21 09:54:22 -04:00
Kyle McCormick
9bf266f717 fix: add missing __init__.py files 2021-10-21 09:54:22 -04:00
M. Zulqarnain
ba75bb6569 feat: django codemods changes for common folder (#28775) 2021-10-21 13:52:19 +05:00
Matthew Piatetsky
e0d2cda697 fix: ensure goal reminder command respects flag cofiguration of individual users (#29071) 2021-10-20 15:03:38 -04:00
Usama Sadiq
9ee8df0980 fix: Remove pylint constraint and fix warnings (#28646) 2021-10-20 23:00:13 +05:00
Rebecca Graber
668ae8bd25 chore: add ownership mapping for eventtracking (#29065) 2021-10-20 08:02:34 -04:00
Chris Deery
ac8b4f5a6d Weekly Learning Goal back end (#28955)
* feat: [AA-906] Number of days Goal setting back end updates

added number_of_days_goals_enabled flag to course_goals

* feat: [AA-906] renamed number of days goal to WeeklyLearningGoal

* feat: [AA-906] fix unit test

* feat: [AA-906] fix unit test

cleanup
2021-10-18 13:33:03 -04:00
Simon Chen
d543a23fe5 fix: User unretirement admin template use static instead of admin_static template library (#29052)
TNL-8884. This change would fix the issue where the undeleting a user results in 500. This is a change needed after the django version is upgraded to django 3.2

Co-authored-by: Simon Chen <schen@edx-c02fw0guml85.lan>
2021-10-18 12:33:38 -04:00
Meysam
9726d149e9 fix: display right-to-left for rtl-languages in mobile (#28861) 2021-10-18 10:20:17 -04:00
Albert (AJ) St. Aubin
32d35acf63 feat: update the text for unearned certificates
[MICROBA-1536]
2021-10-15 15:48:58 -04:00
Feanil Patel
6a671f26b3 fix: Add the notices to plugin mapping.
The notices app is a plugin to edx-platform that needs to be tracked correctly for ownership.
2021-10-15 14:05:34 -04:00
Felipe Montoya
2100537e1f Merge pull request #27795 from eduNEXT/eric/codejail_rest_service
Optionally run Codejail in a external service using REST API.
2021-10-15 09:36:00 -05:00
Eric Herrera
fe6882819a fix: Address more PR comments
Address @felipemonotoya recommendations related to add versioning to safe_exec_remote functions.
2021-10-15 08:19:48 -05:00
Eric Herrera
fc7104cde5 fix: Address PR comments
Address fixes recommended by @timmc-edx.
2021-10-14 08:11:40 -05:00
Eric Herrera
d672d309e8 fix: Improve and fix codejail service integration
Address recommendations and fixes discussed in PR.
Use similar structure to notes app.
Fix errors detected in tests.
2021-10-14 08:11:40 -05:00
Eric Herrera
3a736eefa2 feat: Codejail as external service (optional)
Add codejail service settings (endpoint and feature flag).
Add conditional to allow running codejail using a REST API service when flag is enabled.
2021-10-14 08:11:40 -05:00
Felipe Montoya
678c159cf8 docs: adding the first version of documentation for open edx events
Includes:
- general documentation
- links to individual events definitions and location
- adding examples to events docs
- adding annotations at the trigger location
2021-10-13 15:28:24 -05:00
Tim McCormack
fe3d855986 feat: Don't warn about expected user changes in safe-sessions (#28983)
This is intended to silence a rare false positive that seems to happen
when someone logs in on a browser that already has an active session
for another user. We believe there should be no further positives once
this case is handled.

- login and logout views annotate the response to indicate the session
  user should be changing between the request and response phases
- safe-sessions middleware skips the verify-user check when this
  annotation is present

Also:

- Adds a test around existing behavior for unexpected user-changes
- Remove logging control based on `is_from_log_out`. This reverts most
  of af9e26f/PR #11479 for two reasons:
  - The safe-sessions `_verify_user` code has since changed to check for
    `request.user.id == None`
  - A commit later in the PR changes the login and logout pages to
    signal that the user/session change is expected
2021-10-13 15:53:16 +00:00
Feanil Patel
3cc1389d68 Merge pull request #28993 from edx/iamsobanjaved/django32-samesite-cookies
fix: update samesite cookie settings name for Django 3.2
2021-10-13 11:11:39 -04:00
Attiya Ishaque
e7021933fc feat: Add feature flag for year of birth field (#28992) 2021-10-11 19:44:56 +05:00
Soban Javed
c7bd6679f5 fix: update samesite cookie settings name for Django 3.2
As django-cookies-samesite package is set to be removed from base requirements when we upgrade to Django 3.2, we should follow the settings name provided by Django.
https://docs.djangoproject.com/en/3.2/ref/settings/#session-cookie-samesite
2021-10-11 15:22:01 +05:00
Mubbshar Anwar
66291c3aa6 feat: record opt in/out attribute (#28883)
* feat: record opt in/out attribute

save opt in/out attribute comming from frontend-app-authn register page.
VAN-738

* feat: VAN-738 - Send marketing event property and email subscription

* feat: VAN-738 - Send marketing event property and email subscription

* feat: VAN-738 - updated conditions

* feat: VAN-738 - added is_active for braze during registration

* feat: VAN-738 - added is_active for braze during registration

* feat: VAN-738 - fixed pep8 violation

Co-authored-by: Shafqat Farhan <shafqat.farhan@arbisoft.com>
2021-10-08 18:29:18 +05:00
AsadAzam
3d3bdbe98d feat: put teams app availability behind waffle flag (#28969)
* feat: Put teams app availability behind waffle flag

* refactor: updated comment
2021-10-08 18:24:18 +05:00
Matthew Piatetsky
d73d267761 fix: pluralize times per week and increase width of unsubscribe element (#28978) 2021-10-07 17:08:43 -04:00
David Ormsbee
ae124bd554 Revert "feat: store split modulestore's course indexes in Django/MySQL"
This reverts commit 96e5ff8dce.
2021-10-07 15:07:42 -04:00
Braden MacDonald
96e5ff8dce feat: store split modulestore's course indexes in Django/MySQL
Split modulestore persists data in three MongoDB "collections": course_index (list of courses and the current version of each), structure (outline of the courses, and some XBlock fields), and definition (other XBlock fields). While "structure" and "definition" data can get very large, which is one of the reasons MongoDB was chosen for modulestore, the course index data is very small.

By moving course index data to MySQL / a django model, we get these advantages:
* Full history of changes to the course index data is now preserved
* Includes a django admin view to inspect the list of courses and libraries
* It's much easier to "reset" a corrupted course to a known working state, by using the simple-history revert tools from the django admin.
* The remaining MongoDB collections (structure and definition) are essentially just used as key-value stores of large JSON data structures. This paves the way for future changes that allow migrating courses one at a time from MongoDB to S3, and thus eliminating any use of MongoDB by split modulestore, simplifying the stack.
2021-10-07 10:59:47 -04:00
Matthew Piatetsky
4f47fc3141 fix: font family for goal reminder email (#28976) 2021-10-07 10:33:38 -04:00
Ahtisham Shahid
009f1aac0d refactor: moved program journey data to appropriate tabs (#28898)
* refactor: moved program journey data to appropriate tabs
2021-10-07 14:15:09 +05:00
Kshitij Sobti
3e05e0f49b feat: add support for enabling/disabling the wiki app (#28889)
Currently the wiki app can't be enabled or configured. This change allows enabling/disabling the wiki app which effectively hides/shows the wiki tab.
2021-10-07 11:04:03 +05:00
Matthew Piatetsky
449d5c7a2d feat: only email users about their goal in the morning in their timezone (#28922) 2021-10-06 15:02:03 -04:00
Muhammad Soban Javed
c930b2a673 test: removing test as not needed anymore (#28954)
This test case was added to make sure that django-cookies-samesite is installed with Django uptill 3.0 but as now we are moving to Django 3.2, this isn't needed anymore
2021-10-06 20:53:46 +05:00
Eugene Dyudyunov
7f40e3aa60 fix: course search sidebar filters (#28708)
Elasticsearch7 returns `aggs` instead of `facets`,
fixed elasticsearch response parsing on the FrontEnd.

YT: https://youtrack.raccoongang.com/issue/RGOeX-413
2021-10-06 11:04:52 -04:00
Muhammad Soban Javed
e58cae34e1 Merge pull request #28796 from edx/iamsobanjaved/django30-lang-BOM-2783
fix: use language preference from cookie instead of from session
2021-10-05 18:43:57 +05:00
Awais Qureshi
4a9bd35f69 Merge pull request #28895 from edx/fixing-dj32-issue
fix: Fixing test csrf tests failures in django32.
2021-10-05 13:47:41 +05:00
Kshitij Sobti
9e787a09bc chore: remove dependency on rest_condition (#28663)
rest-condition has not been updated for a while, and with DRF 3.9 it is no longer needed since the ability to combine Permission classes using boolean operators is now provided by DRF directly.
2021-10-04 15:38:17 -04:00
Jason Myatt
a916123b04 Merge pull request #28705 from open-craft/mtyaka/FAL-782-course-home-link-to-mfe
Link on course about page should link to the learning MFE
2021-10-04 15:26:20 -04:00
Awais Qureshi
7374ecd4ba fix: Fixing test csrf tests failures in django32. 2021-10-04 23:28:20 +05:00
ha-D
d3bc4601ae feat: Add course-wide custom scripts
Imlements OEP-15 by adding two fields to the course settings:
- Course-wide Custom JS
- Course-wide Custom CSS
The resources defined in these fields will be rendered in all course pages.

Rebase b6cb629849..0578e1c4c6 onto b6cb629849:
- Add course-wide resources to API for MFE use
- Revert "Add course-wide resources to API for MFE use" reverts commit 53648dcf0afe3cd171c9dc2eb5e56b871b2bcfb2

Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
2021-10-04 11:24:45 -07:00
Soban Javed
44ddbdf925 fix: use cookies for storing language instead of session
- Fixed LANGUAGE_COOKIE settings name to LANGUAGE_COOKIE_NAME beacuse later is recognised by django
- Added test to verify cookies use in dark lang middleware
- Fixing Django 3.0 tests
2021-10-04 21:00:29 +05:00
Soban Javed
71debe7f7b fix: remove fake2 language from django settings
This was causing issue with Django 3.2, as Django has restricted to only use language from the pre-defined set of languages provided by Django.

BOM-2870
2021-10-04 20:44:18 +05:00
Awais Qureshi
fa959f1ed9 Merge pull request #28810 from edx/removing-cors-headers-checks
chore: `django-cor-headers` post deployment cleanup.
2021-10-04 17:12:47 +05:00
Awais Qureshi
9010e99a80 Merge pull request #28904 from edx/fixing-dj32-setuptestdata-tests
Fixing dj32 setuptestdata tests
2021-10-04 16:03:11 +05:00
Matjaz Gregoric
6434735f0e fix: course about should link to MFE
When not using the legacy frontend, the course about page should link
to the MFE instead of the legacy courseware view.
2021-10-04 10:19:42 +02:00
Awais Jibran
06b912e5db refactor: optimise imports (#28897) 2021-10-04 11:15:32 +05:00