Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
58,450 Commits 1 Branch 0 Tags
079f43f40d399cfc0da17039b6dede4e06bda2fb
Commit Graph

58450 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
edx-pipeline-bot
d1d7867ee6 Merge pull request #26450 from edx/private_to_public_02d0b47 
Mergeback PR from private to public.
 2021-02-09 04:51:54 -05:00
edX cache uploader bot
f383a5b385 Updating Bokchoy testing database cache (#26448) 2021-02-09 14:03:15 +05:00
edX requirements bot
4422009c51 Updating Python Requirements (#26445) 2021-02-09 12:53:52 +05:00
jawad khan
95580b79a7 LEARNER-8218 Added BearerAuthenticationAllowInactiveUsern in celebration api 
Added BearerAuthenticationAllowInactiveUsern in celebration api
 2021-02-09 12:52:12 +05:00
Ali Akbar
280829705a Merge pull request #26433 from edx/IM/security-fixes-8-thresholds 
Update Thresholds
 2021-02-09 10:53:42 +05:00
Carla Duarte
00a025f073 AA-590: pass translated tab titles to MFE 2021-02-08 17:00:33 -05:00
Matt Hughes
02d0b474e7 Merge pull request #219 from edx/matthugs/EDUCATOR-5555-a11y-js-code-for-notes-needs-to-handle-tags-better 
Fix XSS vector for a11y text attached to notes editor
 2021-02-08 16:54:49 -05:00
Usama Sadiq
9dfd38bb2c Merge pull request #26431 from edx/usamasadiq/lower-pylint-upper-threshold 
Lower down pylint error thresholds
 2021-02-09 00:44:18 +05:00
Matt Tuchfarber
cabb5d928f Merge pull request #26292 from edx/tuchfarber/add_consistent_logging_credentials_tasks 
Make credentials celery tasks errors consistent
 2021-02-08 14:40:35 -05:00
Alexander J Sheehan
0bfb60e9ac Merge pull request #26438 from edx/alex-sheehan-edx/bumping-enterprise-to-3.17.24 
bumping enterprise to 3.17.24
 2021-02-08 14:25:21 -05:00
Tim McCormack
80a4437f33 fix: Always save generated anonymous user ID in DB; ignore save=False (#26399) 
This deprecates `save=False` for several functions and removes all known
usages of the parameter but does not actually remove the parameter.
Instead, it will emit a deprecation warning if the parameter is used.
We can remove the parameter as soon as we feel sure nothing is using it.

Now that we have refactored `anonymous_id_for_user` to always prefer
retrieving an existing ID from the database -- and observed that only a
small fraction of calls pass save=False -- we can stop respecting
save=False. This opens the door for future improvements, such as generating
random IDs or switching to the external user ID system.

Metrics: I observe that 1 in 16 requests for new, non-request-cached
anon user IDs are made with save=False. But 71% of all calls are served
from the request cache, and 99.7% of the misses are served from the DB.
save=False only appear to come from intermittent spikes as reports are
generated and are low in absolute number.

Also document usage/risk/rotation of secret in anonymous user ID
generation as indicated by `docs/decisions/0008-secret-key-usage.rst`
ADR on `SECRET_KEY` usage.

ref: ARCHBOM-1683
 2021-02-08 19:16:05 +00:00
usamasadiq
ab678daaa5 Lower down pylint error thresholds 2021-02-09 00:15:33 +05:00
Feanil Patel
cfca652dee feat: Add paths to easily view various error pages. 
Currently it's hard to see the content of an error without knowing how
to cause an existing view to make that error in production.  Adding
these default paths should make that a lot easier.
 2021-02-08 14:03:26 -05:00
Feanil Patel
cd3e4353b1 feat: Add a 403 and 429 handler. 
See context here: https://django-ratelimit.readthedocs.io/en/latest/cookbook/429.html#context

For now we continue to fall back to django's default 403 handler for 403
but provide a new 429 template that we use for ratelimit exceptions.

This commit also updates a logistration test that relied on the old 403
behavior of django-ratelimit instead of the newly added 429 behavior.
 2021-02-08 14:03:26 -05:00
Matt Tuchfarber
64032faae7 Make credentials celery tasks errors consistent 
In order to better alert off of tasks that failed after maximum retries,
this makes the the error for each task consistent with itself.
 2021-02-08 13:55:35 -05:00
Bianca Severino
54505b82c4 Merge pull request #26436 from edx/bseverino/proctoring-check-fix 
[MST-645] Account for no enrollment in courseware rules
 2021-02-08 13:39:40 -05:00
Carla Duarte
a3f0050c4d Merge pull request #26396 from edx/ciduarte/depr-keys 
AA-650: block deprecated keys from course home MFE
 2021-02-08 13:27:58 -05:00
Alexander Sheehan
749b630c55 bumping enterprise to 3,17,24- am also responsible for and ok with 23 going out 2021-02-08 13:20:18 -05:00
Bianca Severino
4fb36709a5 Account for no enrollment in courseware rules 2021-02-08 13:12:52 -05:00
Matt Tuchfarber
eac7904a7f Merge pull request #26434 from edx/tuchfarber/update_pylint 
Update to newest edx-lint
 2021-02-08 13:02:07 -05:00
Carla Duarte
8d2d78dc61 AA-650: block deprecated keys from course home MFE 2021-02-08 13:00:36 -05:00
Ali-D-Akbar
f87507bdfa PROD-2253 2021-02-08 23:00:17 +05:00
Ali-D-Akbar
f16d4d943e PROD-2029 2021-02-08 23:00:17 +05:00
Ali-D-Akbar
ebea3c0f62 PROD-2030 2021-02-08 23:00:17 +05:00
Ali-D-Akbar
a34a40923a PROD-2031 2021-02-08 23:00:17 +05:00
Ali-D-Akbar
a2d2c0750b PROD-2032 2021-02-08 22:57:26 +05:00
Ali-D-Akbar
9353504692 PROD-2028 2021-02-08 22:57:26 +05:00
Ali-D-Akbar
28f16251d3 PROD-2026 2021-02-08 22:57:26 +05:00
Ali-D-Akbar
2038215da1 PROD-2027 2021-02-08 22:56:44 +05:00
Ali-D-Akbar
a2a58065b4 PROD-2025 2021-02-08 22:56:44 +05:00
Ali-D-Akbar
da1330de9e update thresholds after IM security fixes 8 2021-02-08 22:27:21 +05:00
Matt Tuchfarber
978183bfc6 Update to newest edx-lint 
Copy existing pylintrc changes to pylintrc_tweaks
 2021-02-08 12:26:47 -05:00
Feanil Patel
03d2d983ea Merge pull request #26392 from edx/feanil/rate_limit_anon_csv 
Feanil/rate limit anon csv
 2021-02-08 12:05:21 -05:00
Fox Piacenti
c840e6f9bb Update Library v2 Indexes to work with ElasticSearch 7. Repair blockstore integration tests. (#26230) 2021-02-08 11:55:47 -05:00
Christie Rice
367d2a07c9 Fix lint-amnesty warnings (#26411) 2021-02-08 10:49:32 -05:00
Usama Sadiq
1dca1835ce Merge pull request #26429 from edx/BOM-2334 
Apply pylint-amnesty.
 2021-02-08 20:46:15 +05:00
Gábor Boros
dd55860da1 [TSD] [SE-3988] add annotations to instructor plugin settings (#26202) 
docs: add annotations to instructor plugin settings
 2021-02-08 10:45:26 -05:00
Tim McCormack
b8a6e30bd9 fix: Add new proctoring key to Studio devstack & tests envs (copy from LMS) (#26430) 
Turns out it's needed for the Proctoring Settings view.

Also reorder slightly for better clustering.

MST-644
 2021-02-08 15:43:51 +00:00
Awais Qureshi
7ee49390bb BOM-2334 
Apply pylint-amnesty.
 2021-02-08 20:12:45 +05:00
Usama Sadiq
045a3dc249 Merge pull request #26422 from edx/BOM-2337 
Apply pylint-amnesty.
 2021-02-08 20:09:34 +05:00
Usama Sadiq
325d4ec770 Merge pull request #26423 from edx/BOM-2338 
Apply pylint-amnesty.
 2021-02-08 20:09:12 +05:00
Christie Rice
6e5a9f5f6f MICROBA-918 Move methods to separate certificate generation from celery task to schedule certificate generation. Also standardizes imports. (#26410) 2021-02-08 10:01:04 -05:00
edx-pipeline-bot
930980d732 Merge pull request #26427 from edx/private_to_public_01b389b 
Mergeback PR from private to public.
 2021-02-08 09:36:23 -05:00
Usama Sadiq
9ab240f87e Merge pull request #26380 from edx/usamasadiq/bom-2312-pylint-amnesty-common-lib 
Applied pylint-amnesty
 2021-02-08 18:57:01 +05:00
Usama Sadiq
eb2f8e791b Merge pull request #26382 from edx/usamasadiq/bom-2327-pylint-amnesty 
Applied pylint amnesty
 2021-02-08 18:56:01 +05:00
Jayram
7d479a8148 docs: add annotations for MAX_FAILED_LOGIN_ATTEMPTS_ALLOWED settings 2021-02-08 19:19:27 +05:30
Jayram
6b4a69b789 docs: add annotations for ENABLE_MAX_FAILED_LOGIN_ATTEMPTS feature flag 2021-02-08 19:15:42 +05:30
Usama Sadiq
1bb06669e3 Merge branch 'master' into usamasadiq/bom-2312-pylint-amnesty-common-lib 2021-02-08 18:26:15 +05:00
Usama Sadiq
7eb2c40106 Merge branch 'master' into usamasadiq/bom-2327-pylint-amnesty 2021-02-08 18:24:53 +05:00
Usama Sadiq
90666a6231 Merge pull request #26311 from edx/usamasadiq/bom-2305-pylint-amnesty 
Applied pylint-amnesty
 2021-02-08 18:23:34 +05:00