Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #219 from edx/matthugs/EDUCATOR-5555-a11y-js-code-for-notes-needs-to-handle-tags-better

Browse Source 
Fix XSS vector for a11y text attached to notes editor
This commit is contained in:
Matt Hughes
2021-02-08 16:54:49 -05:00
committed by GitHub
parent 9dfd38bb2c b0a1166470
commit 02d0b474e7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lms/static/js/edxnotes/views/shim.js
View File

@@ -165,7 +165,7 @@
.addField({
load: function(field, annotation) {
if (annotation.text) {
$(field).html(HtmlUtils.HTML(Utils.nl2br(annotation.text)).toString());
$(field).html(HtmlUtils.HTML(Utils.nl2br(Annotator.Util.escape(annotation.text))).toString());
} else {
// eslint-disable-next-line max-len
$(field).html(HtmlUtils.joinHtml(HtmlUtils.HTML('<i>'), _t('No Comment'), HtmlUtils.HTML('</i>')).toString());