Commit Graph

735 Commits

Author SHA1 Message Date
Ben Patterson
db2ac7996d Merge pull request #9515 from edx/benp/add-jshint-diff-quality
Add jshint to run_quality.
2015-08-31 12:55:20 -04:00
Ben Patterson
91c1527189 Update circle-ci to run quality after jshint has been added to PATH.
[Also correct some comments.]
2015-08-31 11:08:56 -04:00
Ben Patterson
0683e5ff3f Add jshint diff-quality.
The platform includes jshint as a development tool, and our
builds are enforcing a limit on total number of jshint violations.
This commit will enforce no new jshint violations on a per-change
basis, much like pylint and pep8 are enforced. So with this change,
we'll be enforcing our linting requirements consistently, regardless
of type of violations.

Also on Jenkins, runs quality task after installing jshint.
2015-08-31 10:56:09 -04:00
Ned Batchelder
5a3b69ba4b Add current directory to the sass compilation path.
This is the default in 3.2, but will need to be explicitly stated in
Sass 3.4.

Also, added a --force parameter to compile_sass to make it easier to see
what warnings are current.
2015-08-28 14:52:18 -04:00
Ned Batchelder
2a0259095d Change imports from path to use the stablest name.
The old line:

    from path import path

produced pylint errors because of the baroque way that path.py defined
"path".  We tried to get them to change how they defined it, but they
deleted the name instead: https://github.com/jaraco/path.py/issues/102

(Jason then changed his mind, but this is a better way to use path.py,
it avoids the pylint error at least.)
2015-08-27 12:59:25 -04:00
Sarina Canelake
0265ce0af7 Clean i18n directories before validating 2015-08-14 10:20:08 -04:00
Jesse Zoldak
f8766891f0 No need to install prereqs twice on circleci.com 2015-08-06 13:09:06 -04:00
Ben Patterson
c9cf8b6306 Post complexity metric to a file for downstream collection.
This complexity metric is created by using radon (see changed files for additional
documentation links). This tool calculates cyclomatic complexity and provides a numeric grade
where a lower number is better (e.g., less complex).
2015-07-23 15:36:36 -04:00
David Baumgold
2ff0f636ed Revert MySQL-python upgrade 2015-07-15 09:37:04 -04:00
Sarina Canelake
b41e70f541 Remove Pylint violations deprecated-pragma, bad-option-value 2015-07-13 17:33:26 -04:00
Sarina Canelake
ba8fd1c21d Eliminate instances of unused-import Pylint violation 2015-07-13 17:33:25 -04:00
Régis Behmo
95ebf7f675 Upgrade distribute to the latest stable version of setuptools
'distribute' is the ancestor of 'setuptools', and many packages require
setuptools to be installed.

Upgrade of MySQL-python from 1.2.4 to 1.2.5 is required because of an
incompatibility with setuptools>0.7.
2015-07-09 13:04:33 -04:00
Brandon DeRosier
58c7f43f61 Fix the Paver run_all_servers method.
This command was broken by 85814f0b because multi-character short
options were introduced with `--asset_settings_lms` and
`--asset_settings_cms`.
2015-07-07 23:08:29 -04:00
Christine Lytwynec
0bb519c2a0 Merge pull request #8727 from edx/clytwynec/TE-878
use 1 coveragerc file to generate 1 coverage report per build
2015-07-02 12:13:59 -04:00
Andy Armstrong
281ebaa3b3 Merge pull request #8683 from edx/andya/run-optimized-devstack
Support running Studio with optimized assets
2015-07-02 11:39:37 -04:00
Andy Armstrong
85814f0bbf Support running Studio with optimized assets 2015-07-01 18:22:31 -04:00
Christine Lytwynec
e9e4e3cf65 use 1 coveragerc file to generate 1 coverage report per build 2015-07-01 16:07:49 -04:00
Sarina Canelake
13dc7ed485 Fix i18n paver command wrt cleanup 2015-06-29 08:23:14 -04:00
Braden MacDonald
00226bf3c0 Asynchronous metadata fetching using celery beat - PR 8518 2015-06-26 13:24:00 -07:00
Andy Armstrong
aa76d9482a Update Bok Choy to use optimized static assets
TNL-2465
2015-06-25 09:58:27 -04:00
Christine Lytwynec
16745cdec3 pass debug option through to compile_sass 2015-06-23 14:39:06 -04:00
Christine Lytwynec
a1af17e4b1 compile sass in quiet mode unless debug=True 2015-06-17 15:13:47 -04:00
cahrens
5fbad148c9 Jasmine test runner for files in common using RequireJS. 2015-06-15 13:51:16 -04:00
Brian Talbot
5ff2a3af3f tidying up loose ends from sass compilation to css dir change
* adding in missing web certs Sass/CSS asset settings
* updating .gitignore
2015-06-10 14:23:13 -04:00
David Baumgold
a7c710a0de Moved Creative Commons CSS into Sass
Also reconfigured paver to compile Sass into CSS directories
2015-06-09 10:55:20 -04:00
Matt Drayer
af7277cdd9 New Feature: Certificates Web View
- SOL-465: Initial implementation of certificates web view and signatories (names/titles)

- SOL-718 Close button is working properly

- SOL-801 Backbone Signatories Modeling

- SOL-803 Underscore template: Editor (Add)

- SOL-802 Signatories: Underscore template - Details

- SOL-804 Signatories: Underscore template: Editor (Edit)

- Add signatory delete Django view

- SOL-805 Signatory editor (Delete)

- Add Coffeescript router

- SOL-716 Jasmine Tests

- Added missing minified JS library

- client side validation of signatory fields

- SOL-390 signatories names

- Remove obsolete extends Sass files

- input maxlength limiting for signatory information

- SOL-389: Course title override

- SOL-466: Add capability to upload digitized signatures in Studio

- ziafazal: fixed css for upload signature image

- ziafazal: completed deletion of signature images

- UX-1741: Add initial static rendering/styling for Open edX web certs
  * creating new global static dir
  * adding static version of edX UX pattern library assets
  * adding web certificates static assets
  * adding static (+abstracted) web certificates rendering
  * creating two tiers of rendering (base + distinguished)
  * providing sample assets for certificate rendering
  * supporting RTL layouts
  * adding certifcates assests to edX static asset pipeline
  * temporarily hiding the mozilla open badges share action
  * wiring print button to print view/page
  * fixup! addressing conflict artifact in valid cert template
  * fixup! adding missing %hd-subsection sass extend + components comment clean up
  * fixup! correcting pattern library .hd-4 font-weight value

- SOL-468 Linked Student View for Web View Credential

- SOL-467: Add capability to upload organization logos for certificates

- SOL-391 / SOL-387: Signatory related info (assets) in certificates web view

- kelketek: Fixes for static asset collection in certificate HTML view.

- SOL-398 Web View: Public Access

- mattdrayer: Post-merge branch stabilization

- catong: Initial changes to Studio template and Help config file

- ziafazal: Branch stabilizations

- SOL-387: Display organization logo on LMS web view

- talbs/mattdrayer: Branch Stabilizations

- talbs: converting backpack action to use a button HTML element

- talbs: revising placeholder assets + their rendering in cert view

- mattdrayer: Username web view wireup

- SOL-386 Certificate Mode Previews

- SOL-905: Make organization logo and signatory signature uneditable

- SOL-922: Improve test coverage

- SOL-765: Add LinkedIn sharing

- [marco] temporary styling adjustment to account for smaller linkedin share image / fake button

- SOL-921: Address hardcoded template items

- SOL-927: Deleting certificate should delete org logo image also
  * updated invalid template
  * removed hr
  * fix invalid certificate error

- clrux: Add i18n to certificate templates and partials

- mattdrayer: Pylint violations

- SOL-920 Certificate Activation/Deactivation

- mattdrayer: Added LMS support

- SOL-932: Fix preview mode support in certificate view

- SOL-934: Fixed bug reported and broken tests

- SOL-935 removed the 'valid' word from web view title

- talbs: RTL support updates/fixes
  * revising certificate type icon/name vertical alignment
  * removing unused older certificate template
  * revising styling for message/banner actions
  * abstracting accomplishment type to use course mode + adding in honor/verified-specific placeholders

- mattdrayer: JSHint violations
2015-06-01 19:48:04 -04:00
Sarina Canelake
e72d5d542b Add fake Arabic testing language 2015-05-29 10:16:30 -04:00
Ben Patterson
1e47f85359 Merge pull request #8172 from edx/benp/revert-pycontracts-enablement
Revert "Enable PyContracts during tests"
2015-05-26 09:34:05 -04:00
Ben Patterson
c2a0777f78 Merge pull request #8138 from edx/benp/add-jshint
Benp/add jshint
2015-05-22 17:54:55 -04:00
Ben Patterson
aebb35d361 Use jshint in paver, include in builds.
JShint will be executed with paver run_jshint, which will use a defined set of
directories (likewise defined are directories to ignore). A limit can be imposed
on the total number of violations. Note that this change does NOT include adding
jshint to diff-quality or `paver run_quality`.
2015-05-22 16:06:13 -04:00
Ben Patterson
176770efad Revert "Enable PyContracts during tests"
This reverts commit 4312c0e763.
2015-05-22 15:05:11 -04:00
Jesse Zoldak
021e62111e Add ability to specify starting dir for bok-choy tests 2015-05-21 09:46:45 -04:00
Christine Lytwynec
2f6cff5d69 Merge pull request #8128 from edx/clytwynec/fix_cyclic_import_in_pavelib
Fix cyclic import in pavelib
2015-05-20 16:51:10 -04:00
Calen Pennington
a2cbd16680 Merge pull request #7789 from cpennington/wrap-csm
Wrap access to CSM (inside FieldDataCache) to use the new interface
2015-05-20 16:11:07 -04:00
Calen Pennington
4312c0e763 Enable PyContracts during tests 2015-05-20 15:07:18 -04:00
Christine Lytwynec
63233aa5d8 Fix cyclic import in pavelib 2015-05-20 14:11:54 -04:00
Christine Lytwynec
8f22b51117 Merge pull request #8056 from edx/clytwynec/TE-868
use mock_open for paver quality tests
2015-05-15 15:12:01 -04:00
Christine Lytwynec
71bc1476e8 start paver quality tests with clean paver task environment 2015-05-15 10:08:23 -04:00
Ned Batchelder
78e9445aa1 Add super() calls to setUp/tearDown that are missing them
Also, I replaced a number of tearDown methods with addCleanup instead.
And also remove some unneeded patch.stopall() calls.
2015-05-14 18:14:21 -04:00
Christine Lytwynec
657f15638d use mock_open for paver quality tests 2015-05-14 14:51:08 -04:00
Sarina Canelake
e784a43487 Update translations (autogenerated message) 2015-05-08 13:57:58 -04:00
Christine Lytwynec
4f71158057 Merge pull request #7963 from edx/clytwynec/TE-868
skip test that are causing incorrect pep8 reports in jenkins builds
2015-05-08 08:54:24 -04:00
Clinton Blackburn
fc61c292b9 Updated Take Photo page to include verification requirements
As part of the unification of verify later/now, the take photo page needs to list the verification requirements.

XCOM-254
2015-05-07 18:14:33 -04:00
Christine Lytwynec
e13d1858a8 skip test that are causing incorrect pep8 reports in jenkins builds 2015-05-07 14:18:26 -04:00
Christine Lytwynec
2817ce1473 Merge pull request #7913 from edx/clytwynec/unique-dirs-for-test-results
Clytwynec/unique dirs for test results
2015-05-06 14:24:21 -04:00
Ben Patterson
db285cab02 Paver: Ability to run only servers or only tests
This would allow a user to set up and run servers, with an open prompt for killing
them. Likewise a user could open a different terminal session and run tests only.

How-to:
* At a terminal/ssh session, start bok-choy servers with
    `paver test_bokchoy --serversonly`
    (or, if you've already run collectstatic on your system:
    `paver test_bokchoy --serversonly --fasttest`)
* When the above is running, you can now open a separate terminal/ssh session
and run:
    `paver test_bokchoy -t my_tests --testsonly`

Keep in mind, the 'testsonly' flag does no setup. There is some minimal teardown; however,
such as clearing mongo and flushing the lms database. (Some tests have non-unique identifiers
and could not be run more than once.)
2015-05-06 11:49:25 -04:00
Christine Lytwynec
590a64bed1 resolve path differences with coverage combine using a coveragerc file specifically for jenkins
Conflicts:
	scripts/jenkins-report.sh
2015-05-06 11:31:50 -04:00
Christine Lytwynec
41a9e027f0 Revert "Revert "Clytwynec/unique dirs for test results""
This reverts commit 52c4aacad5.
2015-05-04 15:26:11 -04:00
Ned Batchelder
24e0c2c80f Run pylint on all our code, and only our code. TE-855
With the old logic, we weren't running pylint on openedx at all.  We
were also running it on lms/lib/comment_client twice, and on the
installed xblock third-party library.
2015-05-04 15:23:55 -04:00
Christine Lytwynec
52c4aacad5 Revert "Clytwynec/unique dirs for test results" 2015-05-04 10:58:25 -04:00