Commit Graph

5629 Commits

Author SHA1 Message Date
Matthew Piatetsky
013f7bfe34 Merge pull request #26744 from edx/AA-461
[AA-461] Export highlights to s3 for use by braze
2021-03-05 06:46:57 -05:00
Braden MacDonald
7a14c87865 Merge pull request #26535 from edx/ziafazal/annotations_ENABLE_ANNOUNCEMENTS
[TSD] Added annotations for ENABLE_ANNOUNCEMENTS feature flag
2021-03-04 15:15:45 -08:00
Matt Tuchfarber
7f1c5023cd Merge pull request #26841 from edx/tuchfarber/fix_race_condition_cert_date
Move cert date signals to avoid race conditions
2021-03-04 17:40:50 -05:00
Matthew Piatetsky
8d1d7b2222 feat: Export highlights to s3 for use by braze
Things other than highlights may be exported in the future. The storage class is flexible so backends other than s3 may be used in the future.
AA-461
2021-03-04 15:57:30 -05:00
Matt Tuchfarber
6c97dfe1e5 Move cert date signals to avoid race conditions
COURSE_CERT_DATE_CHANGE was being called before saving the new data in
the course overview. The listeners were expecting to pull the data out
of the course overview, and thus were only right about half the time.
This moves the signal to trigger after the course publish signals are
handled.
2021-03-04 15:57:21 -05:00
adeel khan
18aa50ec0f Merge pull request #26853 from edx/adeel/van_178_change_shadow_box_background_color
Change email shadow box color
2021-03-04 18:55:53 +05:00
Adeel Khan
416546791d Change email shadow box color
VAN-178
2021-03-04 18:18:32 +05:00
Adeel Khan
883fffd2c6 Reduce top padding by half for emails
VAN-177
2021-03-04 17:28:41 +05:00
zia.fazal@arbisoft.com
d45d978aab Added annotations for ENABLE_ANNOUNCEMENTS feature flag
fixed quality violations

Changed indentation
2021-03-04 16:44:40 +05:00
Adeel Khan
231dd68f90 Make button style primary
VAN-274
2021-03-04 07:50:09 +05:00
jawad khan
948d6351b6 LEARNER-8251 - Added BearerAuthenticationAllowInactiveUser in courseware view (#26829)
Added BearerAuthenticationAllowInactiveUser in courseware view
2021-03-03 18:39:42 +05:00
Azan Bin Zahid
936f19fa12 Merge pull request #26797 from edx/azan/PROD-2281
add user id (staff only) field in user_api
2021-03-03 15:22:27 +05:00
azanbinzahid
0ef2ba7e7c add lms user id in accounts endpoint 2021-03-03 14:27:44 +05:00
Michael Roytman
eb98d7fac5 MST-675: QuerySet Performance for StudentOnboardingStatusByCourse Endpoint (#26789)
* The original use of user.has_perm('can_take_proctored_exam') in the get_active_enrollments_for_course method had very poor performance when used for multiple learners. The permission is not designed for use in bulk operations. It was being called for each user in a loop by edx-proctoring, resulting in many queries to the database. This lead to timeouts on the client. This change exposes a new service endpoint that performs this permission checking in the database, resulting in one single query to the necessary LMS SQL tables and many fewer queries to the modulestore.

* bump version of edx-proctoring to 3.7.3
2021-03-02 19:46:58 -05:00
Michael Terry
877e8f1e83 Merge pull request #26803 from edx/mikix/nudge2
feat: add 'external course updates' experiment flag
2021-03-02 15:46:54 -05:00
Michael Terry
9570c1c72b feat: add 'external course updates' experiment flag
When this flag is enabled, users will be 50/50 bucketed into an
experiment where users get course highlights and nudges from an
external service (like sailthru or braze) rather than from
edx-platform via ACE.

AA-661
2021-03-02 14:51:45 -05:00
Carla Duarte
7ecb393deb AA-510: a11y fix for learner dashboard enterprise link 2021-03-02 11:37:10 -05:00
Kyle McCormick
e792242b5f refactor!: remove redundant ENABLE_COURSEWARE_MICROFRONTEND toggle (#26792)
The Django setting
FEATURES['ENABLE_COURSEWARE_MICROFRONTEND']
has been an additional gate to activating
usage of the Learning MFE for an Open edX
instance.

The toggle is redundant with the
`courseware.courseware_mfe`
Waffle flag. By removing it, we simplify our config
and simplify our path towards making the Learning MFE
the default courseware experience.

TNL-7796
2021-03-02 11:36:43 -05:00
Usman Khalid
dd96a2aa72 Convert Course, Section and Sequence XModules to XBlocks. (#25965) 2021-03-02 10:29:33 -05:00
Feanil Patel
6e4e7648a5 Merge pull request #26790 from edx/feanil/fix-annotations
doc: Correctly annotate the setting name.
2021-03-02 10:19:01 -05:00
Zainab Amir
11791e25d4 VAN-367: Track optional and goals field usage (#26779) 2021-03-02 14:26:44 +05:00
Feanil Patel
d2343b1f07 doc: Correctly annotate the setting name.
The `setting_name` annotation needed a space before it so that it's
picked up properly by the toggle annotations tooling.
2021-03-01 16:35:41 -05:00
Dillon Dumesnil
7b1d4bcfc0 Merge pull request #26784 from edx/ddumesnil/update-entitlement-session-aa-682
AA-682: Update the pseudo session fallback session
2021-03-01 07:40:52 -08:00
Dillon Dumesnil
8bbea7f89a AA-682: Update the pseudo session fallback session
There was a bug where the earliest course returned for a pseudo session
(when there were no available sessions) might not exist in modulestore and
would cause a 500 error. The data problem is another issue that will need to
be fixed, but by switching to the most recent session in this scenario, we believe
we will reduce the likelihood of this error occurring. We also believe the most
recent session is a better return value than the first ever session.
2021-03-01 09:33:31 -05:00
Zainab Amir
773810e176 VAN-367: Capture optional fields usage (#26775) 2021-03-01 13:03:07 +05:00
Sofiane Bebert
018786489b doc: annotate relative_dates waffle flag 2021-02-27 12:49:18 +00:00
stvn
e52de0414a Merge PR #26752 cleanup/middleware-classes
* Commits:
  docs: Update references to Django MIDDLEWARE_CLASSES
2021-02-26 08:58:42 -08:00
stvn
b033b0d13d docs: Update references to Django MIDDLEWARE_CLASSES
As code was already updated (~1 year ago) in #23070.
A first attempt was made in #18342, which can now be closed.

References: https://github.com/edx/edx-platform/pull/23070
References: https://github.com/edx/edx-platform/pull/18342
2021-02-25 20:00:09 -08:00
stvn
09e20a4a75 fix: Upsize LTI Discussions iframe, 400px -> 800px
Otherwise, there's too much scrolling.

Fixes: https://openedx.atlassian.net/browse/TNL-7996
2021-02-25 19:39:09 -08:00
stvn
8314971e0b refactor: Convert discussions to pluggable app
This minimizes our footprint outside of the djangoapp, now and moving
forward. Not only can we drop the `lms/envs/common.py` change, but we
can also avoid touching `lms/urls.py` when we add the API. Everything
can stay contained within `openedx/core/djangoapps/discussions`.
2021-02-25 18:51:25 -08:00
Justin Hynes
d6fa4de4b2 Merge pull request #26632 from edx/jhynes/log_exception_awarding_prog_certs
Log error when failing to award program certificate
2021-02-25 11:52:10 -05:00
Justin Hynes
03d788fc5b Log error when failing to award program certificate 2021-02-25 10:25:49 -05:00
Zachary Hancock
1af3b5a68c runtime service exposing learning_sequences api to proctoring (#26692) 2021-02-24 17:25:49 -05:00
Kyle McCormick
558d2eb52c refactor: centralize learning MFE URL-building logic (#26689)
In preparation for switching LMS/Studio over
from serving legacy courseware URLs in certain
places (for example, resume_course_url) to serving
learning micro-frontend URLs.

TNL-7796
2021-02-24 08:50:15 -05:00
Adeel Khan
d9ec42c425 Add throttling to validate token and reset password end points
VAN-312
2021-02-24 06:47:18 +05:00
Michael Terry
23f34031d1 Merge pull request #26663 from edx/mikix/enable-schedules
feat: turn on schedule creation by default
2021-02-23 14:34:11 -05:00
Michael Terry
74887aa216 feat: turn on schedule creation by default
This commit removes several waffle toggles that have been enabled
on edx.org for years. It's time to remove the rollout gating for
these features and enable them by default.

This doesn't directly change any behavior. But it does create new
database objects by default now and allows for enabling other
schedule based features more easily.

Specifically, the following toggles were affected.

schedules.create_schedules_for_course
- Waffle flag removed as always-enabled
- We now always create a schedule when an enrollment is created

schedules.send_updates_for_course
- Waffle flag removed as always-enabled
- Course update emails are sent as long as the ScheduleConfig
  allows it.
- This is not a change in default behavior, because ScheduleConfig
  is off by default.

dynamic_pacing.studio_course_update
- Waffle switch removed as always-enabled
- Course teams can now always edit course updates directly in Studio

ScheduleConfig.create_schedules
ScheduleConfig.hold_back_ratio
- Model fields for rolling out the schedules feature
- Schedules are now always created
- This commit only removes references to these fields, they still
  exist in the database. A future commit will remove them entirely

This commit also adds a new has_highlights field to CourseOverview.
This is used to cache whether a course has highlights, used to
decide which course update email behavior they get. Previously every
enrollment had to dig into the modulestore to determine that.
2021-02-23 12:34:02 -05:00
Robert Raposa
40611bb915 ARCHBOM-1667: fix: remove authentication from auth exchange (#26618)
* Remove authentication, including SessionAuthentication, to fix CSRF
  exemption by dropping CSRF check of SessionAuthentication.
* Several changes to make it more clear that only POST is supported and
  clean up GET method testing.
* Removed the temporary 403 error logging that wasn't working.
* Removed test_single_access_token which was written for DOP, but
  doesn't work with DOT. See
  [MA-2122](https://openedx.atlassian.net/browse/MA-2122) for a ticket
  about implementing this for DOT, although it doesn't seem to be a
  priority. NOTE: A comment was added to the ticket explaining that this
  test was removed.
* GET now returns default error for methods not allowed.

ARCHBOM-1667
2021-02-23 10:57:11 -05:00
M. Zulqarnain
42fc6aef03 Upgrade django-ipware (#24827) 2021-02-23 18:14:17 +05:00
Matthew Piatetsky
789af8d4ac Merge pull request #26409 from edx/AA-304
[AA-304] Create backend for three day streak celebration
2021-02-22 11:19:39 -05:00
Matt Tuchfarber
5345466e31 Merge pull request #26622 from edx/tuchfarber/remove_pii_from_mgmt_cmd_cfg
Update mgmt cmds to use user_ids instead of PII
2021-02-22 11:04:49 -05:00
Matthew Piatetsky
3b45a72b8e Create backend for three day streak celebration
This feature uses the first_day_of_streak, last_day_of_streak and last_streak_celebration fields to determine whether the user should see a celebration.
AA-304
2021-02-22 10:50:33 -05:00
Matt Tuchfarber
55d9e18495 Update mgmt cmds to use user_ids instead of PII 2021-02-22 10:30:35 -05:00
Aarif
813064ad49 replaced unittest assertions pytest assertions (#26574) 2021-02-22 20:04:51 +05:00
Aarif
c21ac0c3df replaced unittest assertions pytest assertions (#26573) 2021-02-22 20:04:27 +05:00
Aarif
cbf78fbdf3 replaced unittest assertions pytest assertions (#26572) 2021-02-22 20:04:00 +05:00
Aarif
4ef7d63211 replaced unittest assertions pytest assertions (#26571) 2021-02-22 20:03:33 +05:00
usamasadiq
96f0915b0f Fixed new pylint warnings.
use generator in any/all()
disable not-callable warnings
disable no-member warnings
Suppressed smaller pylint warnings
Pin edx-proctoring==3.5.0
2021-02-22 16:36:53 +05:00
Aarif
93a4f96e30 replaced unittest assertions pytest assertions (#26575) 2021-02-22 16:19:37 +05:00
Aarif
b58ea1f03c replaced unittest assertions pytest assertions (#26576) 2021-02-22 16:18:51 +05:00