Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #26632 from edx/jhynes/log_exception_awarding_prog_certs

Browse Source 
Log error when failing to award program certificate
This commit is contained in:
Justin Hynes
2021-02-25 11:52:10 -05:00
committed by GitHub
parent d4ab4d45ba 03d788fc5b
commit d6fa4de4b2
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openedx/core/djangoapps/programs/tasks.py
View File

@@ -255,9 +255,9 @@ def award_program_certificates(self, username): # lint-amnesty, pylint: disable
f"Unable to award certificate to user {username} for program {program_uuid}. "
"The program might not be configured."
)
except Exception: # pylint: disable=broad-except
except Exception as exc: # pylint: disable=broad-except
# keep trying to award other certs, but retry the whole task to fix any missing entries
LOGGER.warning(f"Failed to award certificate for program {program_uuid} to user {username}.")
LOGGER.exception(f"Failed to award certificate for program {program_uuid} to user {username}.")
failed_program_certificate_award_attempts.append(program_uuid)
if failed_program_certificate_award_attempts:

2
openedx/core/djangoapps/programs/tests/test_tasks.py
View File

@@ -343,7 +343,7 @@ class AwardProgramCertificatesTestCase(CatalogIntegrationMixin, CredentialsApiCo
mock_award_program_certificate.side_effect = self._make_side_effect([Exception('boom'), None])
with mock.patch(TASKS_MODULE + '.LOGGER.info') as mock_info, \
mock.patch(TASKS_MODULE + '.LOGGER.warning') as mock_warning:
mock.patch(TASKS_MODULE + '.LOGGER.exception') as mock_warning:
tasks.award_program_certificates.delay(self.student.username).get()
assert mock_award_program_certificate.call_count == 3