Commit Graph

20546 Commits

Author SHA1 Message Date
Mahyar Damavand
025d0f07cb Reveal a message to be extracted 2020-01-26 18:46:46 +03:30
Jansen Kantor
25baa93af9 EDUCATOR-4877: Implement stubbed API functions using new config values (#22913)
add stubbed api functions, tests
2020-01-24 15:54:32 -05:00
Matthew Piatetsky
978f72cfac Merge pull request #22925 from edx/REV-1071
[REV-1071] add more incomes
2020-01-24 10:32:01 -05:00
adeelehsan
796b81c2d8 Merge pull request #22877 from edx/aehsan/prod-1153/add_warning_in_certificate_template_asset_admin
Warning added in admin
2020-01-24 17:04:21 +05:00
adeelehsan
b44f1e9c1c Warning added in admin
PROD-1153
2020-01-24 16:31:42 +05:00
Kyle McCormick
cdb0619846 Revert "Remove CourseOverview.get_from_id[s]_if_exists (#22918)" (#22926)
This reverts commit 3ca006214e.
2020-01-23 13:52:11 -05:00
Matthew Piatetsky
5779bd1584 add more incomes 2020-01-23 12:03:42 -05:00
Jeff Witt
9fa49606f8 update instruction text per W3C request 2020-01-23 11:35:59 -05:00
Kyle McCormick
3ca006214e Remove CourseOverview.get_from_id[s]_if_exists (#22918)
The functions `CourseOverview.get_from_id_if_exists`
and `CourseOverview.get_from_ids if exists` are bug-
prone, in that they do not go to the modulestore
when a CourseOverview is out-of-date or uncached.
The docstrings spell this out, but callers seem
not to understand the implications.

So, in this commit, we:
* Remove both functions
* Add `CourseOverview.get_from_ids` for almost-as-fast
  yet safer bulk-fetching of overviews
* Update call sites to use `course_exists` or `get_from_ids`
  in place of the old functions.
* Add tests for @verify_course_exists.
This PR should specifically fix an issue where
the program_enrollments API was breaking when the CourseOverview
version was bumped.

CR-1708
2020-01-23 09:41:55 -05:00
hunytalk
73aae081c3 Remove null, blank from start field in Schedules 2020-01-22 18:10:33 +05:00
Ahtisham Shahid
df25e91648 Merge pull request #22900 from edx/ahtisham/PROD-726
Updated border color on login page fields Ally
2020-01-22 15:46:37 +05:00
adeelehsan
f711465862 Merge pull request #22885 from edx/aehsan/fetch_lms_root_url_from_configuration
fetch lms root url using configuration helper
2020-01-22 15:40:04 +05:00
M Zulqarnain
4eea92640c Merge pull request #22907 from edx/zulqarnain/BOM-1132
BOM-1132 : Change deprecated storage methods signatures
2020-01-22 14:04:08 +05:00
Aarif
fd8c8f09e1 Merge pull request #22891 from edx/BOM-1148
Added the app_name to URL inclusions to remove warnings - BOM-1148
2020-01-22 12:50:36 +05:00
Ned Batchelder
079d17b899 Remove code that is now in edx_api_doc_tools 2020-01-21 11:15:41 -05:00
iamsobanjaved
38493d5092 Removed app_name warning from django.conf.urls.include() 2020-01-21 20:38:27 +05:00
Zulqarnain
644a1fc0a6 Change deprecated methods signatures 2020-01-21 16:33:37 +05:00
Ahtisham Shahid
03e7ec97aa Updated border color on login page fields 2020-01-20 16:40:59 +05:00
adeel khan
8f9dfaba49 Merge pull request #22892 from edx/adeel/prod_1178_add_remove_footer_logo
Adds instagram and removes google-plus footer links
2020-01-20 13:29:42 +05:00
adeelehsan
35fb321a89 fetch lms root url using configuration helper
PROD-1063:
2020-01-20 12:58:34 +05:00
Aarif
84afadb4e7 Merge pull request #22886 from edx/BOM-1155
Removed the deprecated app_name usage from lms/urls.py BOM-1155
2020-01-20 12:09:08 +05:00
Adeel Khan
4b6cf4801c Adds instagram and removes google-plus footer links
PROD-1178
2020-01-17 23:27:28 +05:00
Jansen Kantor
2043a29477 change lms team config (#22893) 2020-01-17 11:40:12 -05:00
David Ormsbee
0800f5f226 Merge pull request #22837 from open-craft/youtube-metadata-new-runtime
Add way to get YouTube metadata that doesn't require a session cookie
2020-01-17 11:02:05 -05:00
Aarif
9cca22fd8f removed deprecated app_name 2020-01-17 13:00:40 +05:00
adeelehsan
3894021ada Merge pull request #22585 from edx/aehsan/prod-1063/added_unsubscribe_link_in_bulk_email
Unsubscribe link added in bulk emails
2020-01-17 12:23:39 +05:00
Braden MacDonald
c7d5efb796 Add way to get YouTube metadata that doesn't require a session cookie
The Video Player XBlock will sometimes make API calls to /couses/yt_video_metadata, a REST API endpoint that in turn loads video metadata from YouTube using the configured settings.YOUTUBE_API_KEY.

However, in the Blockstore-based XBlock runtime, we are running XBlocks in a secure sandbox, and the user's browser cannot pass session cookies when calling REST API endpoints. So currently, the video XBlock tries to request YouTube metadata from that API endpoint, but it fails if run within such a sandbox.

The existing API also doesn't work for anonymous users (users who are allowed to see video XBlocks but who have not logged in to an LMS user account).

This commit updates the Video XBlock so that it can use a handler to load the data from YouTube instead of a generic REST API. This works well in the new runtime, because it has code to support calling handlers within the sandbox, including by anonymous users.

I also fixed a bug where on a default devstack, the endpoint will try calling YouTube using PUT_YOUR_API_KEY_HERE as an API key, and get a "bad request" error from YouTube.

The code could be re-organized by moving things around, but I've left everything as-is for now to keep the diff as small as possible.
2020-01-16 13:25:16 -08:00
adeel khan
425f9368ea Merge pull request #22869 from edx/adeel/prod_604_fix_footer_link
Fix footer link for wcag.
2020-01-16 18:52:45 +05:00
Awais Qureshi
391c4aecb6 Merge pull request #22674 from edx/awais786/BOM-1126
BOM-1126
2020-01-16 10:44:21 +05:00
Adeel Khan
c06e7cecc0 Fix footer link for wcag.
PROD-604
2020-01-16 03:24:19 +05:00
Jansen Kantor
cec55074e8 jkantor/teamconfig (#22863)
Add TeamsConfigurationService to lms xblock runtime
2020-01-15 14:27:27 -05:00
Awais Qureshi
220cab965f BOM-1126
Removing the moto from repo.
2020-01-15 22:34:13 +05:00
adeelehsan
12708a093d Unsubscribe link added in bulk emails 2020-01-15 16:56:35 +05:00
M Zulqarnain
e5407a31ee Merge pull request #22841 from mzulqarnain1/zulqarnain/BOM-1147
BOM-1147 -- Create a code mod for Widget.render change
2020-01-15 11:35:58 +05:00
Jansen Kantor
b2f69fc803 EDUCATOR-4858: Update teams service to consider teamset/topic (#22834)
* update teams service and api to consider topic
2020-01-14 16:06:27 -05:00
Julia Eskew
84de6bc6de Revert "This stage does the following: (#22692)"
This reverts commit cebeab4348.
2020-01-14 13:01:21 -05:00
Nicholas D'Alfonso
796f1802d2 remove left boarder from upcoming dates 2020-01-14 10:56:02 -05:00
Julia Eskew
cebeab4348 This stage does the following: (#22692)
- Adds the new field and migration to create the column.
- Makes all writes go to both old and new field.
2020-01-14 10:40:39 -05:00
Zulqarnain
e6a6fd15d4 Merge branch 'master' into zulqarnain/BOM-1147 2020-01-14 15:23:43 +05:00
Zulqarnain
834079104b BOM-1147 Widget.render change 2020-01-14 15:15:19 +05:00
Nicholas D'Alfonso
3ad963b8a7 AA-3 course dates cleanup
-change Important Course Dates to Upcoming Dates
-remove today's date
-left align date, right aling rest of info
2020-01-13 14:58:23 -05:00
Brittney Exline
e33b4614af ENT-2475 Upgrading edx-enterprise and adding settings for enterprise catalog service 2020-01-13 09:36:20 -05:00
Awais Qureshi
3eb4154c6b Merge pull request #22742 from edx/wiki-ver
BOM-1126
2020-01-13 19:01:22 +05:00
Usama Sadiq
6349606b55 Merge pull request #22774 from edx/usama/bom-1140
Updated LtiBackend.authenticate() method
2020-01-13 11:50:37 +05:00
Mahyar Damavand
532f3e80fa Delete extra parentheses which prevented a message from being extracted 2020-01-12 17:17:51 +03:30
Awais Qureshi
48dbebd28f Bom-1146
In mobile-api model PLATFORM_CLASSES tuple of list and make migrations generate new migration due to different order.
2020-01-10 18:10:05 +05:00
usama sadiq
889f7d492d Updated LtiBackend.authenticate() method
Added a positional `request` arugment in the function header.
2020-01-10 17:00:22 +05:00
usama sadiq
720dcb6c3a Updated ExceptionViews handles
Added additional 'exception' parameter to function headers.
Disabled pylint warnings for missing docstring and unused arguments.
2020-01-10 15:56:24 +05:00
Waheed Ahmed
833af45ef4 Fix course about page video. (#22775)
PROD-1124
2020-01-09 17:43:31 +05:00
Awais Qureshi
4eb1a98f21 BOM-1108
Updating wiki.
2020-01-09 14:49:50 +05:00