Updated LtiBackend.authenticate() method

Added a positional `request` arugment in the function header.
This commit is contained in:
usama sadiq
2020-01-09 16:30:19 +05:00
committed by usamasadiq
parent e7f112c61c
commit 889f7d492d
2 changed files with 9 additions and 1 deletions

View File

@@ -199,9 +199,13 @@ class LtiBackendTest(TestCase):
lti_user_id=self.lti_user_id,
edx_user=self.edx_user
).save()
self.old_user = UserFactory.create()
self.request = RequestFactory().post('/')
self.request.user = self.old_user
def test_valid_user_authenticates(self):
user = users.LtiBackend().authenticate(
self.request,
username=self.edx_user.username,
lti_user_id=self.lti_user_id,
lti_consumer=self.lti_consumer
@@ -210,6 +214,7 @@ class LtiBackendTest(TestCase):
def test_missing_user_returns_none(self):
user = users.LtiBackend().authenticate(
self.request,
username=self.edx_user.username,
lti_user_id='Invalid Username',
lti_consumer=self.lti_consumer
@@ -220,12 +225,14 @@ class LtiBackendTest(TestCase):
non_edx_user = UserFactory.create()
non_edx_user.save()
user = users.LtiBackend().authenticate(
self.request,
username=non_edx_user.username,
)
self.assertIsNone(user)
def test_missing_lti_id_returns_null(self):
user = users.LtiBackend().authenticate(
self.request,
username=self.edx_user.username,
lti_consumer=self.lti_consumer
)
@@ -233,6 +240,7 @@ class LtiBackendTest(TestCase):
def test_missing_lti_consumer_returns_null(self):
user = users.LtiBackend().authenticate(
self.request,
username=self.edx_user.username,
lti_user_id=self.lti_user_id,
)

View File

@@ -119,7 +119,7 @@ class LtiBackend(object):
identity (i.e. the user was created by the create_lti_user method above).
"""
def authenticate(self, username=None, lti_user_id=None, lti_consumer=None):
def authenticate(self, _request, username=None, lti_user_id=None, lti_consumer=None):
"""
Try to authenticate a user. This method will return a Django user object
if a user with the corresponding username exists in the database, and