Fix notification issue, sanitize input html

This commit is contained in:
Vik Paruchuri
2013-01-25 09:55:47 -05:00
parent a5daf1f34d
commit fde370bd92
3 changed files with 5 additions and 4 deletions

View File

@@ -554,7 +554,7 @@ class OpenEndedModule(openendedchild.OpenEndedChild):
# add new history element with answer and empty score and hint.
self.new_history_entry(get['student_answer'])
get['student_answer'] = self.sanitize_html(get['student_answer'])
get['student_answer'] = OpenEndedModule.sanitize_html(get['student_answer'])
self.send_to_grader(get['student_answer'], system)
self.change_state(self.ASSESSING)

View File

@@ -131,7 +131,8 @@ class OpenEndedChild(object):
return ""
return self.history[-1].get('post_assessment', "")
def sanitize_html(self, answer):
@staticmethod
def sanitize_html(answer):
cleaner = Cleaner(style=True, links=True, add_nofollow=True, page_structure=True, safe_attrs_only=True)
clean_html = cleaner.clean_html(answer)
return clean_html
@@ -142,7 +143,7 @@ class OpenEndedChild(object):
@param answer: The student supplied answer
@return: None
"""
answer = self.sanitize_html(answer)
answer = OpenEndedChild.sanitize_html(answer)
self.history.append({'answer': answer})
def record_latest_score(self, score):

View File

@@ -133,7 +133,7 @@ def _peer_grading(tab, user, course, active_page):
return []
def _combined_open_ended_grading(tab, user, course, active_page):
if user.is_authenticated:
if user.is_authenticated():
link = reverse('open_ended_notifications', args=[course.id])
tab_name = "Open Ended Panel"