Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove user.joined_date from holdback as this condition will create a difference in the two a/b groups

Browse Source
This commit is contained in:
Emma Green
2019-08-21 10:15:12 -04:00
parent 4461d978db
commit fc003c428d
2 changed files with 6 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
openedx/features/discounts/applicability.py
View File

@@ -91,9 +91,6 @@ def _is_in_holdback(user):
if datetime(2020, 8, 1, tzinfo=pytz.UTC) <= datetime.now(tz=pytz.UTC):
return False
if not datetime(2019, 8, 1, tzinfo=pytz.UTC) <= user.date_joined <= datetime(2019, 11, 1, tzinfo=pytz.UTC):
return False
# Holdback is 50/50
bucket = stable_bucketing_hash_group(DISCOUNT_APPLICABILITY_HOLDBACK, 2, user.username)

26
openedx/features/discounts/tests/test_applicability.py
View File

@@ -122,26 +122,12 @@ class TestApplicability(ModuleStoreTestCase):
@ddt.unpack
def test_holdback_group_ids(self, group_number, in_holdback):
with patch('openedx.features.discounts.applicability.stable_bucketing_hash_group', return_value=group_number):
with patch.object(self.user, 'date_joined', datetime(2019, 8, 1, 0, 1, tzinfo=pytz.UTC)):
assert _is_in_holdback(self.user) == in_holdback
@ddt.data(
(datetime(2019, 7, 31, tzinfo=pytz.UTC), False),
(datetime(2019, 8, 1, 0, 1, tzinfo=pytz.UTC), True),
(datetime(2019, 10, 30, 23, 59, tzinfo=pytz.UTC), True),
(datetime(2019, 11, 1, 0, 1, tzinfo=pytz.UTC), False),
)
@ddt.unpack
def test_holdback_registration_limits(self, registration_date, in_holdback):
with patch('openedx.features.discounts.applicability.stable_bucketing_hash_group', return_value=0):
with patch.object(self.user, 'date_joined', registration_date):
assert _is_in_holdback(self.user) == in_holdback
assert _is_in_holdback(self.user) == in_holdback
def test_holdback_expiry(self):
with patch('openedx.features.discounts.applicability.stable_bucketing_hash_group', return_value=0):
with patch.object(self.user, 'date_joined', datetime(2019, 8, 1, 0, 1, tzinfo=pytz.UTC)):
with patch(
'openedx.features.discounts.applicability.datetime',
Mock(now=Mock(return_value=datetime(2020, 8, 1, 0, 1, tzinfo=pytz.UTC)))
):
assert not _is_in_holdback(self.user)
with patch(
'openedx.features.discounts.applicability.datetime',
Mock(now=Mock(return_value=datetime(2020, 8, 1, 0, 1, tzinfo=pytz.UTC)))
):
assert not _is_in_holdback(self.user)