Updates course about date conditionals

- Formatted date start strings can contain unicode, so six.string_types is a better `is_instance` check
- "end_date" is no longer a required key in the `get_course_about_section` dictionary, so that check can fail and is bad.
This commit is contained in:
Giulio Gratta
2018-01-19 15:36:17 -08:00
parent 1a1e3b8a44
commit f7795f8a68

View File

@@ -245,7 +245,7 @@ from six import string_types
% endif
## We plan to ditch end_date (which is not stored in course metadata),
## but for backwards compatibility, show about/end_date blob if it exists.
% if get_course_about_section(request, course, "end_date") or course.end:
% if course.end:
<%
course_end_date = course.end
%>
@@ -253,7 +253,7 @@ from six import string_types
<li class="important-dates-item">
<span class="icon fa fa-calendar" aria-hidden="true"></span>
<p class="important-dates-item-title">${_("Classes End")}</p>
% if isinstance(course_end_date, str):
% if isinstance(course_end_date, string_types):
<span class="important-dates-item-text final-date">${course_end_date}</span>
% else:
<%