Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Course home event clean-up.

Browse Source 
- Convert hero events to BI events.
- Upgrade click event clean-up

LEARNER-2026
This commit is contained in:
Robert Raposa
2017-10-05 14:10:50 -04:00
parent 07061caf91
commit e8945ebdc5
4 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lms/static/js/courseware/course_home_events.js
View File

@@ -9,7 +9,7 @@
});
});
$('.date-summary-verified-upgrade-deadline .date-summary-link').on('click', function() {
Logger.log('edx.course.enrollment.upgrade.clicked', {location: 'sidebar'});
Logger.log('edx.course.enrollment.upgrade.clicked', {location: 'date-sidebar'});
});
};
});

6
lms/static/js/spec/courseware/course_home_events_spec.js
View File

@@ -17,9 +17,11 @@ define(['jquery', 'logger', 'js/courseware/course_home_events'], function($, Log
});
});
it('sends an event when "Upgrade to Verified" is clicked from the sidebar', function() {
it('sends an event when "Upgrade to Verified" is clicked from the date sidebar', function() {
$('.date-summary-link').click();
expect(Logger.log).toHaveBeenCalledWith('edx.course.enrollment.upgrade.clicked', {location: 'sidebar'});
expect(Logger.log).toHaveBeenCalledWith('edx.course.enrollment.upgrade.clicked',
{location: 'date-sidebar'}
);
});
});
});

9
openedx/features/course_experience/static/course_experience/js/CourseHome.js
View File

@@ -96,7 +96,7 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
const $vcDismissToggle = $('.vc-toggle', $vcMessage);
const logEventProperties = { courseRunKey: this.courseRunKey };
Logger.log('edx.course.upgrade.hero.displayed', logEventProperties);
Logger.log('edx.bi.course.upgrade.hero.displayed', logEventProperties);
// Get height of container and button
let vcHeight = $vcMessage.outerHeight();
@@ -125,7 +125,7 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
$vcDismissToggle.click(() => {
if ($vcMessage.hasClass('polite')) {
// Expand message
Logger.log('edx.course.upgrade.hero.expanded', logEventProperties);
Logger.log('edx.bi.course.upgrade.hero.expanded', logEventProperties);
this.persistUpgradeMessageState(false);
$('.vc-fade').fadeOut(400);
@@ -136,14 +136,15 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
});
} else {
// Collapse message
Logger.log('edx.course.upgrade.hero.collapsed', logEventProperties);
Logger.log('edx.bi.course.upgrade.hero.collapsed', logEventProperties);
this.persistUpgradeMessageState(true);
collapseMessage();
}
});
$('.btn-upgrade', $vcMessage).click(() => {
Logger.log('edx.course.upgrade.hero.clicked', logEventProperties);
Logger.log('edx.bi.course.upgrade.hero.clicked', logEventProperties);
Logger.log('edx.course.enrollment.upgrade.clicked', { location: 'hero' });
});
}
}

5
openedx/features/course_experience/static/course_experience/js/spec/CourseHome_spec.js
View File

@@ -57,13 +57,14 @@ describe('Course Home factory', () => {
it('should send events to Segment and edX on initial load', () => {
expect(window.analytics.track).toHaveBeenCalledWith('Promotion Viewed', segmentEventProperties);
expect(Logger.log).toHaveBeenCalledWith('edx.course.upgrade.hero.displayed', { courseRunKey: runKey });
expect(Logger.log).toHaveBeenCalledWith('edx.bi.course.upgrade.hero.displayed', { courseRunKey: runKey });
});
it('should send events to Segment and edX after clicking the upgrade button ', () => {
$('.vc-message .btn-upgrade').click();
expect(window.analytics.track).toHaveBeenCalledWith('Promotion Viewed', segmentEventProperties);
expect(Logger.log).toHaveBeenCalledWith('edx.course.upgrade.hero.clicked', { courseRunKey: runKey });
expect(Logger.log).toHaveBeenCalledWith('edx.bi.course.upgrade.hero.clicked', { courseRunKey: runKey });
expect(Logger.log).toHaveBeenCalledWith('edx.course.enrollment.upgrade.clicked', { location: 'hero' });
});
});