Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add public video share valid course key check (#33260)

Browse Source
This commit is contained in:
Kristin Aoki
2023-09-15 09:05:59 -04:00
committed by GitHub
parent 202e79093c
commit e820162572
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
xmodule/video_block/video_block.py
View File

@@ -487,7 +487,6 @@ class VideoBlock(
'transcript_download_format': transcript_download_format,
'transcript_download_formats_list': self.fields['transcript_download_format'].values, # lint-amnesty, pylint: disable=unsubscriptable-object
}
if self.is_public_sharing_enabled():
public_video_url = self.get_public_video_url()
template_context['public_sharing_enabled'] = True
@@ -517,9 +516,12 @@ class VideoBlock(
"""
Is public sharing enabled for this video?
"""
# Video share feature must be enabled for sharing settings to take effect
feature_enabled = PUBLIC_VIDEO_SHARE.is_enabled(self.location.course_key)
try:
# Video share feature must be enabled for sharing settings to take effect
feature_enabled = PUBLIC_VIDEO_SHARE.is_enabled(self.location.course_key)
except Exception as err: # pylint: disable=broad-except
log.exception(f"Error retrieving course for course ID: {self.location.course_key}")
return False
if not feature_enabled:
return False