Registration: don't require terms of service if checkbox is hidden

This commit is contained in:
Omar Khan
2016-02-24 12:35:08 +07:00
parent d114be732f
commit e461374973
2 changed files with 11 additions and 1 deletions

View File

@@ -1628,7 +1628,7 @@ def create_account_with_params(request, params):
not do_external_auth
)
# Can't have terms of service for certain SHIB users, like at Stanford
tos_required = (
tos_required = settings.REGISTRATION_EXTRA_FIELDS.get('terms_of_service') != 'hidden' and (
not settings.FEATURES.get("AUTH_USE_SHIB") or
not settings.FEATURES.get("SHIB_DISABLE_TOS") or
not do_external_auth or

View File

@@ -1683,6 +1683,16 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, ApiTestCase):
}
)
@override_settings(REGISTRATION_EXTRA_FIELDS={"honor_code": "hidden", "terms_of_service": "hidden"})
def test_register_hidden_honor_code_and_terms_of_service(self):
response = self.client.post(self.url, {
"email": self.EMAIL,
"name": self.NAME,
"username": self.USERNAME,
"password": self.PASSWORD,
})
self.assertHttpOK(response)
def test_missing_fields(self):
response = self.client.post(
self.url,