Update wait for mini-notification in testing to be more fine-grained; remove flaky test decorator

This commit is contained in:
Jesse Shapiro
2016-11-10 15:07:32 -05:00
parent f05899b2ba
commit dffe3e0780
2 changed files with 12 additions and 3 deletions

View File

@@ -17,8 +17,18 @@ def wait_for_notification(page):
"""Whether or not the notification is finished showing."""
return page.q(css='.wrapper-notification-mini.is-hiding').present
EmptyPromise(_is_saving, 'Notification should have been shown.', timeout=60).fulfill()
EmptyPromise(_is_saving_done, 'Notification should have been hidden.', timeout=60).fulfill()
EmptyPromise(
_is_saving,
'Notification should have been shown.',
try_interval=0.1,
timeout=60,
).fulfill()
EmptyPromise(
_is_saving_done,
'Notification should have been hidden.',
try_interval=0.1,
timeout=60,
).fulfill()
def click_css(page, css, source_index=0, require_notification=True):

View File

@@ -129,7 +129,6 @@ class LibraryEditPageTest(StudioLibraryTest):
"""
self.assertFalse(self.browser.find_elements_by_css_selector('span.large-discussion-icon'))
@flaky # TODO fix this, see TNL-2322
def test_library_pagination(self):
"""
Scenario: Ensure that adding several XBlocks to a library results in pagination.