Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #25009 from edx/feanil/fix_flaky_test

Browse Source 
Fix a flaky test by freezing time in the right spot.
This commit is contained in:
Feanil Patel
2020-09-21 12:15:28 -04:00
committed by GitHub
parent f943891177 5e56621aeb
commit ddcf31c5ad
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
openedx/core/djangoapps/user_authn/views/tests/test_reset_password.py
View File

@@ -191,14 +191,14 @@ class ResetPasswordTests(EventTestMixin, CacheIsolationTestCase):
self.request_password_reset(200)
# now reset the time to 1 min from now in future and change the email and
# verify that it will allow another request from same IP
for status in [200, 403]:
reset_time = datetime.now(UTC) + timedelta(seconds=61)
with freeze_time(reset_time):
reset_time = datetime.now(UTC) + timedelta(seconds=61)
with freeze_time(reset_time):
for status in [200, 403]:
self.request_password_reset(status)
# Even changing the IP will not allow more than two requests for same email.
new_ip = "8.8.8.8"
self.request_password_reset(403, new_ip=new_ip)
# Even changing the IP will not allow more than two requests for same email.
new_ip = "8.8.8.8"
self.request_password_reset(403, new_ip=new_ip)
cache.clear()