Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: inadvertent scroll when loading the instructor's extensions tab

Browse Source 
(The div with id "view-extensions" conflicts with the tab JS which sets location.hash to "view-x" in order to track the current tab)
This commit is contained in:
Braden MacDonald
2014-08-19 21:30:21 -07:00
parent 92fa79dbd0
commit dbbbe8f2cb
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lms/static/coffee/src/instructor_dashboard/extensions.coffee
View File

@@ -70,7 +70,7 @@ class Extensions
@clear_display()
@$grid_table.text 'Loading...'
@$url_input = @$section.find("#view-extensions select[name='url']")
@$url_input = @$section.find("#view-granted-extensions select[name='url']")
url = @$show_unit_extensions.data 'endpoint'
send_data =
url: @$url_input.val()
@@ -78,7 +78,7 @@ class Extensions
dataType: 'json'
url: url
data: send_data
error: (xhr) => @fail_with_error "view-extensions", "Error getting due dates", xhr
error: (xhr) => @fail_with_error "view-granted-extensions", "Error getting due dates", xhr
success: (data) => @display_grid data
@$show_student_extensions.click =>
@@ -86,14 +86,14 @@ class Extensions
@$grid_table.text 'Loading...'
url = @$show_student_extensions.data 'endpoint'
@$student_input = @$section.find("#view-extensions input[name='student']")
@$student_input = @$section.find("#view-granted-extensions input[name='student']")
send_data =
student: @$student_input.val()
$.ajax
dataType: 'json'
url: url
data: send_data
error: (xhr) => @fail_with_error "view-extensions", "Error getting due dates", xhr
error: (xhr) => @fail_with_error "view-granted-extensions", "Error getting due dates", xhr
success: (data) => @display_grid data
# handler for when the section title is clicked.

2
lms/templates/instructor/instructor_dashboard_2/extensions.html
View File

@@ -39,7 +39,7 @@
</p>
</div>
<hr/>
<div id="view-extensions">
<div id="view-granted-extensions">
<h2>${_("Viewing granted extensions")}</h2>
<p>
${_("Here you can see what extensions have been granted on particular "