Studio: addressing course re-run PR feedback

This commit is contained in:
Brian Talbot
2014-08-13 10:30:36 -04:00
committed by Ben McMorran
parent 8e3b532768
commit d695de24dc
5 changed files with 22 additions and 8 deletions

View File

@@ -52,7 +52,7 @@ require(["domReady", "jquery", "underscore", "js/utils/cancel_on_escape"],
);
// Go into creating re-run state
$('.rerun-course-save').addClass('is-disabled').addClass('is-processing').html(
'<i class="icon-refresh icon-spin"></i>' + gettext('Processing Re-run Request')
'<i class="icon icon-refresh icon-spin"></i>' + gettext('Processing Re-run Request')
);
$('.action-cancel').addClass('is-hidden');
};
@@ -176,4 +176,4 @@ require(["domReady", "jquery", "underscore", "js/utils/cancel_on_escape"],
}
});
});
});
});

View File

@@ -73,6 +73,12 @@
.rerun-course-save {
@include blue-button;
.icon {
display: inline-block;
vertical-align: middle;
margin-right: ($baseline/4);
}
}
.rerun-course-cancel {

View File

@@ -236,7 +236,7 @@
@extend %t-strong;
margin: ($baseline/2);
[class^="icon-"] {
.icon {
margin-right: ($baseline/4);
}
}
@@ -295,6 +295,14 @@
.courses {
margin: $baseline 0;
.title {
@extend %t-title6;
margin-bottom: $baseline;
border-bottom: 1px solid $gray-l3;
padding-bottom: ($baseline/2);
color: $gray-l2;
}
.title {
@extend %t-title6;
margin-bottom: $baseline;
@@ -333,12 +341,12 @@
.value {
.copy, *[class^="icon"] {
.copy, .icon {
display: inline-block;
vertical-align: middle;
}
*[class^="icon"] {
.icon {
@extend %t-icon4;
margin-right: ($baseline/2);
}

View File

@@ -162,7 +162,7 @@ require(["domReady!", "jquery", "jquery.form", "js/index"], function(doc, $) {
<dl class="course-status">
<dt class="label sr">This re-run processing status:</dt>
<dd class="value">
<i class="icon-refresh icon-spin"></i>
<i class="icon icon-refresh icon-spin"></i>
<span class="copy">Configuring as re-run</span>
</dd>
</dl>
@@ -200,7 +200,7 @@ require(["domReady!", "jquery", "jquery.form", "js/index"], function(doc, $) {
<dl class="course-status">
<dt class="label sr">This re-run processing status:</dt>
<dd class="value">
<i class="icon-warning-sign"></i>
<i class="icon icon-warning-sign"></i>
<span class="copy">Configuration Error</span>
</dd>
</dl>

View File

@@ -328,7 +328,7 @@ TODO:
<div class="actions">
<button type="submit" class="action action-primary rerun-course-save is-disabled is-processing">
<i class="icon-refresh icon-spin"></i>
<i class="icon icon-refresh icon-spin"></i>
${_('Processing Re-run Request')}
</button>
</div>